Prettify removes space between bold an italic inside figcaption

[repilo]

Hello:
When I apply right-click->"Reformat HTML->Mend and prettify Code" the space between a bold text and an italic text inside a figcaption is removed. For example:

<figcaption><b>Figure 2:</b> <i>Text

is converted to:

<figcaption><b>Figure 2:</b><i>Text


Using Sigil 1.8.0
Thanks

[JSWolf]

Unless you are using version 1.9.2, and you have the same problem, this is never going to be fixed in an old version like you are using.

[DNSB]

Originally Posted by JSWolf

Unless you are using version 1.9.2, and you have the same problem, this is never going to be fixed in an old version like you are using.

Jon, it would be much preferred if you actually tested this under 1.9.2 before posting.

  <figure>
    <img src="../Images/elephant.jpg" alt="Elephant at sunset" class="width90"/>

    <figcaption><b>Figure 2: </b> <i> An elephant at sunset</i></figcaption>
  </figure>

After 1.9.2 prettify:

  <figure>
    <img src="../Images/elephant.jpg" alt="Elephant at sunset" class="width90"/>

    <figcaption><b>Figure 2: </b><i> An elephant at sunset</i></figcaption>
  </figure>

Added <p></p> tags and prettify:

  <figure>
    <img src="../Images/elephant.jpg" alt="Elephant at sunset" class="width90"/>

    <figcaption><p><b>Figure 2: </b> <i> An elephant at sunset</i></p></figcaption>
  </figure>

And yes, prettify using 1.92 does remove the space between the </b> and the <i>. OTOH, only a single space shows when the test is displayed though other characters do. Wrapping the text in <p></p> tags will prevent that space from being removed though any string of 2 or more spaces will still be reduced to a single space.

  <figure>
    <img src="../Images/elephant.jpg" alt="Elephant at sunset" class="width90"/>

    <figcaption><p><b>Figure 2: </b>   a         b      c     d    ee       fff<i> An elephant at sunset</i></p></figcaption>
  </figure>

only shows one space between the alpha characters in the preview pane. See attached image.

[Doitsu]

Originally Posted by DNSB

After 1.9.2 prettify:

  <figure>
    <img src="../Images/elephant.jpg" alt="Elephant at sunset" class="width90"/>

    <figcaption><b>Figure 2: </b><i> An elephant at sunset</i></figcaption>
  </figure>

[...]

I was also able to reproduce this with Sigil 1.9.2 and Sigil 0.9.8.

[KevinH]

But the bold string ends with a space. Multiple whitespace in html is condensed to one space. So the prettified version and the unprettified version should show as identical in an ereader and Preview.

I just checked this:

Under Prevew, both before and after prettifying the image is identical. Nothing changed that impacts layout. See testcase.png that is attached.

So I am not convinced this is a bug at all.

As it stands, adding "figcaption" to the list of other text holder tags in Parsers/GumboInterface.cpp is enough to make it keep that space.

diff --git a/src/Parsers/GumboInterface.cpp b/src/Parsers/GumboInterface.cpp
index 45ab4e49..4847c162 100644
--- a/src/Parsers/GumboInterface.cpp
+++ b/src/Parsers/GumboInterface.cpp
@@ -84,7 +84,7 @@ static std::unordered_set<std::string> structural_tags     = {
 
 
 static std::unordered_set<std::string> other_text_holders = {
-    "address","caption","dd","div","dt","h1","h2","h3","h4","h5","h6",
+    "address","caption","dd","div","dt","figcaption","h1","h2","h3","h4","h5","h6",
     "legend","li","option","p","td","th","title"
 };

But I am not sure that is any more correct that what Sigil does now.

So this would be change with no valid reason for making one as far as I can tell.

Arguments one way or the other appreciated.

[repilo]

The space is kept in:

<figcaption><b>Figure 2: </b><i>Text

and in:

<figcaption><b>Figure 2:</b><i> Text

But the space disappears here in:

<figcaption><b>Figure 2:</b> <i>Text

joining the two words, "Figure2:Text".

[KevinH]

Yes,
That last one is a definite bug. I will push the change to add figcaption to the list of other text holders. This change will appear in the next release. Hopefully around the first weekend in June or shortly thereafter.

Thanks for clarifying things.

Until then, Using Find and Replace to wrap the contents of figcaption in a p tag before prettifying should work as a temporary stop-gap.

Originally Posted by repilo

The space is kept in:

<figcaption><b>Figure 2: </b><i>Text

and in:

<figcaption><b>Figure 2:</b><i> Text

But the space disappears here in:

<figcaption><b>Figure 2:</b> <i>Text

joining the two words, "Figure2:Text".

[DNSB]

Message deleted. Started typing and realized that @repilo had already posted what I was going to post.