It's possible to enable advanced font settings for every font?

[JSWolf]

Originally Posted by BookCat

When I went through the patch which enables the Advanced Options (with great difficulty - I had to use someone else's yamls) I remember seeing options to enable finer line spacing. You either enabled this patch, or didn't.

In practice it lets you have the lines closer together. There are some fonts which are naturally widely spaced and this 'patch' improves their appearance.

Nicely said.

[DNSB]

Originally Posted by BookCat

They're both part of the same font patch package.

I took a look at the Enable advanced settings for all font from an older package. I fail to see anything that would affect line spacing.

Enable advanced settings for all fonts:
  - Enabled: no
  - Description: |
      This patch allows the advanced font options (weight/sharpness adjustments)
      to work with sideloaded fonts too. (KEPUB - OTF and TTF. EPUB - TTF only.)
  - ReplaceBytes:
      Base:           "AdvancedFontSettingsController::loadView()"                                      # font dropdown in advanced font settings dialog
      Offset:         132
      FindInstBLX:    {SymPLT: "N3FontTypeUtil::setupMonotypeDropdown(TouchDropDown*, QString const&)"} # monotype fonts only
      ReplaceInstBLX: {SymPLT: "N3FontTypeUtil::setupDropdown(TouchDropDown*, QString const&)"}         # all fonts
  - ReplaceBytes:
      Base:           "ReadingMenuFontSettingsController::setupAdvancedOption(QString const&)"
      Offset:         112
      FindInstBLX:    {SymPLT: "N3FontTypeUtil::isMonotypeFont(QString const&)"}
      ReplaceH:       4F F0 01 00

[BookCat]

Originally Posted by DNSB

I took at look at the Enable advanced settings for all font from an older package. I fail to see anything that would affect line spacing.

It was part of one of the four yaml text files which were part of the patch. Editing the patch (to say yes/no to each option) took ages, even then the .bat failed to work. There's a lo . . . n . g thread about this. I was finally helped via PM.

If you're interested, this is the thread:

https://www.mobileread.com/forums/sh...d.php?t=345873

The line spacing isn't specifically mentioned here, as far as I can remember, but if you look through ALL the yaml files in detail, you'll find options to alter the way line spacing works.

[BookCat]

Just taken a quick look at the old yaml files. The relevant part is at the beginning of libnickel

[DNSB]

Originally Posted by BookCat

Just taken a quick look at the old yaml files. The relevant part is at the beginning of libnickel

What I am trying to say is the 10/24 line spacing options were not part of the Enable advanced settings for all fonts option. They were separate patches so I can enable the advanced font setting patch without needing to enable one of the line spacing patches Just don't enable the 10 and 24 at the same time though I think KoboPatch will now end with an error instead of trying to apply both patches.

[DNSB]

Originally Posted by BookCat

It was part of one of the four yaml text files which were part of the patch. Editing the patch (to say yes/no to each option) took ages, even then the .bat failed to work. There's a lo . . . n . g thread about this.

That's why I manage my settings through the overrides portion of the KoboPatch.yaml file. I can save the settings and then re-apply them very rapidly (I save them as overrides.txt). This also saves me from the issues that seem to happen to quite a few where they accidentally edit the wrong section of the filename.yaml files.

[ZodWallop]

Originally Posted by BookCat

They're both part of the same font patch package.

Well so is every patch. But we (or at least I) am specifically talking about one particular patch.