Does PageEdit allow you to open to cursor?

[DiapDealer]

Can confirm the fix. Thanks!

This thing's been around a long time--on every platform! I'm surprised it hasn't been reported it before now.

[KevinH]

Originally Posted by DiapDealer

Can confirm the fix. Thanks!

This thing's been around a long time--on every platform! I'm surprised it hasn't been reported it before now.

I think it was my fault. It worked up to the time I cleaned up save state info just after we did the same for Sigil. I chopped out the code that updated m_LastSWindowSize during every resize and move but fogot it was used in SaveSettings(). So maybe a release or so.

[DiapDealer]

Originally Posted by KevinH

I chopped out the code that updated m_LastSWindowSize during every resize and move but fogot it was used in SaveSettings(). So maybe a release or so.

Not so long as I thought then. I was just taking a quick look back and assuming the issue was there as as long as m_LastWindowSize was present. That wasn't the case.

No big deal (obviously! ). I'm still surprised no one asked about it until now. Wouldn't the multiple monitor folk have to keep putting it back on another monitor?

[BetterRed]

I noticed it in PE, didn't complain because I prefer programs to start in a fixed state rather than restoring the mess in which I left it last time. ¯\_(ツ)_/¯

BR

[DiapDealer]

Originally Posted by BetterRed

because I prefer programs to start in a fixed state rather than restoring the mess in which I left it last time.

Then don't leave it a mess.

[KevinH]

I think it would be rather straightforward for PageEdit to accept a cursor position number on the command line when launched from Sigil that could be used to generate a QWebPath to perform a scroll to in PageEdit's WebView.

It would not guarantee the cursor to be at the exact same place but it would end up quite close (just like syncing CodeView to Preview right now).

If there is reasonable interest in making that change, I would be happy to include it. It will only work when PageEdit is launched from Sigil. And of course only if the current file open in CV is an xhtml file when the External XTML editor icon is used.

Thoughts?

[DNSB]

While I don't use PageEdit all that often, I would find that handy instead of scrolling multiple pages to find the correct position.

Edit: compiled PageEdit and in my testing, it saves size and position when exiting.

[KevinH]

Originally Posted by DNSB

While I don't use PageEdit all that often, I would find that handy instead of scrolling multiple pages to find the correct position.

Edit: compiled PageEdit and in my testing, it saves size and position when exiting.

Okay, I will take a shot at implementing that.

And thanks for testing the PageEdit geometry fix.

[ElMiko]

Originally Posted by KevinH

Okay, I will take a shot at implementing that.

And thanks for testing the PageEdit geometry fix.

That would be really helpful. Would it only work with xhtml, or with htm/html, too?

[KevinH]

Originally Posted by ElMiko

That would be really helpful. Would it only work with xhtml, or with htm/html, too?

There is no htm or html in an epub. If you try to load an html file it will most likely cause failure of the xml parser. That is why we use our version of the gumbo repair parser to fix html into valid xhtml.

If you instead meant a file extension ending in htm or html that actually holds xhtml, it should work just fine. It is the media type/strict xml parsing rules that matters not the file extension.

[KevinH]

@DNSB and anyone else interested,

I just pushed to master changes to PageEdit and Sigil so that if you are in Sigil's CodeView and editing an xhtml file and hit the External XHtml Editor to launch PageEdit, it should nicely try its best to sync the cursor when it opens.

You will need to pull from both PageEdit master and Sigil master and rebuild both for this to work.

I hopefully made these changes to be backwards compatible so using an older PageEdit with newer Sigil and visa-versa will still work as expected but if you both are updated to master, you should see the syncing.

These fixes will appear in the next releases of both PageEdit and Sigil.

Please give them a try if you build your own and do let me know of any success or failures.

Hope this helps!

[DNSB]

New compiles of Sigil and PageEdit. The cursor seems to be on the start of the line selected in Sigil's CodeView when PageEdit opens but a lot easier than scrolling through multiple lines.

Edit: added screenshots of Sigil and PageEdit. I placed a [] where the cursor was in Sigil before opening PageEdit and where the cursor showed in PageEdit.

[KevinH]

Yes, that is expected behaviour as navigating is based in the nearest containing tag. For most text that will be the p tag that holds it.

Unfortunately when live editing html, Chrome can split text nodes and inject text nodes causing the dom to need to be re-normalized constantly. When you add to that whitespace can be compressed, offsets in text strings become an issue. So for consistency we take you to the closest destination we know will exist: the parent of the text.

This is how Preview navigates to where you click in CV, and visa versa.

[ElMiko]

FWIW, cursor at the beginning of the element is exactly what I needed (or at least what I'm used to with Book View). I'll be curious to see how it works with tables. In ye olde Book View, switching from code view when the cursor was in any given table element would result in the Book view "loading" at the beginning of the file (rather than the beginning of the element).

Looking forward to the next update(s)!

[KevinH]

@DNSB (and others who might have build or using builds from master).

Found a few minor bugs in how I calculate web paths from file positions that will impact both Sigil and PageEdit.

Just pushed a fix of both to master (in their respective versions of TagLister.h/.cpp)

So if you plan to stay with your master builds, I would pull from both and rebuild them. Not any chance of data loss, just weird syncing that might drive you crazy (between Sigil and Preview and between Sigil and PageEdit).