Why so complicated?

[foosion]

Originally Posted by Turtle91

That’s what I do most of the time (regex)… BUT … you need to be very careful of nested tags especially if you are searching for <span>s because that regex will pickup the first end tag not necessarily the correct one.

As Diap mentioned, his plugin actually parses the html to avoid that issue.

I'm not sure which post you're responding to. Assume it's recent:

I can't recall ever seeing a nested h# tag and Jon's example wasn't nested.

I'm not sure it's even possible to do nested properly with standard regex. I started a post asking about that and so far I've gotten the expected lack of response.

Anyway, agreed.

[DNSB]

I'm not certain if the calibre flavour of DiapDealer's tool will handle regex but the Sigil version does. For a <tag>blah blah blah</tag> I will use regex but where nested tags come into play, I will go with TagMechanic. I remember way back (2012, Sigil 0.5.3???) when I looked at the dog's breakfast that I created using a regex search/replace covering nested divs and exited without saving.

[JSWolf]

Originally Posted by Turtle91

That’s what I do most of the time (regex)… BUT … you need to be very careful of nested tags especially if you are searching for <span>s because that regex will pickup the first end tag not necessarily the correct one.

As Diap mentioned, his plugin actually parses the html to avoid that issue.

I agree. I use Diap's plugin for divs and spans because it works better then risking regex.

[JSWolf]

Originally Posted by DNSB

I'm not certain if the calibre flavour of DiapDealer's tool will handle regex but the Sigil version does. For a <tag>blah blah blah</tag> I will use regex but where nested tags come into play, I will go with TagMechanic. I remember way back (2012, Sigil 0.5.3???) when I looked at the dog's breakfast that I created using a regex search/replace covering nested divs and exited without saving.

The calibre version of Diaps Editing Toolbag does allow regex for the search.

[DiapDealer]

Originally Posted by Terisa de morgan

In any case, that change would be appreciated (and I've checked and I've not found the way to do it in the settings).

You can't, I checked. It shouldn't take too much to make it work by editing the plugin's preference file rather than needing to edit the plugin's code. That way, the changes would survive a plugin upgrade. I'll see what I can do.

[Terisa de morgan]

Originally Posted by DiapDealer

You can't, I checked. It shouldn't take too much to make it work by editing the plugin's preference file rather than needing to edit the plugin's code. That way, the changes would survive a plugin upgrade. I'll see what I can do.

Thank you very much! I don't do a lot of changes like that, but I use the plugin A LOT.

[DiapDealer]

Originally Posted by Terisa de morgan

Thank you very much! I don't do a lot of changes like that, but I use the plugin A LOT.

You should be able to add (or remove) tags like you do html attributes (in the settings) with this beta version. Let me know what you think.

Were you the one who provided the Spanish translation for this plugin? If so, I've got a couple of new strings that will need translating (after we make sure this will work properly).

EDIT: attachment removed

[Terisa de morgan]

Originally Posted by DiapDealer

You should be able to add (or remove) tags like you do html attributes (in the settings) with this beta version. Let me know what you think.

Were you the one who provided the Spanish translation for this plugin? If so, I've got a couple of new strings that will need translating (after we make sure this will work properly).

I'll test it today and I think I provided the translation, yes. I'll take care of it when it's ready.

[Terisa de morgan]

Originally Posted by DiapDealer

You should be able to add (or remove) tags like you do html attributes (in the settings) with this beta version. Let me know what you think.

Were you the one who provided the Spanish translation for this plugin? If so, I've got a couple of new strings that will need translating (after we make sure this will work properly).

I've added first h1,h2,h3,h4 and later h5,h6. h1,h2,h3,h4 were already in the json configuration file so, after adding the tag and opening the configuration, it was working fine and there was configuration for changing those tags. After adding h5 and h6, opening the configuration dialog show an error:

KeyError: 'h5_changes'

So, it looks like adding the tag means that the plugin is expecting later to find a configuration entry but it's not added.

[JSWolf]

Originally Posted by Terisa de morgan

I've added first h1,h2,h3,h4 and later h5,h6. h1,h2,h3,h4 were already in the json configuration file so, after adding the tag and opening the configuration, it was working fine and there was configuration for changing those tags. After adding h5 and h6, opening the configuration dialog show an error:

KeyError: 'h5_changes'

So, it looks like adding the tag means that the plugin is expecting later to find a configuration entry but it's not added.

Same error as well.

[DiapDealer]

I'll check it out. Thanks for the input.

[DiapDealer]

Try this one on for size.

EDIT: removed attachment as the new version is available in the plugin's own thread: https://www.mobileread.com/forums/sh...d.php?t=251365

[Terisa de morgan]

It works now, if I add a tag, configuration entry is added, and if I remove it, configuration entry is removed (at least from the dialog, I've not checked the json file). And thank you very much again for the change.

[DiapDealer]

The configuration entry for a removed tag will stay in the json. So if the tag is ever added back, it will already be present, That is by design (for now). Thanks for testing. I'm going to move any further beta-testing stuff to the plugin thread. I've hijacked this one long enough.

[foosion]

Originally Posted by DiapDealer

I've hijacked this one long enough.

As the OP of this thread, I'm happy to inspire such a useful hijacking.