Plugin devs: Upcoming migration to Qt 6

[Nicolas F]

Originally Posted by thiago.eec

Yes. Using get_icons('icon.png', PLUGIN_NAME) works.

You need this too:
..\resources\images\PLUGIN_NAME\icon-for-dark-theme.png
..\resources\images\PLUGIN_NAME\icon-for-light-theme.png

Yes that's what I am doing
It works for me with your plugin Check books but it's not working with @JimmXinu plugin for example.

If someone has the time to check does light and dark theming work with calibre example plugin? https://calibre-ebook.com/downloads/...emo_plugin.zip

Sorry I don't get why I can't get it to work...

And to make things more complicated, I saw that in FanFicFare code, the comments say :

        # For theme creators, use:
        # FanFicFare/images/icon.png
        # (optionally)
        # FanFicFare/images/icon-for-dark-theme.png
        # FanFicFare/images/icon-for-light-theme.png

But I can use indifferently FanFicFare/images/icon.png or FanFicFare/icon.png and it works but FanFicFare/images/icon-for-dark-theme.png or FanFicFare/icon-for-dark-theme.png doesn't for me.

[thiago.eec]

Originally Posted by thiago.eec

Yes. Using get_icons('icon.png', PLUGIN_NAME) works.

You need this too:
..\resources\images\PLUGIN_NAME\icon-for-dark-theme.png
..\resources\images\PLUGIN_NAME\icon-for-light-theme.png

Sorry. My mistake. This does not work here!

I forgot I had another call to my custom get_icon() function when rebuilding menus.

[JimmXinu]

The last time I remember discussing this, Kovid said:

Originally Posted by kovidgoyal

https://manual.calibre-ebook.com/cus...me-for-calibre

and yes for-dark vs for-light only work with themes.

Themes as in published themes, not personalized files in resources dir.

As mentioned, thiago.eec put extra code in Check Books to allow for light/dark themed icons in the resources dir that my plugins don't have.

And honestly, IMO, that's not code that should be in every plugin.

[thiago.eec]

Originally Posted by JimmXinu

And honestly, IMO, that's not code that should be in every plugin.

I wouldn't say it should be in every plugin. To me, it's just a question of flexibility and giving the user a choice. Since no theme that I know of have this implemented yet, the added code allows the user to choose icons for dark and light theme.

Besides, it's harmless for those who does not need it.

[JimmXinu]

I'm not saying you shouldn't, I'm just saying I'm not. :-)

[kovidgoyal]

As far as I recall, get_icon() uses QIcon.ic() which is what the rest of calibre uses ad that supports light/dark variants automatically. If it isnt working then it will require investigation.

[JimmXinu]

That's what Nicolas F was reporting.

Originally Posted by Nicolas F

I tried to create icons in the "resources\images\Name of the plugin" folder but it works when I use icon.png but if I use icon-for-dark-theme.png or icon-for-light-theme.png the icon doesn't show up in calibre.

I see the same thing--icon.png works in the resources dir on disk, icon-for-dark-theme.png or icon-for-light-theme.png.

From what I see, '-for-X-theme' is implemented in calibre/utils/rcc/__init__.py, not in QIcon.

Our discussion from last year:

Originally Posted by JimmXinu

Also, I'm trying to test -for-dark-theme and -for-light-theme file names on Cal6 portable by putting files in Calibre Settings\resources\images, but it doesn't appear to work?

I see in the calibre code that -for-dark-theme and -for-light-theme only appear in calibre/utils/rcc/__init__.py. Do they only work for imported icon themes?

Originally Posted by kovidgoyal

https://manual.calibre-ebook.com/cus...me-for-calibre

and yes for-dark vs for-light only work with themes.

[kovidgoyal]

Yes but compile_icon_dir_as_themes() is how themes are installed into calibre so it should work for any theme. And QIcon.ic() uses the output of compile_icon_dir_as_themes().

[JimmXinu]

Is there a step where Calibre automatically uses the old resources dir on disk to create a theme for custom icons?

Unless I misunderstand, that's the only way that code could apply to custom icons in the resources dir...

[kovidgoyal]

I thought this was about icons from themes not customised icons. IIRC, when loading from resources dir these are looked for via the overriden_icon_path() function

[JimmXinu]

Okay, I've taken a look at overriden_icon_path() in calibre/gui2/__init__.py. I think it's broken for plugins.

overriden_icon_path() is looking for -for-light/dark-theme files in override_items, which is built from looking for files in 'devices', 'mimetypes', 'plugins' dirs under resources/images.

Probably works fine for devices and mimetypes, but not for plugin custom icons.

Currently, plugin custom icons are under resources/images/<pluginname> for each plugin, not under resources/images/plugins. And just putting the pluginname dir under 'plugins' doesn't work because the code doesn't recurse.

Adding 'FanFicFare' to the 'devices', 'mimetypes', 'plugins' list works, but I don't know if adding all plugin names to that list is an appropriate solution.

[kovidgoyal]

https://github.com/kovidgoyal/calibr...cb56c36ae9b121

[chaley]

Originally Posted by kovidgoyal

https://github.com/kovidgoyal/calibr...cb56c36ae9b121

This doesn't work for me, but perhaps I am doing something wrong.

My steps:

1. I grabbed interface_demo.zip and built it. I see the 'sun' icon. It uses
   

   icon = get_icons('images/icon.png', 'Interface Plugin Demo')

   to fetch the icon.
2. I created a directory in my config 'resources\images\Interface Plugin Demo\images'.
3. I put a different 'icon.png' into that directory. Running calibre, I see that different icon.
4. I put 'icon-for-light-theme.png' in that directory and removed (renamed) 'icon.png'. I now see the default 'sun' icon.

Is this the expected behavior?

[kovidgoyal]

It should be just

resources\images\Interface Plugin Demo\

no extra images sub-folder.

[kovidgoyal]

that commit assumes images are in the plugin root which. I suppose adding support for an extra images sub-folder shouldnt be too bad.