[Enhancement] calibre:// book-details option

[ownedbycats]

New question: When a linked item is renamed, the link carries over.

What happens if an linked item is merged with another linked item by renaming it to the same thing?

[chaley]

Originally Posted by ownedbycats

What happens if an linked item is merged with another linked item by renaming it to the same thing?

One of them wins. Probably the link for the existing one, but I won't guarantee that.

EDIT: I looked at the code and it is as I thought. In all of the cases I saw the data for the already-existing value survives, including its link.

[ownedbycats]

Something like that what I expected, yeah. In most cases I think the one being merged into would be the one the user wants to keep.

[ownedbycats]

Error when clicking 'link' column header in any category manager except author:

calibre, version 6.14.1
ERROR: Unhandled exception: <b>IndexError</b>:tuple index out of range

calibre 6.14.1*  embedded-python: True
Windows-10-10.0.19045-SP0 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.19045')
Python 3.10.1
Windows: ('10', '10.0.19045', 'SP0', 'Multiprocessor Free')
Interface language: None
Successfully initialized third party plugins: DeACSM (0, 0, 16) && DeDRM (10, 0, 3) && Action Chains (1, 18, 5) && Baen (1, 1, 0) && Barnes & Noble (1, 5, 0) && CalibreSpy (1, 0, 92) && Comments Cleaner (1, 9, 0) && Count Pages (1, 13, 0) && Embed Comic Metadata (1, 6, 6) && EpubCheck (0, 2, 4) && EpubMerge (2, 15, 0) && EpubSplit (3, 5, 0) && Extract ISBN (1, 6, 0) && FanFicFare (4, 22, 3) && Fantastic Fiction (1, 6, 0) && Favourites Menu (1, 3, 0) && Find Duplicates (1, 10, 7) && Generate Cover (2, 3, 2) && GetFileName (0, 2, 0) && Goodreads (1, 7, 6) && Import List (1, 9, 0) && Job Spy (1, 0, 226) && Kindle hi-res covers (0, 5, 0) && KindleUnpack - The Plugin (0, 83, 1) && Kobo Books (1, 9, 2) && Kobo Utilities (2, 16, 7) && KoboTouchExtended (3, 6, 3) && Last Modified (0, 8, 4) && Manage Series (1, 5, 1) && Modify ePub (1, 8, 1) && MultiColumnSearch (1, 0, 96) && Obok DeDRM (7, 2, 1) && Open With (1, 8, 1) && Overdrive Link (2, 54, 0) && Quality Check (1, 13, 4) && Reading List (1, 15, 1) && Search The Internet (1, 10, 1) && SmartEject (2, 5, 0) && Standard Ebooks (1, 0, 0) && Sum Column (0, 3, 3) && View Manager (1, 10, 2) && Walk Search History (1, 5, 3) && Overdrive Link Metadata Source (2, 54, 0)
Traceback (most recent call last):
  File "D:\Documents\git\calibre\src\calibre\gui2\dialogs\tag_list_editor.py", line 666, in do_sort
IndexError: tuple index out of range

EDIT: https://github.com/kovidgoyal/calibr...371bb19cb36acf

[BetterRed]

The new book-details links aren't working, instead of showing the linked book's details window, without next/previous buttons, active values etc it shows the current book's normal details window, with the buttons etc. The books are in the same library, show-book and view-book links to the same book are fine.

Hopefully the attached image will explain better.

BR

[ownedbycats]

When I tested a few hours earlier the book-details link worked as expected for me. Do you have replication steps for to try? Maybe there's subtle differences in action that made it work for me but not you.

Here's what I did:

1. Right-clicked on the details pane and used the option to copy book details link.
2. Pasted it in another application.
3. While in a VL where the linked book didn't appear (I don't remember if anything was selected), I opened the link.

This showed the expected book.

EDIT: I just noticed that 6.15 rolled out. I had it working with 6.14.1*.

[BetterRed]

Book-details links work fine if I put them in the author Links field and if I put them them in a OneNote note. But they don't work between books in the same library (I've tried more than one) - show book and view-book links are fine.

BR

[ownedbycats]

I see this now. On 6.15 now so maybe possible something broke between then and now?

1. I copied the book details from a book.
2. I clicked on the next book in the list.
3. I pasted the link in my browser to open it.

This time I got the selected book, not the linked one. The pre-existing link from the other application also behaves this way.

EDIT: If no book is selected (e.g. just after changing the VL tab) it shows the first book in list instead.

ANOTHER EDIT: If there are no books in the list (e.g. my Cleanup VL when no new books) it just outright fails...

[BetterRed]

Originally Posted by chaley

Note that we are considering allowing the user to add a rich text document instead of a link. I suspect you would want a different icon in that case.

Is this in the 6.15 release ?

BR

[BetterRed]

Originally Posted by BetterRed

Book-details links work fine if I put them in the author Links field and if I put them them in a OneNote note. But they don't work between books in the same library (I've tried more than one) - show book and view-book links are fine.

BR

Well they work in the sense that they pop a no-frills details window but it only shows the standard columns, no custom columns.

My Creators (authors) library uses two standard columns - Authors and Rating, the rest is in 18 custom columns.

BR

[Comfy.n]

Originally Posted by BetterRed

The new book-details links aren't working, instead of showing the linked book's details window, without next/previous buttons, active values etc it shows the current book's normal details window, with the buttons etc. The books are in the same library, show-book and view-book links to the same book are fine.

Hopefully the attached image will explain better.

BR

I can confirm this is happening

[chaley]

Originally Posted by BetterRed

The new book-details links aren't working, instead of showing the linked book's details window, without next/previous buttons, active values etc it shows the current book's normal details window, with the buttons etc. The books are in the same library, show-book and view-book links to the same book are fine.

In your image, the current book is the same as one the book details link points at.

Originally Posted by BetterRed

Book-details links work fine if I put them in the author Links field and if I put them them in a OneNote note. But they don't work between books in the same library (I've tried more than one) - show book and view-book links are fine.

BR

The problem is that there is a check to see if the book details library is the current library, in which case it does the "normal" processing.

Originally Posted by BetterRed

Is this [Rich text documents] in the 6.15 release ?

BR

No.

Originally Posted by BetterRed

Well they work in the sense that they pop a no-frills details window but it only shows the standard columns, no custom columns.

My Creators (authors) library uses two standard columns - Authors and Rating, the rest is in 18 custom columns.

BR

It uses the configuration of the library it comes from. In this case both libraries are the same so the same configuration is applied.

As far as I can tell, all these issues come from the same problem -- the book details point to a book in the current library. You can work around the problem by opening a book details window on some book and leaving it open. Subsequent book details windows from links in the same library will open secondary windows.

[ownedbycats]

Originally Posted by chaley

As far as I can tell, all these issues come from the same problem -- the book details point to a book in the current library. You can work around the problem by opening a book details window on some book and leaving it open. Subsequent book details windows from links in the same library will open secondary windows.

This works for me.

Is this an intended behaviour? I'm not entirely surefrom your post.

[chaley]

Originally Posted by ownedbycats

This works for me.

Is this an intended behaviour? I'm not entirely surefrom your post.

No. I did an incorrect "optimization" that caused this. I am sending a fix to Kovid now.

[chaley]

The fix is in calibre source.

Kovid is open to making a point release but wants to wait a bit to see if there are more problems.