Sigil-1.9.1 Release

[odamizu]

Originally Posted by KevinH

Is this with a Saved Search Group with multiple finds or just one?

Multiple finds

What do you have the Saved Search controls set to?

Depends on the search — either:
NL WR DN AH
or
RX WR DN AH

Also, I will think about adding a Restart button to Saved Search but it might be for a future release as it requires new translations.

Thank you!

If you ever get a test case and sequence of events for your Saved Search bug please let me know.

Yes, will do. Thank you!

[odamizu]

Originally Posted by KevinH

If Find reports "No matches found" then you have visited all of the matches in your search set once. If you skipped replacements on 3 of them, then Count All will show 3. If you hit Restart, and run Find it should take you to to one of them you skipped. Count All should only ever show the 3 you skipped. It should never switch to 8 unless you changed the search group to include other files.

Okay, so far I'm not getting weird numbers (e.g., 3 turns into 8), but I also can't follow the above steps in Saved Searches because I keep running into "No searches selected":

1. Load a Saved Search and click Count All (let's say the result is 29)
2. Click Find 4 times in a row (which skips Replace on the first 3 matches)
3. Click Replace/Find for the rest of the matches until status is "No matches found"
4. Click Count All — status now reads: "No searches selected"
5. Go to Find & Replace box and click Restart — status now reads "Search will restart"
6. Go back to Saved Searches window and click "Count All" — status still reads "No searches selected"
7. But if I go back to Find & Replace box and do Count All from F&R box, it gives me the correct answer of 3.

If after Step 4 I load a new Saved Search (but don't click Find), then re-load original Saved Search and click Count All, I get "No matches found".

[icallaci]

Originally Posted by odamizu

I do this, too! I thought I was weird. (Though I suppose it just means we're both weird )

LOL, guilty as charged.

[Ashjuk]

Some feedback on my experience with 1.9.1 so far.

I am not a power user, so I have not come across the issues that some appear to have with Find and Replace and saved searches.

What I have observed though is that fairly regularly the icons to the left of the file names in book browser disappear, and then reappear a little later. Also when I run a well formed epub check the results pane initially appears behind the edit pane, so is partly obscured. This corrects itself after a short period of time.

Neither are major issues, as they do not affect my ability to use Sigil, but I did not see this in either 1.9.0 or 1.8.

[bravosx]

Originally Posted by Ashjuk

What I have observed though is that fairly regularly the icons to the left of the file names in book browser disappear, and then reappear a little later.

I confirm the disappearance of the icons.

[KevinH]

@Ashjuk and @bravos

Originally Posted by bravosx

I confirm the disappearance of the icons.

Nothing between 1.9.0 and these test builds changed in regards to BookBrowser at all. So I will need help tracking this down.

What actions/Tools were you using in Sigil when you see this happening? Was it search? What platform Windows or Mac?

I am testing with Mac and my icons all stay put, even after dragging and dropping them.

So I will need more info here to help track this one down and get it fixed.

Thanks!

[KevinH]

@Ashjuk,
I have never had Sigil Plugin Runner come up under Sigil (partially or fully). This could be related to changes to use Python 3.9.9.

Is this with the epubcheck plugin or with Sigil's wellformed check tool? Both are Python based. A screen cap of this error would help if you can get one.

I tried using Sigil->Tools->Well-Formed Check EPUB and the validation pane showed up right where it always does with the results. Same when trying epubcheck.

But my testing is all done on Mac, so this could be a Windows specific problem.

So I am going to need help in recreating this bug so I can track it down and get it fixed.

[KevinH]

I will look into this but some things to note:

Saved Searches add the ability to run SavedSearchGroups (multiple different searches) all sequentially, not just a single search. If you just want to treat it like a search repository to remember single searches you can do that, using Load Search and Find and Replace will give you better control in that case.

So...

1. Just like Find and Replace keeps state across a single search term and knows when done (all matches visited once), Saved Searches keep state across multiple searches. So when SavedSearches returns "No Searches Selected" means you have run all Saved Searches search terms in the selected Saved Search Group once and "No Matches Found" was returned for each.

2. In Saved Searches any time what to find, direction, or target set is changed, F&R does a restart for each new search, but SavedSearch will itself not rebuild the list of searches it wants to run until you tell it to run something else by changing selections in Saved Search.

So you should rarely need to run Restart in SavedSearches but you will need to change what you have selected to make SavedSearch reload its list of different searches to be done.

3. Count All in SavedSearch mode will count over the current list of all remaining searches to be done and will change depending on exactly which search matches have been changed so far. (multiple finds)

I hope something here helps. If you want to repeat a SavedSearch (single search or SavedSearch Group), just click on some other search and immediately click back and it will reload the just selected search group. Exactly the same way initially selecting it in SavedSearch did the first time.

All of these changes were needed to make it possible to skip over matches (no replacements) in a long list of search terms anytime you want without repeating them.

That was the requested feature.

Originally Posted by odamizu

Okay, so far I'm not getting weird numbers (e.g., 3 turns into 8), but I also can't follow the above steps in Saved Searches because I keep running into "No searches selected":

1. Load a Saved Search and click Count All (let's say the result is 29)
2. Click Find 4 times in a row (which skips Replace on the first 3 matches)
3. Click Replace/Find for the rest of the matches until status is "No matches found"
4. Click Count All — status now reads: "No searches selected"
5. Go to Find & Replace box and click Restart — status now reads "Search will restart"
6. Go back to Saved Searches window and click "Count All" — status still reads "No searches selected"
7. But if I go back to Find & Replace box and do Count All from F&R box, it gives me the correct answer of 3.

If after Step 4 I load a new Saved Search (but don't click Find), then re-load original Saved Search and click Count All, I get "No matches found".

[KevinH]

@odamizu,

I can not see any code "bugs" in SavedSearch given the rules of my previous post but I can see there is a "use-ability" bug based on your post.

So I used a suggestion you provided earlier and made the Saved Search "Load Search" button now do the following:

- rebuild the set of searches to run as if you had selected something else and then reselected what you had originally (a SavedSearch Group or single search)

- then had it tell F&R to do a Restart

By adding those two things, then when you use LoadSearch, it will be telling it to also begin the entire current selection of searches from the top again.

The issue is Count All in Saved Searches. It will always count all existing matches for whatever is remaining of the Search Group searches to be run from that point *onward*.

To see where you are when running a SavedSearch Group, look at the status message in the lower left hand corner of Saved Search. It should always tell you which search is now active and when you have run out of searches.

Hope this is an improvement. I will make a new test build (no other F&R changes) later tonight in case others report bugs today that I can track down and fix in time.

Once I have posted it, please give that new build a test run in SavedSearches given your understanding from above and see if the "use-ability" is improved.

If you wanted CountAll to work from the beginning of a SavedSearch Group, you can now use LoadSearch to make that happen.

[KevinH]

Originally Posted by icallaci

"3 matches found" or "No matches found" or "8 matches found"--all for the same search criteria, depending on what buttons I have or haven't clicked or where I am in the search--that's what I find problematic.

Okay, I just saw this during my testing.

The issue is that Count All should always count *all* not count from where I am until the end of the set of files to be searched.

Similarly Replace All should always replace *all* and not just replace from where I am now until the end of the set of files to be searched.

That is why hitting Restart changed things.

Count All was wrongly returning the number of hits from this file until the end of all files to be searched and not ALL files.

Ditto for ReplaceAll.

I will track that down and get that fixed and post a new test build tonight. In this way the CountAll and ReplaceAll buttons should be quite clear as to doing what their name actually says.

Thanks for the bug report!

So please wait for your testing until I post a new test build tonight (hopefully with any other needed fixes in place).

[Ashjuk]

Originally Posted by KevinH

@Ashjuk,
I have never had Sigil Plugin Runner come up under Sigil (partially or fully). This could be related to changes to use Python 3.9.9.

Is this with the epubcheck plugin or with Sigil's wellformed check tool? Both are Python based. A screen cap of this error would help if you can get one.

I tried using Sigil->Tools->Well-Formed Check EPUB and the validation pane showed up right where it always does with the results. Same when trying epubcheck.

But my testing is all done on Mac, so this could be a Windows specific problem.

So I am going to need help in recreating this bug so I can track it down and get it fixed.

Kevin,

The Well-Formed Check EPUB within Sigil. I will try to get a screen capture for you.

It only happens whilst the check is being carried out and the book contains errors. Once it has completed checking all files the results pane then comes to the foreground. If there are no errors in the book then the results pane appears at the bottom normally.

It is not a huge issue as the final result is what is important, but just something I have noticed since I started using 1.9.1.

As for the missing icons - I can't seem to find one operation that causes their disappearance. Double clicking a file to open it will restore the icon for that file, and then just running the mouse pointer up and down the list will restore the remainder.

Again not an issue, but something I have never experienced before.

[PapaKilo]

-Windows 10
-Sigil 1.9.1
-Search & Replace Docked at bottom of main window.

These conditions for all cases:

#1
Type something in Find, click find button.
Item is found but it is NOT highlighted in main window.
Click find button again.
Item is found but it is NOT highlighted in main window.
Click in main window.
Click find button again.
Item is found but it IS highlighted in main window.


#2
Open Saved Searches window click on a saved search.
Click find button in Saved Searches
Item is found but it is NOT highlighted in main window.

#3
Open Saved Searches window click on a saved search.
Click find button in Saved Searches
Item is found but it is NOT highlighted in main window.
Click on Replace button in docked Find & Replace dialog.
Item is Highlighted in main window, but is NOT replaced.

#4
Click on Spellcheck.
Double-click on misspelled item.
Item is found but it is NOT highlighted in main window.

All of these things functioned in previous versions.

Paul

[KevinH]

You need to have focus in the CV window before running search. All F&R will do is keep the current state.

So click in the CV window first (at least once) to establish it has focus then run your search.

Did that help?

[KevinH]

Hi All,

I decided not to wait and get a new Test build out there for people to try. It should have all search related fixes in place so far, fixes for Qt6 "hit enter in search segfaults", fixes for Count All and Replace All and modifications for Saved Searches per my discussion with odamizu (see posts above).

It can be downloaded from my repo here:

https://github.com/kevinhendricks/Bu...OnMac/releases

- Sigil-master-5ba7c90-build_num-375-Mac.tar.xz

- Sigil-master-5ba7c90-build_num-375-Win-Setup.exe

Again thanks to everyone who tests and helps make Sigil better. Hopefully we are getting closer to what will work for the most people given the design change considerations.

These builds do not include any fixes the Well-Formed Check dialog coming up partially hidden when the Sigil->Tools->Well-Formed Check EPUB tool is run and the missing icons as I can not recreate either of those (yet!).

[icallaci]

Thank you! This is exactly what I was seeing, so if you can find the problem and fix it, I will be a very satisfied Sigil user. I'll do some testing after you post the latest release. Thanks again.

Edited to add: oops, I see you beat me to it and have already posted a fix. I'll download it and give it a try later this evening.

Originally Posted by KevinH

Okay, I just saw this during my testing.

The issue is that Count All should always count *all* not count from where I am until the end of the set of files to be searched.

Similarly Replace All should always replace *all* and not just replace from where I am now until the end of the set of files to be searched.

That is why hitting Restart changed things.

Count All was wrongly returning the number of hits from this file until the end of all files to be searched and not ALL files.

Ditto for ReplaceAll.

I will track that down and get that fixed and post a new test build tonight. In this way the CountAll and ReplaceAll buttons should be quite clear as to doing what their name actually says.

Thanks for the bug report!

So please wait for your testing until I post a new test build tonight (hopefully with any other needed fixes in place).