Sigil-1.9.1 Release

[KevinH]

That is strange.

I can not recreate this with the Mac build from post #11. I added the following to two different css files:

.first-letter-h {
    /* huh 3*/
    margin-top: 1em; /* huh4 */
    margin-bottom: 1em;
    /* huh5 */
}

Then closed the tabs for those files. Then I changed to an .xhtml tab and matched your Find and Replace settings from the images and hit Find and it happily found both cases in the CSS files.

In case opening the css tabs before closing them matters in some way, I saved that epub. Closed completely out of Sigil.

Fired up Sigil, loaded my test epub and with only the xhtml file open I told it to search ALL CSS Files, for first-letter-h and clicked find and it happily worked correctly.

So I can not recreate this at all with my admittedly simplistic test case.

Could one of the hyphens in the class name be an en dash or em dash somehow?

A stripped down test case epub might help if you can post one.

Thanks.

KevinH

Originally Posted by DNSB

Using the version from message #11, I'm finding one oddity. In an eub I was editing, I wanted to search in both CSS files for 'first-letter-h'. So I entered 'first-letter-h' in the find box, set the file selection to All CSS files, and clicked find. No Matches found was returned. Now I clicked on Count All and it returned 2. This was with the focus on a .xhtml files. I then opened one of the CSS files and Find and Count All both found two instances. On the other hand, if I have a CSS file open and select search in All HTML files, the search works as expected.

Edit: Even weirder. If I change the find box to 'first-letter', it works even if I start the search with the focus on a xhtml file.

[DNSB]

Originally Posted by KevinH

That is strange.

Then closed the tabs for those files. Then I changed to an .xhtml tab and matched your Find and Replace settings from the images and hit Find and it happily found both cases in the CSS files.

In case opening the css tabs before closing them matters in some way, I saved that epub. Closed completely out of Sigil.

Fired up Sigil, loaded my test epub and with only the xhtml file open I told it to search ALL CSS Files, for first-letter-h and clicked find and it happily worked correctly.

So I can not recreate this at all with my admittedly simplistic test case.

Could one of the hyphens in the class name be an en dash or em dash somehow?

A stripped down test case epub might help if you can post one.

Thanks.

KevinH

I'm attaching a scrambled and simplified epub. A search for first-letter-h when a xhtml file has the focus and I am searching in all CSS files, count all still shows 2 matches but find shows none. If i simplify the search to first-letter, count all shows 8 matches and find finds them in turn.

The CSS is a bit of a mess in the original with such lovely items as:

.element-container-single.element-bodymatter p.first-in-chapter.first-full-width span.first-letter.first-letter-h,.element-container-single.element-bodymatter p.first-in-chapter.first-full-width span.first-letter.first-letter-j,.element-container-single.element-bodymatter p.first-in-chapter.first-full-width span.first-letter.first-letter-w {
  line-height: 1  !important;
  margin-top: -0.07em;
}

.element-container-single.element-bodymatter p.first-in-chapter.first-full-width span.first-letter.first-letter-a,.element-container-single.element-bodymatter p.first-in-chapter.first-full-width span.first-letter.first-letter-c,.element-container-single.element-bodymatter p.first-in-chapter.first-full-width span.first-letter.first-letter-e,.element-container-single.element-bodymatter p.first-in-chapter.first-full-width span.first-letter.first-letter-f,.element-container-single.element-bodymatter p.first-in-chapter.first-full-width span.first-letter.first-letter-r,.element-container-single.element-bodymatter p.first-in-chapter.first-full-width span.first-letter.first-letter-w {
  margin-right: 0.12em;
}

Removing much of the xhtml files and deleting unused CSS did simplify this quite a bit.

[odamizu]

I finally spent a little time playing with the new Find/Replace, and I must admit the new wrap behavior where search doesn't cycle forever while there are still matches takes some getting used to.

Is it possible to add a Restart button to the Saved Searches window? Otherwise I end up bouncing back and forth between the Find/Replace window and Saved Searches window to hit Restart as double-check to make sure I haven't missed a match.

And apologies for jumping in so late in this process!

ETA: I just ran DNSB's test using his scrambled.epub and I can reproduce his bug exactly as he described on my Mac using the latest test build (370). (However, when I ran KevinH's very simple test above, the search worked perfectly, no bug.)

[KevinH]

@DNSB, Thanks for the test case. If I can reproduce it, I should be able to track it down and get it fixed.

[KevinH]

Okay, I can recreate this with your scrambled.epub test case. I have tracked this down to an unhandled corner case where you are currently not in the set of files to be searched but the files to be searched has at least 2 files but the search pattern only exists in one file of the set to be searched but *not* the first file.

I am working on a fix.

[DNSB]

Originally Posted by odamizu

ETA: I just ran DNSB's test using his scrambled.epub and I can reproduce his bug exactly as he described on my Mac using the latest test build (370). (However, when I ran KevinH's very simple test above, the search worked perfectly, no bug.)

Originally Posted by KevinH

Okay, I can recreate this with your scrambled.epub test case. I have tracked this down to an unhandled corner case where you are currently not in the set of files to be searched but the files to be searched has at least 2 files but the search pattern only exists in one file of the set to be searched but *not* the first file.

I am working on a fix.

Thanks for being able to see the bug. I was beginning to wonder if the problem was a PEBKAC.

[odamizu]

Originally Posted by DNSB

Thanks for being able to see the bug. I was beginning to wonder if the problem was a PEBKAC.

I have a lot of issues due to PEBKAC

[KevinH]

Hi All,

Fixing the corner case DNSB reported took a bit of a rewrite of one routine that impacts all of search.

I really really really do not want to need a Sigil-1.9.3 so I want Sigil-1.9.2 to work (differently) but with no reversion bugs related to Search.

So I have made one more set of test builds with the fixes to all reported bugs so far (except the Qt6 Linux only crash).

I have posted them here:

https://github.com/kevinhendricks/Bu...OnMac/releases

The new builds are:

Sigil-master-408449a-build_num-372-Mac.tar.xz

and

Sigil-master-408449a-build_num-372-Win-Setup.exe

Please download them and run them through their paces search-wise. They have additional debug output built in so if we can not recreate a bug you report, we can enable that output to help track things down if needed.

As far as I can tell, this build should be it (unless my rewrite broke something else by accident).

Thanks!

KevinH

[odamizu]

Originally Posted by odamizu

Is it possible to add a Restart button to the Saved Searches window? ... And apologies for jumping in so late in this process!

Instead of adding a Restart button to the Saved Search dialog, can the Load Search button be made to serve as a Restart button?

When executing a Saved Search:

• select a Saved Search
• click Find a few times, skipping Replace
• then do a Replace All, which replaces all matches from that point to the end leaving the skipped matches unchanged
• clicking Find again results in: "No searches selected"
• clicking Load Search shows: "Loaded: [whatever search is]" but clicking Find results in "No searches selected"
• go to Find/Replace dialog and click Restart
• go back to Saved Searches window and click Find — results still show "No searches selected"
• I have to select a different search in the Saved Searches window, then go back to the previous search in order to get it to Load Search again. (If I go to the Find/Replace dialog and click Restart, I can continue the search from the F/R dialog, but going back to Saved Searches window still gives me "No searches selected" until I load a different search.)

Not sure if this is expected behavior or not, and I can work around it by selecting a different search then going back to my desired search if necessary, but if Load Search can double as a Restart button in the Saved Searches window that would be helpful. Thank you.

On the bright side, I tested DNSB's scrambled.epub for first-letter-h and Sigil build 372 found them

[KevinH]

Any change to Find, or target files, or direction, will perform the equivalent of a Restart. That is true from Saved Search and F & R.

But the point to this whole redesign is that you should rarely or never need Restart, as you do not need to go past your beginning point anymore just to see if you hit all matches when search is operating properly (as it should be with this build).

Once you get the "No Matches Found" message, that means you have already visited each match one time since you started this search. You already decided which ones to replace and which ones to skip.

People are so used to how the old search worked, they expect new search to need the same things. But searching past the end is not one of them.

If you truly want to rerun a just finished search you can, by hitting Restart in F&R dialog, or just change direction (up to down or visa-versa) and repeat it until you again get the "No Matches Found" but in the opposite direction.

It just takes some getting used to as the only way to know that before was to try to search around back to your starting point. Now just learn to rely on Sigil to keep track.

Once working (again hopefully with this build) this will prevent missed searches while allowing entire Saved Search Groups to be run sequentially by selecting the Group and hitting Find again and again while all you do is decide to skip a match or replace it. It will run through the entire set of Search Group tests stopping only at the end.

But to search past your starting point is just not a needed anymore (with hopefully this build) given Sigil's search keeps track if what matches were visited for any set of find value, target search group and search direction.

I realize it is different from before, but it should be faster (fewer clicks), safer (each match visited once and only once), and allows Saved Searches to skip over replacements and continue the search until the end (which was not even possible before).

It just requires Search to work correctly (which it hopefully will now).

[icallaci]

Quite often I view several consecutive matches before I decide if my search is actually finding what I intended. This means I don't start replacing until I have already stepped through the first several matches. I also don't necessarily replace every match I find, so I like to cycle through again in case I want to change my decisions. I am learning to live with Sigil ending a search when it decides instead of me deciding, since all I have to do at that point is select Restart. The problem comes when I click on Count All and see "3 matches found," but when I click on Find I see "No matches found." Then I click on Restart and now Count All tells me "8 matches found."

"3 matches found" or "No matches found" or "8 matches found"--all for the same search criteria, depending on what buttons I have or haven't clicked or where I am in the search--that's what I find problematic.

I know you are exasperated and frustrated with those of us who do not use Find and Replace as you do, but this new behavior causes me me to double- and triple-check my work constantly. I understand that there are reasons for changing Find and Replace. I am trying to train myself to Restart searches from the top file in a group. I realize too that you are volunteering your time to make Sigil the best epub editor on the planet. I use it every day and thank you for it. This will be my last post on the subject.

[KevinH]

Originally Posted by icallaci

The problem comes when I click on Count All and see "3 matches found," but when I click on Find I see "No matches found." Then I click on Restart and now Count All tells me "8 matches found."

I need a test case epub and sequence of steps and F and R settings to recreate exactly what you just described above with the very latest test build.

If Find reports "No matches found" then you have visited all of the matches in your search set once. If you skipped replacements on 3 of them, then Count All will show 3. If you hit Restart, and run Find it should take you to to one of them you skipped. Count All should only ever show the 3 you skipped. It should never switch to 8 unless you changed the search group to include other files.

If the build I just posted is doing anything else that is a bug. One I need to track down and fix.

"3 matches found" or "No matches found" or "8 matches found"--all for the same search criteria, depending on what buttons I have or haven't clicked or where I am in the search--that's what I find problematic.

I do too, so please explain the exact steps you are running that shows that with the very latest Test build.

[icallaci]

Originally Posted by KevinH

I need a test case epub and sequence of steps and F and R settings to recreate exactly what you just described above with the very latest test build.

If Find reports "No matches found" then you have visited all of the matches in your search set once. If you skipped replacements on 3 of them, then Count All will show 3. If you hit Restart, and run Find it should take you to to one of them you skipped. Count All should only ever show the 3 you skipped. It should never switch to 8 unless you changed the search group to include other files.

If the build I just posted is doing anything else that is a bug. One I need to track down and fix.

I do to, so please explain the exact steps you are running that shows that with the very latest Test build.

I've downloaded the latest release and will test it as soon as I can (probably tomorrow evening). Hopefully it will work as you describe above. If so, then I will have no complaints about the new behavior. Thanks for your patience.

[odamizu]

Originally Posted by KevinH

... If you truly want to rerun a just finished search you can, by hitting Restart in F&R dialog, or just change direction (up to down or visa-versa) and repeat it until you again get the "No Matches Found" but in the opposite direction.

Yes, that works fine if I'm working in F&R dialog box, but doesn't work when I'm working in Saved Searches window. With Saved Searches, the only way to Restart is to load a new search then go back to the one I was working with. Going to F&R dialog to hit Restart does not cause Saved Searches to Restart in the Saved Searches window. I have to hit Restart then continue in the F&R dialog box instead. Or load a new search in the Saved Searches window then go back to the one I was working with. It's confusing to work this way. A Restart button in the Saved Searches window would solve this for me.

Originally Posted by icallaci

Quite often I view several consecutive matches before I decide if my search is actually finding what I intended. This means I don't start replacing until I have already stepped through the first several matches.

I do this, too! I thought I was weird. (Though I suppose it just means we're both weird )

I know you are exasperated and frustrated with those of us who do not use Find and Replace as you do, but this new behavior causes me me to double- and triple-check my work constantly. I understand that there are reasons for changing Find and Replace. I am trying to train myself to Restart searches ...

Ditto. And I also appreciate all your time and effort on Sigil, which is one of my favorite programs.

Originally Posted by KevinH

... If Find reports "No matches found" then you have visited all of the matches in your search set once. If you skipped replacements on 3 of them, then Count All will show 3. If you hit Restart, and run Find it should take you to to one of them you skipped. Count All should only ever show the 3 you skipped. It should never switch to 8 unless you changed the search group to include other files.

Yes, this works in the F&R dialog box, but it doesn't work in the Saved Searches window. I get odd Count All results in the Saved Searches window, which I'm still trying to figure out what's going on so I can explain ...

(I am working with latest test build 372.)

[KevinH]

Originally Posted by odamizu

Yes, this works in the F&R dialog box, but it doesn't work in the Saved Searches window. I get odd Count All results in the Saved Searches window, which I'm still trying to figure out what's going on so I can explain ...

(I am working with latest test build 372.)

I will run more tests from Saved Searches. I had it working properly previously (pre-1.9.0j) but given all the recent changes (almost a complete rewrite of Search, I probably broke something.

Is this with a Saved Search Group with multiple finds or just one? What do you have the Saved Search controls set to?

Also, I will think about adding a Restart button to Saved Search but it might be for a future release as it requires new translations.

If you ever get a test case and sequence of events for your Saved Search bug please let me know.