Plugin devs: Upcoming migration to Qt 6 - Page 11

theducks · 02-03-2022, 12:12 PM

I double clicked on a word in the spell check list (should jump to where used)

Code:

calibre, version 5.99.6
ERROR: Unhandled exception: <b>TypeError</b>:index 0 has type 'str' but 'QTextLength' is expected

calibre 5.99.6  embedded-python: True
Windows-10-10.0.19044 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.19044')
Python 3.10.1
Windows: ('10', '10.0.19044', '', 'Multiprocessor Free')
Interface language: None
Successfully initialized third party plugins: Gather KFX-ZIP (from KFX Input) (1, 46, 0) && Package KFX (from KFX Input) (1, 46, 0) && APNX Generator (1, 1, 0) && Count Pages (1, 11, 2) && Diaps Editing Toolbag (0, 3, 7) && EpubMerge (2, 12, 0) && EpubSplit (3, 2, 0) && Extract ISBN (1, 5, 0) && Fantastic Fiction (1, 5, 1) && Fantastic Fiction Adults (1, 2, 0) && Find Duplicates (1, 9, 2) && Generate Cover (2, 1, 0) && Goodreads (1, 5, 3) && Import List (1, 8, 1) && Job Spy (1, 0, 190) && KFX metadata reader (from KFX Input) (1, 46, 0) && KFX Input (1, 46, 0) && Set KFX metadata (from KFX Output) (1, 58, 0) && KFX Output (1, 58, 0) && KePub Input (3, 4, 3) && KePub Metadata Reader (3, 4, 3) && KePub Metadata Writer (3, 4, 3) && KePub Output (3, 5, 3) && Kindle Collections (1, 7, 29) && KindleUnpack - The Plugin (0, 83, 1) && Kobo Books (1, 8, 3) && Kobo Utilities (2, 15, 1) && KoboTouchExtended (3, 5, 4) && LanguageTool (0, 1, 2) && Manage Series (1, 3, 0) && Modify ePub (1, 7, 0) && Obok DeDRM (6, 7, 0) && Open With (1, 7, 0) && Quality Check (1, 12, 0) && Resize Cover (1, 1, 0) && Search The Internet (1, 8, 1) && Smashwords Metadata (1, 0, 2) && Sort CSS (0, 2, 0)
Traceback (most recent call last):
  File "calibre\gui2\tweak_book\boss.py", line 1156, in find_word
  File "calibre\gui2\tweak_book\spell.py", line 1434, in find_next
  File "calibre\gui2\tweak_book\editor\widget.py", line 325, in find_spell_word
  File "calibre\gui2\tweak_book\editor\text.py", line 552, in find_spell_word
  File "calibre\gui2\tweak_book\editor\text.py", line 722, in spellcheck_locale_for_cursor
  File "calibre\gui2\tweak_book\editor\syntax\base.py", line 217, in parse_single_block
  File "calibre\gui2\tweak_book\editor\syntax\base.py", line 24, in run_loop
  File "calibre\gui2\tweak_book\editor\syntax\html.py", line 307, in normal
  File "calibre\gui2\tweak_book\editor\syntax\html.py", line 244, in process_text
  File "calibre\gui2\tweak_book\editor\syntax\html.py", line 74, in spell_property
TypeError: index 0 has type 'str' but 'QTextLength' is expected

kovidgoyal · 02-04-2022, 02:17 AM

@theducks: https://github.com/kovidgoyal/calibr...fddee7d0f0a65f

democrite · 02-07-2022, 03:09 PM

Perhaps you’re waiting for more fixes for a new build. One particular fix not related to Qt 6 affects my daily use; plus I am on macOS arm64 so using v6. If it’s not too much to ask, a new build sometime would be very helpful. Thanks.

kovidgoyal · 02-07-2022, 07:09 PM

Quote:

Originally Posted by democrite

Perhaps you’re waiting for more fixes for a new build. One particular fix not related to Qt 6 affects my daily use; plus I am on macOS arm64 so using v6. If it’s not too much to ask, a new build sometime would be very helpful. Thanks.

Run from source, it's trivial. https://manual.calibre-ebook.com/develop.html

lomkiri · 02-08-2022, 08:48 AM

(linux, calibre 5.99.6)
When an epub is read-only, the action "Save" fails, which is logical.
What is not expected is that the action "save as" also fails. Is it normal ?

Spoiler:

A remark:
With "Save", even if it written that is a permission problem, it is not obvious to understand that the epub is R/O since the error msg gives the name of the cached file, not of the epub. Would it be possible to name the original file, not the cache ?
Here is what we get with "Save":

Spoiler:

kovidgoyal · 02-08-2022, 10:55 AM

In oder to ensure you are never left with corrupted files, the editor does atomic writing, which means it writes to a temp file and then renames it. There is no generally robust method to change filenames in errors.

As for save as, there is a permissions problem in the path you chose for the save as, as well.

And note that r/o error is a permissions error, r/o means you dont have write permission.

lomkiri · 02-08-2022, 11:34 AM

errata: I was speaking about "save a copy" (since "save as" is not an existing action)

Quote:

Originally Posted by kovidgoyal

In oder to ensure you are never left with corrupted files, the editor does atomic writing, which means it writes to a temp file and then renames it. There is no generally robust method to change filenames in errors.

Ok, thank you for the explanation

Quote:

As for save as, there is a permissions problem in the path you chose for the save as, as well..

No, /data/temp/ is 777.
In fact, giving w/r permission to the original epub (and no other action) solves the case and I can "save a copy" (perms of /data/temp/ didn't change)

Code:

calibre, version 5.99.6
Copy saved: Copy saved to /data/temp/Test notes calibre.epub

That's why I presume that the permission of the destinatary dir. (w/r) is mixed up with the permission of the original file (w/o)

Anyway, not a big deal, thank you.

kovidgoyal · 02-08-2022, 10:37 PM

https://github.com/kovidgoyal/calibr...644a1eef462665

georgemk · 02-09-2022, 04:19 AM

Running from QT6 source seeing this warning at startup

Code:

[0.27] Constructing main UI...
DEBUG:    0.0 obok::utilities.py - loading translations
DEBUG:    0.0 obok::dialogs.py - loading translations
DEBUG:    0.0 obok::config.py - loading translations
DEBUG:    0.3 obok::action_err.py - loading translations
qt.gui.imageio: libpng warning: iCCP: known incorrect sRGB profile
[3.86] main UI initialized...

kovidgoyal · 02-09-2022, 05:52 AM

That's harmless

lomkiri · 02-09-2022, 05:57 AM

Thank you.

But running from source (downloaded today) with "calibre-debug -t" gives this error:

Spoiler:

Code:

 % calibre-debug -t
Turning on automatic hidpi scaling
devicePixelRatio: 1.0
logicalDpi: 96.0 x 96.0
physicalDpi: 93.6046065259117 x 93.62457337883959
Using calibre Qt style: True
Traceback (most recent call last):
  File "runpy.py", line 194, in _run_module_as_main
  File "runpy.py", line 87, in _run_code
  File "site.py", line 45, in <module>
  File "site.py", line 41, in main
  File "/data/opt/calibre-source/last/src/calibre/debug.py", line 288, in main
    ebook_edit(['ebook-edit'] + args[1:])
  File "/data/opt/calibre-source/last/src/calibre/gui_launch.py", line 104, in ebook_edit
    main(args)
  File "/data/opt/calibre-source/last/src/calibre/gui2/tweak_book/main.py", line 99, in main
    _run(args)
  File "/data/opt/calibre-source/last/src/calibre/gui2/tweak_book/main.py", line 77, in _run
    main = Main(opts, notify=notify)
  File "/data/opt/calibre-source/last/src/calibre/gui2/tweak_book/ui.py", line 348, in __init__
    self.central = Central(self)
  File "/data/opt/calibre-source/last/src/calibre/gui2/tweak_book/ui.py", line 97, in __init__
    self.search_panel = SearchPanel(self)
  File "/data/opt/calibre-source/last/src/calibre/gui2/tweak_book/search.py", line 480, in __init__
    self.widget = SearchWidget(self)
  File "/data/opt/calibre-source/last/src/calibre/gui2/tweak_book/search.py", line 255, in __init__
    self.find_text = ft = HistoryBox(self, _('Clear search &history'))
  File "/data/opt/calibre-source/last/src/calibre/gui2/tweak_book/search.py", line 96, in __init__
    HistoryComboBox.__init__(self, parent, strip_completion_entries=False)
  File "/data/opt/calibre-source/last/src/calibre/gui2/widgets2.py", line 83, in __init__
    EditWithComplete.__init__(self, parent, sort_func=lambda x:b'', strip_completion_entries=strip_completion_entries)
  File "/data/opt/calibre-source/last/src/calibre/gui2/complete2.py", line 451, in __init__
    self.setLineEdit(LineEdit(
  File "/data/opt/calibre-source/last/src/calibre/gui2/complete2.py", line 312, in __init__
    self.mcompleter = Completer(completer_widget, sort_func=sort_func, strip_completion_entries=strip_completion_entries)
  File "/data/opt/calibre-source/last/src/calibre/gui2/complete2.py", line 105, in __init__
    self.tab_accepts_uncompleted_text = (tweaks['tab_accepts_uncompleted_text'] and
KeyError: 'tab_accepts_uncompleted_text'

If I run the same command with the source of the 5.99.4 (or 5.99.3, I don't remember, but the changelog date is 2022-01-21), then I get no error.

georgemk · 02-09-2022, 06:14 AM

@kovid I couldn't see any harm but thought it worth raising. Thanks for checking.

kovidgoyal · 02-09-2022, 07:22 AM

Update to the just released 5.99.7 and you will be fine.

lomkiri · 02-09-2022, 08:30 AM

Thanks again :-)

Binary is ok, but running calibre-debug -t from source (calibre-5.99.7.tar.xz) gives me another exception:

Spoiler:

"Save" and "Save a copy" are now both able to save even if the file is r/o

kovidgoyal · 02-09-2022, 09:27 AM

Is your source checkout clean? Try recreating it.

02-08-2022, 08:48 AM	#155
lomkiri Groupie Posts: 167 Karma: 1497966 Join Date: Jul 2021 Device: N/A	(linux, calibre 5.99.6) When an epub is read-only, the action "Save" fails, which is logical. What is not expected is that the action "save as" also fails. Is it normal ? Spoiler: Traceback (most recent call last): File "calibre/gui2/tweak_book/job.py", line 33, in run File "calibre/gui2/tweak_book/boss.py", line 1316, in do_save File "calibre/gui2/tweak_book/save.py", line 70, in save_container File "calibre/ebooks/oeb/polish/container.py", line 1412, in commit File "calibre/ebooks/tweak.py", line 61, in zip_rebuilder File "calibre/utils/zipfile.py", line 761, in __init__ PermissionError: [Errno 13] Permission denied: '/data/temp/.ub6r5jw8.epub' A remark: With "Save", even if it written that is a permission problem, it is not obvious to understand that the epub is R/O since the error msg gives the name of the cached file, not of the epub. Would it be possible to name the original file, not the cache ? Here is what we get with "Save": Spoiler: Traceback (most recent call last): File "calibre/gui2/tweak_book/save.py", line 192, in process_save File "calibre/gui2/tweak_book/save.py", line 204, in do_save File "calibre/gui2/tweak_book/save.py", line 70, in save_container File "calibre/ebooks/oeb/polish/container.py", line 1412, in commit File "calibre/ebooks/tweak.py", line 61, in zip_rebuilder File "calibre/utils/zipfile.py", line 761, in __init__ PermissionError: [Errno 13] Permission denied: '/data/temp/epub-test/.715gkqs3.epub' Last edited by lomkiri; 02-08-2022 at 08:53 AM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Suggestion for PI Devs	BetterRed	Plugins	11	09-27-2020 06:18 PM
Attn plugin devs: porting to python 3	kovidgoyal	Plugins	129	06-16-2020 01:31 AM
Attention All Plugin Devs: Remove vestiges from python 2?	KevinH	Plugins	11	05-29-2020 03:16 PM
Plugin Devs: Should we include a License or COPYING file?	KevinH	Plugins	3	08-15-2017 01:09 PM
New Plugin Features in the upcoming Sigil 0.8.900	KevinH	Plugins	6	09-14-2015 02:48 PM

02-04-2022, 02:17 AM	#152
kovidgoyal creator of calibre Posts: 45,400 Karma: 27756918 Join Date: Oct 2006 Location: Mumbai, India Device: Various	@theducks: https://github.com/kovidgoyal/calibr...fddee7d0f0a65f

02-07-2022, 03:09 PM	#153
democrite Evangelist Posts: 441 Karma: 77256 Join Date: Sep 2011 Device: none	Perhaps you’re waiting for more fixes for a new build. One particular fix not related to Qt 6 affects my daily use; plus I am on macOS arm64 so using v6. If it’s not too much to ask, a new build sometime would be very helpful. Thanks.

02-08-2022, 10:55 AM	#156
kovidgoyal creator of calibre Posts: 45,400 Karma: 27756918 Join Date: Oct 2006 Location: Mumbai, India Device: Various	In oder to ensure you are never left with corrupted files, the editor does atomic writing, which means it writes to a temp file and then renames it. There is no generally robust method to change filenames in errors. As for save as, there is a permissions problem in the path you chose for the save as, as well. And note that r/o error is a permissions error, r/o means you dont have write permission.

02-08-2022, 10:37 PM	#158
kovidgoyal creator of calibre Posts: 45,400 Karma: 27756918 Join Date: Oct 2006 Location: Mumbai, India Device: Various	https://github.com/kovidgoyal/calibr...644a1eef462665

02-09-2022, 05:52 AM	#160
kovidgoyal creator of calibre Posts: 45,400 Karma: 27756918 Join Date: Oct 2006 Location: Mumbai, India Device: Various	That's harmless

02-09-2022, 06:14 AM	#162
georgemk Addict Posts: 243 Karma: 291844 Join Date: Oct 2019 Device: Kobo Nia	@kovid I couldn't see any harm but thought it worth raising. Thanks for checking.

02-09-2022, 07:22 AM	#163
kovidgoyal creator of calibre Posts: 45,400 Karma: 27756918 Join Date: Oct 2006 Location: Mumbai, India Device: Various	Update to the just released 5.99.7 and you will be fine.

02-09-2022, 09:27 AM	#165
kovidgoyal creator of calibre Posts: 45,400 Karma: 27756918 Join Date: Oct 2006 Location: Mumbai, India Device: Various	Is your source checkout clean? Try recreating it.