Official Calibre PPA?

[kovidgoyal]

Here's a one liner:

calibre-debug -c "import urllib as u; from calibre.constants import numeric_version; raise SystemExit(int(numeric_version < (tuple(map(int, u.urlopen('http://calibre-ebook.com/downloads/latest_version').read().split('.'))))))"

[aleyx]

Good to know, thanks!

I'd put that in a -c one-liner, but sys.exit() seems to hiccup when used that way. I'll find a way.

#!/usr/bin/env python
## -*- coding: utf-8 -*-
import urllib as u
from calibre.constants import numeric_version

if numeric_version < tuple(map(int, u.urlopen('http://calibre-ebook.com/downloads/latest_version').read()[:-1].split("."))):
        sys.exit(0)
else:
        sys.exit(1)

[aleyx]

Seems like calibre-debug returns 0 regardless of the way the script (or -c command) exits. All of those return 0:

aleyx@grey:~/bin$ calibre-debug -c "sys.exit(1)"; echo $?
0
aleyx@grey:~/bin$ calibre-debug -c "sys.exit(0)"; echo $?
0
aleyx@grey:~/bin$ calibre-debug -c "raise SystemExit(0)"; echo $?
0
aleyx@grey:~/bin$ calibre-debug -c "raise SystemExit(1)"; echo $?
0

So my calibre-check.py becomes:

#!/usr/bin/env python
## -*- coding: utf-8 -*-
import urllib as u
from calibre.constants import numeric_version

if numeric_version < tuple(map(int, u.urlopen('http://calibre-ebook.com/downloads/latest_version').read()[:-1].split("."))):
        print "obsolete"
        raise SystemExit(1)
else:
        print "up-to-date"
        raise SystemExit(0)

And calibre-update.sh becomes:

#!/bin/bash
if calibre-debug $HOME/bin/calibre-check.py | grep -q "obsolete"; then
        killall calibre-server
        sudo python -c "import sys; py3 = sys.version_info[0] > 2; u = __import__('urllib.request' if py3 else 'urllib', fromlist=1); exec(u.urlopen('http://status.cali
bre-ebook.com/linux_installer').read()); main(install_dir='/opt')"
        $HOME/bin/calibre-server.sh
else
        echo "Calibre is up-to-date"
fi

Seems to work so far.

EDIT: newer version of update code here

[kovidgoyal]

Works for me:

calibre-debug -c "raise SystemExit(127)"; echo $?
127

[aleyx]

There must be something wrong with my setup then, because I get 0 for that one as well.

Strange, and therefore interesting. I'll have to look deeper into this.

[kovidgoyal]

It might be that the binary linux build doesn't handle exit codes in this situation. The binary builds are not vanilla python but python inside a C wrapper program and it may be that the wrapper program only reports error codes if no exception is raised. Although it should be reporting the error code as 1 not 0 when raising an exception. What happens if you raise a normal exception (not SystemExit)?

[kovidgoyal]

You can also try doing os._exit(code) which will bypass the machinery associated with python sgutdown.

[kovidgoyal]

Here's a fix for the binary build not handing SystemExit correctly. https://github.com/kovidgoyal/calibr...f473326a41e38e

[aleyx]

Following v1.11.0, here's the corrected calibre-update.sh:

#!/bin/bash

calibre-debug -c "import urllib as u; from calibre.constants import numeric_version; raise SystemExit(int(numeric_version  < (tuple(map(int, u.urlopen('http://calibre-ebook.com/downloads/latest_version').read().split('.'))))))"

UP_TO_DATE=$?

if [ $UP_TO_DATE = 0 ]; then
        echo "Calibre is up-to-date"
else
        killall calibre-server
        $HOME/bin/calibre-backup.sh
        sudo python -c "import sys; py3 = sys.version_info[0] > 2; u = __import__('urllib.request' if py3 else 'urllib', fromlist=1); exec(u.urlopen('http://status.calibre-ebook.com/linux_installer').read()); main(install_dir='/opt')"
        $HOME/bin/calibre-server.sh
fi

With Kovid's one-liner for the check, the separate calibre-check.py file is now unnecessary.

Should I go back in my previous posts and remove the obsolete versions? I usually hate to delete code when there's no version control (yeah, even little snippets like those; code is code), but I don't really know if there's a policy here regarding code obsolescence.

[eschwartz]

Just make a note:

EDIT: newer version of update code here.

Thanks for the update.

[aleyx]

Originally Posted by eschwartz

Just make a note:

EDIT: newer version of update code here.

Thanks, I'll do that.

Originally Posted by eschwartz

Thanks for the update.

You're welcome ^^

[Geremia]

I get this error:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "<string>", line 356, in main
  File "<string>", line 192, in prints
TypeError: encode() argument 1 must be string, not None

[aleyx]

Do you run the code posted here?

If not, what command do you run?

[eschwartz]

I know the answer to this one!

Originally Posted by eschwartz

And Kovid fixed that. See here: Official calibre PPA? where we discussed updating via a script using that check.

This thread also has a nice elegant way of checking if there is an update available -- Kovid helped us thrash it out.

Here it is:

#!/bin/bash

calibre-debug -c "import urllib as u; from calibre.constants import numeric_version; raise SystemExit(int(numeric_version  < (tuple(map(int, u.urlopen('http://calibre-ebook.com/downloads/latest_version').read().split('.'))))))"

UP_TO_DATE=$?

if [ $UP_TO_DATE = 0 ]; then
        echo "Calibre is up-to-date"
else
        killall calibre calibre-server
        sudo python -c "import sys; py3 = sys.version_info[0] > 2; u = __import__('urllib.request' if py3 else 'urllib', fromlist=1); exec(u.urlopen('http://status.calibre-ebook.com/linux_installer').read()); main(install_dir='/opt')"
fi

Originally Posted by Geremia

Wow, thanks for that, but I get this error:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "<string>", line 356, in main
  File "<string>", line 192, in prints
TypeError: encode() argument 1 must be string, not None

[Geremia]

Originally Posted by aleyx

Do you run the code posted here?

Yes, exactly that code

Of course, I only get this problem when Calibre isn't up-to-date, so the script does successfully detect Calibre is up-to-date.