[Device Plugin] Kobo Touch Extended Driver

[met67]

Originally Posted by jgoguen

This diff fails to apply. I took a quick look at your container.py and it looks like you've got mixed tabs and spaces for indentation (specifically, 72 tab characters over 29 lines), which Python won't accept and will throw an exception over, and your indentation is way off in some places (even if I convert each tab character to four spaces) as a result. Please re-do container.py, using four spaces as indentation (no tab characters anywhere), make sure indentation is correct, and re-verify just to make sure that nothing got messed up fixing the indentation.

What OS are you running and what editor are you using? There may be some settings changes that you can make to make Python coding easier. If you're using vim I could add the appropriate comment to the top of the file so vim correctly applies the important settings.

Yes, it may well be that I have mixed spaces and tabs (this is my first run with python...).
AW I have successfully used the container.py that I added together with the other file from the last released plugin, without exceptions.
I wrote this under Windows 7, using Ultraedit and I think I use tab set to 2 spaces.
The problem is that I am leaving tomorrow with my family and won't be back near a PC for at least 3 weeks (I'll take my tablet, but no PC).

I'll try to take a look at it tonight, will let you know.

[met67]

Last chance before blackout

I've changed tab with spaces and re-made the diff (couldn't test it, though).

As for my changes, you can just replace your '__add_kobo_spans_to_node()' with mine and add '__append_kobo_spans_from_text()' just before it.
(There is a minor change in 'add_kobo_spans()', I initialize 'segment_counter' to 1 instead than 0, but this should not be a problem)

[jgoguen]

Considering that it's the difference between kobo.1.0 and kobo.1.1 it probably doesn't matter, but then again I figured that nested spans wouldn't matter since it's still valid XHTML

If this doesn't work for me I'll try to apply it manually and test it, I'd like to get this in for the update I need to release close to the calibre 0.9.42 update.

[jgoguen]

Good work! The diff applied cleanly, no errors when I checked, and a couple books I tried it on seem to be working properly. I'll commit this and have it out with 2.1.0

[davidfor]

Originally Posted by jgoguen

davidfor may have something for you in this next calibre update...

I just have to do the bit I hate most: documentation

[theducks]

Originally Posted by davidfor

I just have to do the bit I hate most: documentation

Do you know of any developer that likes to do the documentation part?

[jgoguen]

That's why technical writers are in demand. Plus, they can write it better and faster than most developers could

[jgoguen]

KTE 2.1.0 has been posted. I've asked Kovid to update the plugin index entry, which I expect he'll do around the same time the calibre 0.9.42 release is posted.

This update requires calibre 0.9.42 due to some fairly significant changes in the KoboTouch driver. Good changes though, making the necessary changes on my end reduced the size of my code by about 20%

For bugs, 2.1.0 fixes bug 1205702, where met67 has fixed the nested Kobo span tags. Not too shabby for a first run with Python!

[davidfor]

Originally Posted by theducks

Do you know of any developer that likes to do the documentation part?

Originally Posted by jgoguen

That's why technical writers are in demand. Plus, they can write it better and faster than most developers could

Well you can see how bad I am by reading https://www.mobileread.com/forums/sho...56#post2584056.

[taming]

The plugin was available to me before the new calibre update. I am glad that I read this thread and knew to wait and do the calibre update first.

[jgoguen]

Yea, with time differences there really wasn't any way to make the plugin available at the same time as calibre 0.9.42. The update happens at something like 2am or 3am my time, so either the plugin would be early and fail to load, or late and running in an unsupportable state.

Calibre 0.9.42 is available now though! Probably posted not long after you posted, the post time says 2:53am for me and it seems that the calibre update goes up around then.

[PeterT]

Originally Posted by taming

The plugin was available to me before the new calibre update. I am glad that I read this thread and knew to wait and do the calibre update first.

Well it showed as available for me too but was not installable since the version of calibre it needed was 0.9.42 and I was on 0.9.41

[PeterT]

I wonder if it would make more sense to centralize the various options that the KoboTouchExtended driver and Kobo Utility plugin have for creating database triggers.

Currently we seem to have
KTE:

• Block Kobo Analytics DB
• Dismiss New Book Tiles
• Dismiss Award Titles

Util:

• Awards
• Extras
• Library
• Recommendations
• Shelf
• Top 50
• Bookstore
• Global Stats
• Quick Tour
• Related Items
• Sync

Logically, to my mind at least (and we all know how irrational my mind can be at times), all these triggers belong in one place; the Utility and not the driver.

[buffaloseven]

Just a quick question...what exactly does "Clean internal ePub Markup" do? Is it worth checking?

[jgoguen]

I recommend checking it, but really it's up to you. What it does is:

• Convert em-dashes and en-dashes to their ASCII representation (two and three dashes, respectively; makes it a lot easier later to deal with the XHTML)
• Remove empty header tags
• Remove Unicode replacement characters (�)
• Remove any cruft from any Microsoft program that may have been involved in creating the ePub

In a proper well-formed book, this won't actually do anything. Books made and validated as fully valid with Sigil (or even just validated), for example, won't be changed by this option. However, publishers tend not to always put out well-formed books (which is a shame, that's part of their job IMO) and self-published novels I've looked inside of have generally been even worse.