[Device Plugin] Kobo Touch Extended Driver

[buffaloseven]

Originally Posted by jgoguen

Yes, unfortunately so. It will continue to be so until I get around to re-working how the Kobo spans are added. With a small child due Any Day Now, that could be a while before I get around to even looking at it

That's what I thought. I'm excited for you getting a new addition to the family! Our little guy is almost 2 now and it's been one of the best things ever

[taming]

Originally Posted by buffaloseven

That's what I thought. I'm excited for you getting a new addition to the family! Our little guy is almost 2 now and it's been one of the best things ever

My little guy is 38, and continues to be one of the best things ever.

[jgoguen]

Originally Posted by met67

To keep you busy during your wait () , I've been playing with the plugin's code and managed to put together a version which doesn't nest KoboSpans.
Since I can't make a git patch (can't use git...), can I send you a normal diff (or the full container.py) file?
The diffs are relatively small...
My approach is to use a <DUMMY> tag as a container for the spans generated by a node's text and than remove it when appending it to the originating node.

EDIT: spoke too soon

What do you mean, "can't use Git"? Git is easy :P Relative to bzr anyway.

If you have access to a UNIX-ish system, the output of "diff -u" is fine. If you can do a GitHub pull request or a standard Git pull request, that would be best since then it records you as the author.

[met67]

Originally Posted by jgoguen

What do you mean, "can't use Git"? Git is easy :P Relative to bzr anyway.

Last time I tried, FW was blocking it....
AW I spoke too soon, I still have to nail down some details before it is ready...

[jgoguen]

You can (I'm pretty sure anyway) use Git over HTTPS if SSH is blocked. Unless you have an application firewall running a man-in-the-middle attack or outbound HTTPS is also blocked of course

[jgoguen]

Greetings appreciators of fine literature! There's a major change (for the better!) in the mainline KoboTouch driver coming with this next release of calibre. There will be a corresponding update to KoboTouchExtended. Late tonight (from my UTC-3 perspective) I'll be posting the update to match up with what davidfor has done. This will be KTE 2.1.0. If you get calibre 0.9.42 before KTE 2.1.0, it should be safe (but probably slower and definitely unsupported) to continue using KTE; if you get KTE 2.1.0 before calibre 0.9.42, KTE will not work and you are solely responsible for any gremlins that pop out of your computer.

So in short, when you start getting updates, for best (and supported) results wait until you have calibre 0.9.42 and KTE 2.1.0 before sending books to your device.

[met67]

Originally Posted by jgoguen

If you have access to a UNIX-ish system, the output of "diff -u" is fine. If you can do a GitHub pull request or a standard Git pull request, that would be best since then it records you as the author.

I think I nailed it, so I'll attach here the ouput of 'diff -u' (I still cant' use git...).

I dropped the <DUMMY> node hack and rewrote '__add_kobo_spans_to_node()' with a more conservative approach: I try to never delete empty spaces, instead I save and re-add it at the proper place.
I made a few tests and it works fine for me.

[jgoguen]

Can you re-run your diff with the arguments reversed? The way you did it has the diff removing your changes and adding my code

The general form is 'diff -u <old file> <new file>'

[met67]

Originally Posted by jgoguen

Can you re-run your diff with the arguments reversed? The way you did it has the diff removing your changes and adding my code

The general form is 'diff -u <old file> <new file>'

Here you go. In case I have included also the whole files...

EDIT:
BTW, in the mean time I have reloaded a library of circa 1 thousand books on my Aura using my code and it worked fine.

[buffaloseven]

What will the noticeable effect of correcting the span nesting problems?

[met67]

Originally Posted by buffaloseven

What will the noticeable effect of correcting the span nesting problems?

It makes the highlight function works.
In general this should produce kepubs that are very similar (if not equal) to those made by Kobo, which is the format that the renderer expects.

[buffaloseven]

Originally Posted by met67

It makes the highlight function works.
In general this should produce kepubs that are very similar (if not equal) to those made by Kobo, which is the format that the renderer expects.

Oh, wow; that's great! Now I'll just need to fix orphans and widows on my books.

[jgoguen]

davidfor may have something for you in this next calibre update...

[buffaloseven]

This is an exciting time to be a KG owner! I'm quite happy with FW 2.8.1, your extended driver rocks and looks like the few remaining bugs will be squished thanks to some community help, the widow/orphans issue could be easily fixed and there's hope for enabling advanced font configuration for side-loaded fonts. Pretty happy I stumbled on this community and calibre when I started hunting about e-readers.

[jgoguen]

Originally Posted by met67

Here you go. In case I have included also the whole files...

EDIT:
BTW, in the mean time I have reloaded a library of circa 1 thousand books on my Aura using my code and it worked fine.

This diff fails to apply. I took a quick look at your container.py and it looks like you've got mixed tabs and spaces for indentation (specifically, 72 tab characters over 29 lines), which Python won't accept and will throw an exception over, and your indentation is way off in some places (even if I convert each tab character to four spaces) as a result. Please re-do container.py, using four spaces as indentation (no tab characters anywhere), make sure indentation is correct, and re-verify just to make sure that nothing got messed up fixing the indentation.

What OS are you running and what editor are you using? There may be some settings changes that you can make to make Python coding easier. If you're using vim I could add the appropriate comment to the top of the file so vim correctly applies the important settings.