iLiad Modifying flipbar behavior

[DesiLinguist]

In a recent thread about the weirdness of the flipbar wherein it would randomly turn 5 pages when it should have only done a single page, Shaggy suggested that it might be useful to completely furn off that feature since the ipdf sources are now available.

I am very comfortable with linux and have done some embedded system development back in the day. So, I guess I wouldn't mind taking a shot at taking the fantastic jharker fullscreen ipdf (which is my default ipdf now) and modifying it to disable the 5 page turn completely.

However, I would still prefer if someone well-versed with developing for the iLiad took a shot at doing this before me primarily because the turn around time would be so much shorter. IMHO, this modification shouldn't be that difficult for someone who knows their way around the source already.

So, I would really really appreciate it if one of the more experienced iLiad developers could try their hand at this before I took a shot.

Thanks in advance!

Update:

I downloaded jharker's sources and explored a bit and found the changes that I think should be made according to my (so far very preliminary) understanding of the code.

The first set of changes should be in PDFPortraitView.cpp in the range between lines 318 and 361:

    case GDK_Page_Up:
        view->ctrl->settings.setRenderDir(RenderPrev);
        if (view->ctrl->settings.getCurrentPage() <= 1)
        {
            displayPage(1, ScrollToPrevPage);    
        }
        else
        {
            displayPage(view->ctrl->settings.getCurrentPage() - 1, ScrollToPrevPage);
        }   
        break;
    case GDK_Page_Down:
        view->ctrl->settings.setRenderDir(RenderNext);
        if (view->ctrl->settings.getCurrentPage() >= view->ctrl->core->getNumPages())
        {
            displayPage(view->ctrl->settings.getCurrentPage(), ScrollToNextPage);    
        }
        else
        {
            displayPage(view->ctrl->settings.getCurrentPage() + 1, ScrollToNextPage);
        }   
        break;
    case GDK_F1: // iRex: long pageflip forward 
        view->ctrl->settings.setRenderDir(RenderNext);
        if (view->ctrl->settings.getCurrentPage() + JumpWidth > view->ctrl->core->getNumPages())
        {
            displayPage(view->ctrl->core->getNumPages());
        }
        else
        {
            displayPage(view->ctrl->settings.getCurrentPage() + JumpWidth, ScrollToNextPages);
        }            
        break;
    case GDK_F2: // iRex: long pageflip backward 
        view->ctrl->settings.setRenderDir(RenderPrev);
        if ((view->ctrl->settings.getCurrentPage() - JumpWidth) < 1)
        {
            displayPage(1);
        }
        else
        {
            displayPage(view->ctrl->settings.getCurrentPage() - JumpWidth, ScrollToPrevPages);
        }            
        break;

If I am not mistaken, the first two CASE statements handle the regular flips and the next two CASE statements handle the long flips. So, all one should have to do is to ensure that the long flips do *exactly* the same thing as the short flips. And that should be all that is needed to remove the 5-page turn function.

Of course, the same changes need to be made in PDFLandscapeView.cpp as well but the changes should be pretty much identical.

To developers: If I am wrong about the changes that need to be made, please let me know. If I am right, I would really appreciate it if you could produce a version of this ipdf (jharker's) that incorporated these changes. Like I said, I could do it myself but it would take me a looong time to set up the toolchain and produce a final result whereas one of you veteran developers could probably do it in very little time. I would be happy to package up the new ipdf into daudi's all-in-one ipdf installer once this binary was produced.

Please help a fellow iLiad lover!

[Fellball]

Hello,

i modified the define in settings.h from
"#define JumpWidth 5 // long press"
in
"#define JumpWidth 1 // long press".

this works for me...

[DesiLinguist]

Oh that's even simpler! I didn't think of that. I checked and JumpWidth is not used anywhere else in the code and so this change shouldn't affect anything else.

Fellball, can you provide a binary that includes this change? I am hoping you made this change to jharker's fullscreen ipdf?

Thanks!

[Max]

Hello, another solution could be to set up a longer time for long press (you can configure for a minimun duration of 2 secons for a long press)

[Fellball]

i used the fullscreen-1.0a1-svn25 - Version.
i hope this binary is working for you.

[Ea]

Originally Posted by Max

Hello, another solution could be to set up a longer time for long press (you can configure for a minimun duration of 2 secons for a long press)

We discussed this earlier, and it seems that the flipbar may not be included in that min. duration setting. At least the way it's stated in the manual make it seem that it isn't and then that setting won't affect this.

[DesiLinguist]

Fellball, thank you so much! However, I have a question: it seems that the size of your ipdf binary is 1.1MB whereas the original fullscreen ipdf binary was only 81K. I think you forgot to strip your binary. Could you please do that and then repost?

Thanks again so much!

[Fellball]

Originally Posted by DesiLinguist

Fellball, thank you so much! However, I have a question: it seems that the size of your ipdf binary is 1.1MB whereas the original fullscreen ipdf binary was only 81K. I think you forgot to strip your binary. Could you please do that and then repost?

Thanks again so much!

Sorry, i changed the source and type 'make'.

I think the debugging-informations are included. i'm not a linux programmer and i don't know how to change it. but i will try it.

[DesiLinguist]

Fellball, did you set up the full toolchain as described in the forums? I mean, did you use the VMware image? If so, then I think you need to change the target from iliad-dev to iliad-irex or something and I think that should automatically produce an optimized binary.
I hope someone more knowledgeable will chime in here if I am wrong.

[DesiLinguist]

Fellball, I stripped the binary for you. Please look at this thread for the updated ipdf installers.

Thanks again for your help!

[Fellball]

Originally Posted by DesiLinguist

Fellball, I stripped the binary for you. Please look at this thread for the updated ipdf installers.

thx

[DesiLinguist]

BTW, Fellball, I am curious. How were you able to produce an unstripped binary? Were you using the VMWare image? I was not able to compile ipdf at all and so I would like to know what I need to set up the development environment properly.

[Fellball]

Originally Posted by DesiLinguist

BTW, Fellball, I am curious. How were you able to produce an unstripped binary? Were you using the VMWare image? I was not able to compile ipdf at all and so I would like to know what I need to set up the development environment properly.

I use this way: https://www.mobileread.com/forums/sho...d.php?t=19406&

[DesiLinguist]

Fellball,

Thank you so much! I had completely missed that thread. This is extremely useful

So, I guess the vmware image really is out of date and it's best to just do things with debian and the official sdk.

[Shaggy]

Originally Posted by Fellball

Hello,

i modified the define in settings.h from
"#define JumpWidth 5 // long press"
in
"#define JumpWidth 1 // long press".

this works for me...

Would it make sense to pull it out of the settings.h #define and instead put it into a config file? That way users can change whether they want the long press or not themselves, without having it hard coded.