Patch 4.38.23038 don't work on 4.38.23171

[hatuluang]

With the new release of Kobo firmware 4.38.23171 for older Kobo devices.
I found out two patches from 4.38.23038 don't work on 4.38.23171 as follows:

src/libnickel.so.1.0.0.yaml:
    Customize ComfortLight settings: yes
src/nickel.yaml:
    Increase size of kepub chapter progress chart: yes

I ran kobopatch.bat one by one for the two patches and both don't work.
It seems that the offsets were changing again
The other patches I used worked fine.
I use Clara 2E.

[Sirtel]

All of the patches I use worked.

My 24 line spacing values: yes
     Custom font sizes: yes
     ePub disable built-in body padding-bottom: yes
     Force user line spacing in KePubs: yes
     Force user line spacing in ePubs (part 1 of 2): yes
     Un-Force user font-family in KePubs: yes
     Custom navigation menu page number text: yes
     KePub stylesheet additions - word-spacing: yes
     Always show confirmation dialog before upgrading: yes
     Remove recommendations (row1col2) from home screen: yes
     Never show Kobo Plus, wishlist, and points SmartLinks: yes
     Remove title from reading header/footer: yes  
     Custom header/footer page number text: yes
     FeatureSettings - ExportHighlights: yes
     Unify font sizes: yes
     Force user line spacing in ePubs (Part 2 of 2): yes
     Custom synopsis details line spacing: yes
     Custom synopsis font size: yes
     Dictionary pop-up - increase available text area: yes
     Increase Book Details synopsis area: yes
     Reduce new header/footer height: yes
     Remove footer (row3) and increase cover size on new home screen: yes

[JSWolf]

As I don't use the Comfortlight, I don't use the patch. I did have the patch KePub chapter progress chart fail. But that's not a deal breaker.

[Semwize]

Originally Posted by hatuluang

I ran kobopatch.bat one by one for the two patches and both don't work.

Customize ComfortLight settings:
BaseAddress: 0xE8996C

Increase size of kepub chapter progress chart
BaseAddress: 0x19A150A

Originally Posted by jackie_w

Please note that the correct new offset for this patch in fw 4.38.23171 is
BaseAddress: 0x19948BA

Check...
Have you watched the rest of the patches?

[hatuluang]

Originally Posted by Semwize

Check...
Have you watched the rest of the patches?

I found one don't work in Nickel

  src/nickel.yaml:
    Remove forgot pin button from lock screen: yes

 --> could not apply patch "Remove forgot pin button from lock screen": line 655: inst 4: ReplaceZlib: not a zlib stream

[Semwize]

delete

[JSWolf]

The topic of this thread is incorrect! It needs to be changed.

It should read something like...

A small amount of patches from 4.38.23038 do not work on 4.38.23171.

[hatuluang]

Originally Posted by JSWolf

The topic of this thread is WRONG! It needs to be changed.

It should read something like...

A small amount of insignificant patches from 4.38.23038 do not work on 4.38.23171.

All of the important patches do apply as I've applied them to the new firmware. I've not yet installed the new firmware.

In this thread, I try to find/list the patches from firmware 4.38.23038 that don't work with the new firmware (4.38.23171).
What is not important to you, may be important to someone else.
Thanks to @Semwize and @jackie_w for giving the replacement offsets.

[hatuluang]

Originally Posted by Semwize

All? Are the other patches working?
And check, I don't use these patches.

The last patch found doesn't work

  src/libadobe.so.yaml:
    Remove PDF map widget shown during panning: yes

could not apply patch "Remove PDF map widget shown during panning": line 9: inst 4: ReplaceBytes: could not find specified bytes
        --> could not apply patch "Remove PDF map widget shown during panning": line 9: inst 4: ReplaceBytes: could not find specified bytes

The remaining patches are ok.

[JSWolf]

Thank you @Semwize for finding the correct location for the patches that are reported to not apply. with 4.38.23171.

[dd420]

Thanks Semwize for new base address for "Remove forgot pin button from lock screen" patch!
Here the list of patches applied to my device (all of them working).

    Show all games: yes
    Remove forgot pin button from lock screen: yes
    Remove footer (row3) on new home screen: yes
    Remove beta features not supported text: yes

[dd420]

I cannot edit my previous post ...
"Remove forgot pin button from lock screen" is not applied when installing to my device.

KoboRoot.tgz is correctly created but seems that the patch has no effetct.

[Semwize]

Originally Posted by dd420

patch has no effetct.

The offset is correct, I've double-checked it now.
But the path doesn't work, it probably needs to be rewritten.

[jackie_w]

Originally Posted by dd420

I cannot edit my previous post ...
"Remove forgot pin button from lock screen" is not applied when installing to my device.

KoboRoot.tgz is correctly created but seems that the patch has no effetct.

Originally Posted by Semwize

Remove forgot pin button from lock screen
BaseAddress: 0x19A24ED

Originally Posted by Semwize

The offset is correct, I've double-checked it now.
But the path doesn't work, it probably needs to be rewritten.

If BaseAddress: 0x19A24ED isn't working for patch Remove forgot pin button from lock screen, try this offset instead:
BaseAddress: 0x1999992

Nickel has 2 CSS resources, ParentalControlPinCodeVerifyView.qss & PinCodeInputDialog.qss, which contain identical CSS code. This patch is aimed at the latter. It's easy to confuse which offset is which.

[Semwize]

Originally Posted by jackie_w

If BaseAddress: 0x19A24ED isn't working for patch Remove forgot pin button from lock screen, try this offset instead:
BaseAddress: 0x1999992

Yes, I saw it. Even check it out, although it's wrong. Does not work.
It's not clear what it doesn't work, I don't see any reason.