[Differences between books] Running clock, although result exist

[chaot]

As it is mentioned in the Sticky PLEASE READ BEFORE POSTING that it ... is also not the place to reopen fundamental calibre design decisions ... I feel entitled to post here.

My concern relates to a rather minor design change.

Sometimes I get a little confused about versions, so I compared 2 identical versions of a book.

Result

Differences between books / No changes found (False clock icon)

The running clock icon led me to wait, although the at the same time (immediately) opened pop-up window notifies: No changes found.
That should be changed in thoughtful manner.

[eschwartz]

The "clock"/loading icon is from here: https://github.com/kovidgoyal/calibr...or/__init__.py

I can understand why you'd expect it to indicate a "finished" state as it does in the main GUI.



But this still isn't the right subforum.

The sticky clearly states that the Development subforum is ONLY for asking questions about how to use or modify the calibre source code.

As a special exception, if your question is about fundamental design decisions, you will be kicked out* of the Development forum no matter what -- this is because certain people kept trying to "fix the code" in ways Kovid specifically refused to accept.
This does not imply that minor design decisions are acceptable -- they are still only acceptable if the question involves YOU writing the code.


Your question is a bug report, about the editor, and as such belongs in the Editor subforum.





* -- post moved

[chaot]

Then I want at least make a suggestion.

Process starts

Differences between books_Calculating differences, please wait ...

Normal case

Differences between books (Results, with existing differences)

Rare case (not unnormal)

Differences between books / No changes found

I think that's certainly doable, right?

Now a further extension
It would be appropriate, if that Result window (Differences between books) would indicate the names of the compared books or whatever (e.g. in an upper bar).
Easy to get lost in there.

[eschwartz]

And your suggestion is reasonable.

(Thank you whoever re-filed this thread in the Editor subforum. Don't worry, we're used to it -- why do you think we have moderators? No one will think twice, as long as you don't make a habit of it.)



Let's wait until Kovid has a chance to respond, shall we?
Perhaps the Differences window could be closed (leaving the "No changes found" popup in place) in the event that there are no differences.