Allow / inside fragment identifier

iliakan · 02-11-2015, 09:03 AM

From http://tools.ietf.org/html/rfc3986:

Quote:

The characters slash ("/") and question mark ("?") are allowed to
represent data within the fragment identifier.

Ebook conversion filters fragment identifiers in a too harsh way: https://github.com/kovidgoyal/calibr...t.py#L350-L359

Code:

 frag_pat = re.compile(r'[-A-Za-z0-9_:.]+$')

I'd suggest to add / and maybe ? to the list, because the standard explicitly allows that.

The issue breaks conversion for certains HTMLs.

kovidgoyal · 02-11-2015, 09:12 AM

That section is there to workaround limitations in Adobe Digital Editions, which tends to fall over and die with fragment identifiers that contain characters other than those in the regex, as is noted in the comment.

Not to mention that the cleanup is performed for fragment identifiers in the NCX ToC, for which the HTML spec is irrelevant.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Fragment Identifier missing, but looks OK	flypig	ePub	8	12-19-2018 07:58 PM
IMG inside SVG inside TD?	Kasper Hviid	Sigil	4	05-25-2014 07:57 AM
Fragment Identifier Not Defined	lwa	Sigil	6	07-10-2013 06:00 PM
Fragment identifier styline on Nook	marciarampart	ePub	3	11-21-2011 03:53 PM
Verifying Document/Fragment Identifier	Schlutek	ePub	6	09-09-2011 02:22 PM

02-11-2015, 09:12 AM	#2
kovidgoyal creator of calibre Posts: 45,609 Karma: 28549044 Join Date: Oct 2006 Location: Mumbai, India Device: Various	That section is there to workaround limitations in Adobe Digital Editions, which tends to fall over and die with fragment identifiers that contain characters other than those in the regex, as is noted in the comment. Not to mention that the cleanup is performed for fragment identifiers in the NCX ToC, for which the HTML spec is irrelevant.

Advert