Sigil 2.7.5 Release Candidate (RC) Now Available

[retiredbiker]

Originally Posted by DiapDealer

That's odd. I checked RC2 with the testplugin plugin and it passed all tests with flying colors. Are you sure the "Use Bundled Python" box is checked in Sigil's plugin preferences section? That can easily get disabled if you ever run a non-appimage version of Sigil.

EDIT: correct me if I'm wrong, but you were running an earlier 2.7.5 beta AppImage successfully (including several plugins), right? https://www.mobileread.com/forums/sh...6&postcount=15

Nothing should have really changed in any major way for the AppImage (especially with regards to running plugins).

Ah, it was the "use bundled Python" flag. Never had it go off before...I'll just stick with the appimage versions now, and get rid of my compiled version.
Everything is working well now as far as I can tell. I'm nearly ready to create a new book, that will test it more thoroughly with much more editing.
Yes, I've been running the earlier 2.7.5 appimage for a couple of weeks or so with no problems.

[DiapDealer]

Thanks for getting back to us. This is exactly the kind of thing we were trying to account for with these release candidates. Better to find them now, than an hour after an official release!

[KevinH]

@DiapDealer,
And as BeckyEbook pointed out the src/Dialogs/ClipboardHistorySelector was made non-modal and so it has that extra min window hint recently added too. When you revert those other two, you may want to revert it as well, just to check.

Those were the only 3 that were recently added. The About box was never touched. The fact that it added a minimze button too under Windows is very strange. So you might want to comment out my attempt to forcibly remove that hint if present first just to check as it should not have been impacted by the changes made for the other 3 were. The MainWindow should automatically gets the min and max enabled.

Is that min button appearing someplace besides the About Box that it was not meant too?

[DiapDealer]

Originally Posted by KevinH

Is that min buttons appearing someplace besides the About Box that it was not meant too?

The min and max button are appearing on every single dialog that Sigil has on Windows. It's not just the About box that got it. Preferences, Metadata Editor, Edit ToC, Manage Checkpoints, Manage Automations, Plugin Runner, ... you name it. Every dialog (modal or non-) that Sigil can display suddenly has a working min, max, close button-box. That's not how it ever was before. I installed the official 2.7.0 to be sure.

[DNSB]

I just compiled the latest from the Sigil Github with the comment about attempting to remove the min/max buttons from the About box. It and every other dialog I opened had min/max/exit buttons.

[BeckyEbook]

Today, I made over 30 Sigil builds with the About dialog test. I think this code works:

    setWindowFlags(windowFlags() | Qt::CustomizeWindowHint);
    setWindowFlag(Qt::WindowMinimizeButtonHint, false);
    setWindowFlag(Qt::WindowMaximizeButtonHint, false);
    setWindowFlag(Qt::MSWindowsFixedSizeDialogHint, true);

I would bet on Qt 6.10.x, which started inheriting more system flags in Windows, and if they are not overwritten, the system adds active Min/Max.

[KevinH]

But what does the Qt::MSWindowsFixedSizeDialogHint, true do? All Sigil dialogs should be resizable. Can you still resize the About Box after your change? If we use that flag on the other dialogs will it force them to be non-resizeable?

[KevinH]

Originally Posted by DNSB

I just compiled the latest from the Sigil Github with the comment about attempting to remove the min/max buttons from the About box. It and every other dialog I opened had min/max/exit buttons.

Aaargh! Not good. What a strange thing for Qt to change in platform specific code in a point release change from 6.9.3 to 6.10.2.

Perhaps they just introduced a bug?

[DiapDealer]

It was my suspicion that the Qt::CustomizeWindowHint flag needed to be added everywhere the default was being overridden. I'm not ready to blame Qt6.10.x yet. The first of these custom window flags were added only 3 weeks ago. I suspect the same thing would have happened had we used them in conjunction with Qt6.9.3. I probably never would have noticed new min/max buttons on dialogs unless someone had said something.

I still don't think we need to blunt-force the About box (and every other modal dialog that now has min/max buttons). I think we just need to properly add the Qt::CustomizeWindowHint flag to all three of the original places we added the new code. Every place I've looked said that flag needs to used when customizing the buttons you want to appear on dialogs. And we currently are not using it.

[KevinH]

Here is an official Qt bug about it. It was caused by a broken change in Qt not anything we did.

QTBUG-143832
https://qt-project.atlassian.net/iss...e=QTBUG-143832

According to that bug, it was introduced in a change from Qt 6.10.1 to Qt 6.10.2 here:

https://codereview.qt-project.org/c/...dowswindow.cpp

[DNSB]

I just tried @BeckyEbook's code and it left the About box with just the exit button! I then tried it in a couple of other spots and it seems to remove the min/max buttons.

[KevinH]

And here is the official Qt patch to the qtbase 6.10 branch to fix this that will be used in the future Qt 6.10.3:

https://github.com/qt/qtbase/commit/...23e6f1c26fb1f7

@DiapDealer,

How hard would it be to cherry pick this commit just for the windows Qtbase build. It only impacts the windows platform plugin so that is the only part that would need to be rebuilt.

This might be the easiest solution if it is doable, as it would require no code changes in Sigil.

[KevinH]

Originally Posted by DNSB

I just tried @BeckyEbook's code and it left the About box with just the exit button! I then tried it in a couple of other spots and it seems to remove the min/max buttons.

Thanks, but can you still manually resize those dialogs?

[odamizu]

Originally Posted by KevinH

@odamizu

Okay, I think I have this fixed in master ...

... So we should be back to normal for external editing.

Thank you for your bug report!

[DNSB]

Originally Posted by KevinH

Thanks, but can you still manually resize those dialogs?

No, the Reports and SpellCheck windows do not resize. Not sure if About ever did but current version is fixed size.

Edit: Removed the setWindowFlag(Qt::MSWindowsFixedSizeDialogHint, true); line and all three boxes are resizable. The minimize button is still visible but does nothing. The maximize box maximizes and exit exits.

However, I suspect that regenerating Qt 6.10.2 with the patch would be the best way to go.