Sigil-2.4.0 Released

[DiapDealer]

Avast needs to turn the heuristics knob down a bit from 11

I've mentioned it many times, but I'll say it once more: There is no need to install/use a third-party memory resident malware scanner on Windows. Defender will suffice. It's not perfect, but at least it doesn't have the agenda that many of third-party programs do: mainly justifying their existence by finding things to justify their existence by finding things to justify their existence.

[DNSB]

Originally Posted by ndenyal

I have Avast and it deleted the installer file (well, "quarantined" it).

In that case, I would suggest removing Avast. It does have a certain reputation for false positives.

[Vanguard3000]

Hey, things are as usual working really well, generally. I haven noticed one thing about the dry-run replace menu that's a bit irritating. if the found string spans multiple lines, the row won't grow to fit the content. A common use-case for me is joining split paragraphs when fixing up OCR'd books, and this makes it a bit tough to do.

On another note, I've noticed with this version as well as the previous one, that the find/replace pane will automatically hide itself from time to time, even sometimes when I'm in the middle of using it. It didn't do this previously; is there a setting that prevents that I don't know about?

In any case, thanks again for an awesome tool!

[KevinH]

I will look to see if there is any way to replace all line ends with a placeholder symbol just inside that table element or maybe resize them somehow but I think QTableWidgets have fixed height rows (need to read the Qt docs on that).

As for Find Replace going away, I do not see that at all on my machines. That said there are now shortcut key sequences that can be used to open and close most of the QDockWidgets and Find and Replace windows ... could you be typing key sequences that cause a window to hide? If so, you can use Sigil's ShortCut Manager Preferences to change them.

[Vanguard3000]

Originally Posted by KevinH

I will look to see if there is any way to replace all line ends with a placeholder symbol just inside that table element or maybe resize them somehow but I think QTableWidgets have fixed height rows (need to read the Qt docs on that).

It used to allow a few lines with the old setup. It'd be nice at at least get three lines, so I could potentially see the two paragraphs and the line of whitespace in between, but chalk that up to a wishlist item for me. Aside from that, everything is functionally good; the new "uncheck to ignore" system will take a bit of getting used to for me, but I think it's an improvement overall.

Originally Posted by KevinH

As for Find Replace going away, I do not see that at all on my machines. That said there are now shortcut key sequences that can be used to open and close most of the QDockWidgets and Find and Replace windows ... could you be typing key sequences that cause a window to hide? If so, you can use Sigil's ShortCut Manager Preferences to change them.

I looked through the shortcuts in Preferences and didn't see any specific options for closing widgets. Unless ShortCut Manager is a plugin?

I'm still trying to peg down exactly what's causing the search pane to hide, but one thing that's reproduceable and may be related is if I go to close the window, prompting a "document has been modified/Do you want to save" dialog, then cancel, the pane will be hidden.

[DNSB]

Originally Posted by KevinH

As for Find Replace going away, I do not see that at all on my machines. That said there are now shortcut key sequences that can be used to open and close most of the QDockWidgets and Find and Replace windows ... could you be typing key sequences that cause a window to hide? If so, you can use Sigil's ShortCut Manager Preferences to change them.

I've seen that occasionally where I switch to Images to check an image size and when I switch back to a file Styles or Text, the Find/replace window has closed. It happened erratically and not often enough for me to feel confident that I've not accidentally closed it—I've fat fingered enough times to feel confident that I'm capable of doing that.

Looking at the keyboard shortcut list, it seems that ctrl-F opens the Search/replace window but there are no keystrokes defined to close it.

[KevinH]

Originally Posted by Vanguard3000

It used to allow a few lines with the old setup. It'd be nice at at least get three lines, so I could potentially see the two paragraphs and the line of whitespace in between, but chalk that up to a wishlist item for me. Aside from that, everything is functionally good; the new "uncheck to ignore" system will take a bit of getting used to for me, but I think it's an improvement overall.

The old version used a QTreeView instead of the current QTableView. I may have to revert to the QTreeView to get that capability back. I will take a look.

[JSWolf]

Originally Posted by ndenyal

I have Avast and it deleted the installer file (well, "quarantined" it).

Time to dump Avast. It's not really all that good anyway. No loss.

[KevinH]

Originally Posted by Vanguard3000

It used to allow a few lines with the old setup. It'd be nice at at least get three lines, so I could potentially see the two paragraphs and the line of whitespace in between, but chalk that up to a wishlist item for me. Aside from that, everything is functionally good; the new "uncheck to ignore" system will take a bit of getting used to for me, but I think it's an improvement overall.

It turned out to be a simple one line fix:

diff --git a/src/Dialogs/ReplacementChooser.cpp b/src/Dialogs/ReplacementChooser.cpp
index 555a33b95..9644a78b4 100644
--- a/src/Dialogs/ReplacementChooser.cpp
+++ b/src/Dialogs/ReplacementChooser.cpp
@@ -1,6 +1,6 @@
 /************************************************************************
 **
-**  Copyright (C) 2022-2024 Kevin B. Hendricks, Stratford, Ontario
+**  Copyright (C) 2022-2025 Kevin B. Hendricks, Stratford, Ontario
 **
 **  This file is part of Sigil.
 **
@@ -230,6 +230,7 @@ void ReplacementChooser::CreateTable()
     for (int i = 0; i < ui.chooserTable->horizontalHeader()->count(); i++) {
         ui.chooserTable->resizeColumnToContents(i);
     }
+    ui.chooserTable->resizeRowsToContents();
     ui.chooserTable->setSelectionBehavior(QAbstractItemView::SelectRows);
 }

This fix has been pushed to master and will appear in our next release.

[KevinH]

Originally Posted by Vanguard3000

I'm still trying to peg down exactly what's causing the search pane to hide, but one thing that's reproduceable and may be related is if I go to close the window, prompting a "document has been modified/Do you want to save" dialog, then cancel, the pane will be hidden.

Yes, but that is by design. There is a restore Sigil windows from settings bug that can only be worked around by saving whether F&R is open first in settings, then closing F&R before saving all the window geometries in Sigil settings (which happens in the closeEvent on a MainWindow when it calls WriteSettings()).

Upon launch, the state of F&R is read from settings, then if it was previously visible - after restoring all window geometries, F&R is re-opened. Without this workaround the restoring of geometries can be randomly mess up.

So that is the one expected case. If you see F&R randomly going away when not trying to close and exit out of Sigil, please let me know how as I have never seen it.

[KevinH]

Originally Posted by DNSB

I've seen that occasionally where I switch to Images to check an image size and when I switch back to a file Styles or Text, the Find/replace window has closed. It happened erratically and not often enough for me to feel confident that I've not accidentally closed it—I've fat fingered enough times to feel confident that I'm capable of doing that.

Looking at the keyboard shortcut list, it seems that ctrl-F opens the Search/replace window but there are no keystrokes defined to close it.

I have just tried the following 25 times with F&R open in Sigil:

1. Double-Click in BookBrowser on an random xhtml file
2. Double-Click in BookBrowser on an random image file
3. Double-click in BookBrowser on the random xhtml file

In all cases F&R was there when editing the xhtml file.

Then I repeated this experiment using the Tab Bar to more quickly go back and forth between previously opened images tabs and text tabs.

Again in all cases F&R was there when editing any xhtml file.

So I am simply not able to recreate what you are seeing. But this is with MacOS.

If you can reproduce this, please provide detailed steps as how to recreate it.

Sorry, if I can not recreate it I have no chance to track this one down.

[Turtle91]

Originally Posted by DNSB

I've seen that occasionally where I switch to Images to check an image size and when I switch back to a file Styles or Text, the Find/replace window has closed. It happened erratically and not often enough for me to feel confident that I've not accidentally closed it—I've fat fingered enough times to feel confident that I'm capable of doing that.

Looking at the keyboard shortcut list, it seems that ctrl-F opens the Search/replace window but there are no keystrokes defined to close it.

I too, see it occasionally, but it hasn't been too big of a deal to turn it on again...and too much hassle to track down exactly when it happens

BUT...I took this as a challenge. On the latest Windows 11, Sigil 2.4.0, If you try to close the app without saving changes made using ANY method (red x, ctrl-Q, or File/Quit), the message window pops up confirming the close... You can also see in the background that the F/R window is automatically closed when the message window pops up.

- If you hit Cancel on the message window then the F/R window remains closed.
- If you hit Discard on the message window then Sigil closes but the F/R window is still gone when you re-open Sigil.
- If you hit Save, then the ePub is saved, but the F/R window is still gone.

Soooo... I don't think it has anything to do with how Sigil is exited...it's just something in the Message window that is closing the F/R window.

Cheers!

[KevinH]

Originally Posted by Turtle91

I too, see it occasionally, but it hasn't been too big of a deal to turn it on again...and too much hassle to track down exactly when it happens

BUT...I took this as a challenge. On the latest Windows 11, Sigil 2.4.0, If you try to close the app without saving changes made using ANY method (red x, ctrl-Q, or File/Quit), the message window pops up confirming the close... You can also see in the background that the F/R window is automatically closed when the message window pops up.

- If you hit Cancel on the message window then the F/R window remains closed.
- If you hit Discard on the message window then Sigil closes but the F/R window is still gone when you re-open Sigil.
- If you hit Save, then the ePub is saved, but the F/R window is still gone.

Soooo... I don't think it has anything to do with how Sigil is exited...it's just something in the Message window that is closing the F/R window.

Cheers!

That is expected behaviour. See my earlier response that explains what WriteSettings is doing and why.

https://www.mobileread.com/forums/sh...4&postcount=40

The issue I am trying to recreate is when simple switching is done causing F&R to randomly close when NOT associated with trying to close or exit Sigil.

[KevinH]

And for what it is worth, I added code to master to MainWindow::closeEvent that remembers if you had F&R open when trying to exit Sigil and if you cancel the exit to then reopen F&R that the WriteSettings closed.

So even that expected exiting behaviour will no longer happen in the next release.

So if anyone can reproduce the seemingly random closures of F&R reported above while doing something **other than** trying to exit Sigil, a set of detailed instructions to recreate the bug would be welcome!

[BetterRed]

Originally Posted by DNSB

I've seen that occasionally where I switch to Images to check an image size and when I switch back to a file Styles or Text, the Find/replace window has closed. It happened erratically and not often enough for me to feel confident that I've not accidentally closed it—I've fat fingered enough times to feel confident that I'm capable of doing that.

Looking at the keyboard shortcut list, it seems that ctrl-F opens the Search/replace window but there are no keystrokes defined to close it.

Because there's no keyboard sequence to close the F&R panel (I know this because I've looked for one occasionally) you'd have to be cack-handed to close it with an accidental left mouse button click on the Hide Find and Replace ('X') button… which can't be reached via the Tab key either… that IS NOT a suggestion it should be.

The calibre book editor's F&R panel is the same, it can only be closed (hidden) by left clicking a similarly placed button. But there is a difference that may be germane:

The calibre editor allows the user to close all codeview tabs, when the editor is in that state the F&R panel is hidden, it get's reinstated when any file is opened. Sigil doesn't allow the user to close all codeview tabs… again not saying it should.

Originally Posted by Turtle91

. . .

BUT...I took this as a challenge. On the latest Windows 11, Sigil 2.4.0, If you try to close the app without saving changes made using ANY method (red x, ctrl-Q, or File/Quit),

. . .

You omitted Alt+F4 and Alt+Space,C, but I'd be surprised if exiting by those methods would behave differently, but….

BR