Sigil-2.4.0 Released

[DNSB]

If it is the same popup as I linked an image of in message #7, you would click on More info to get the install enabled.

[theducks]

Originally Posted by DNSB

If it is the same popup as I linked an image of in message #7, you would click on More info to get the install enabled.

Yes, but mine was RED. That may have been because I grabbed it very soon after the release post

[DiapDealer]

I get the warning on some machines and not on others. But I've made so many administrative changes and registry hacks to various machines (virtual or otherwise) that I have no idea why that might be at this point.

[BetterRed]

Originally Posted by KevinH

. . .

I am always amazed on the hoops people jump through on Windows by adding third party virus checkers that employ such shit algorithms. Simple fear mongering to try to show these paid for third party checkers are "valuable" when in fact they themselves are effectively useless.

It's a legacy from MS-DOS - some might remember F-Prot, Dr Solomon's, MacAfee started out as a DOS AV and maybe Norton's too.

Back then you needed them because programs were installed on multiple PCs from diskettes. My first encounter with a virus came via a PC Support techie installing an infected 3270 emulator on my PC. Immediately after installing it on my machine she installed it on the COO's… oops.

We traced it back to one of her PC Support colleagues… he and his supervisor were shown the door.

[philja]

Got 1.4.0 installed on W10 and MacBook ok.

Built from source on Linux (UBStudio 24.04.1), OK but during the 'sudo make install' part, the slow and steady flow of progress lines in the terminal was suddenly interrupted by a rapid flow of messages indicating that there was some deprecated stuff.

It all concerns the source file SpellCheck.cpp and Hunspell. The listing is here :

igil.dir/Misc/SettingsStore.cpp.o
[ 79%] Building CXX object src/CMakeFiles/sigil.dir/Misc/SpellCheck.cpp.o
/home/pnj/Downloads/Sigil-2.4.0-download/sigil-src/src/Misc/SpellCheck.cpp: In member function ‘bool SpellCheck::spell(const QString&)’:
/home/pnj/Downloads/Sigil-2.4.0-download/sigil-src/src/Misc/SpellCheck.cpp:212:34: warning: ‘int Hunspell::spell(const char*, int*, char**)’ is deprecated [-Wdeprecated-declarations]
  212 |     bool res = hdic.handle->spell(ba.constData()) != 0;
      |                ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
In file included from /home/pnj/Downloads/Sigil-2.4.0-download/sigil-src/src/Misc/SpellCheck.cpp:23:
/usr/include/hunspell/hunspell.hxx:132:20: note: declared here
  132 |   H_DEPRECATED int spell(const char* word, int* info = NULL, char** root = NULL);
      |                    ^~~~~
/home/pnj/Downloads/Sigil-2.4.0-download/sigil-src/src/Misc/SpellCheck.cpp: In member function ‘bool SpellCheck::spellPS(const QString&)’:
/home/pnj/Downloads/Sigil-2.4.0-download/sigil-src/src/Misc/SpellCheck.cpp:227:39: warning: ‘int Hunspell::spell(const char*, int*, char**)’ is deprecated [-Wdeprecated-declarations]
  227 |     bool res = m_primary.handle->spell(pba.constData()) !=0;
      |                ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
/usr/include/hunspell/hunspell.hxx:132:20: note: declared here
  132 |   H_DEPRECATED int spell(const char* word, int* info = NULL, char** root = NULL);
      |                    ^~~~~
/home/pnj/Downloads/Sigil-2.4.0-download/sigil-src/src/Misc/SpellCheck.cpp:231:37: warning: ‘int Hunspell::spell(const char*, int*, char**)’ is deprecated [-Wdeprecated-declarations]
  231 |     return m_secondary.handle->spell(sba.constData()) != 0;
      |            ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
/usr/include/hunspell/hunspell.hxx:132:20: note: declared here
  132 |   H_DEPRECATED int spell(const char* word, int* info = NULL, char** root = NULL);
      |                    ^~~~~
/home/pnj/Downloads/Sigil-2.4.0-download/sigil-src/src/Misc/SpellCheck.cpp: In member function ‘QStringList SpellCheck::suggest(const QString&)’:
/home/pnj/Downloads/Sigil-2.4.0-download/sigil-src/src/Misc/SpellCheck.cpp:248:37: warning: ‘int Hunspell::suggest(char***, const char*)’ is deprecated [-Wdeprecated-declarations]
  248 |     int count = hdic.handle->suggest(&suggestedWords, wba.constData());
      |                 ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/hunspell/hunspell.hxx:142:20: note: declared here
  142 |   H_DEPRECATED int suggest(char*** slst, const char* word);
      |                    ^~~~~~~
/home/pnj/Downloads/Sigil-2.4.0-download/sigil-src/src/Misc/SpellCheck.cpp:256:27: warning: ‘void Hunspell::free_list(char***, int)’ is deprecated [-Wdeprecated-declarations]
  256 |     hdic.handle->free_list(&suggestedWords, count);
      |     ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/hunspell/hunspell.hxx:156:21: note: declared here
  156 |   H_DEPRECATED void free_list(char*** slst, int n);
      |                     ^~~~~~~~~
/home/pnj/Downloads/Sigil-2.4.0-download/sigil-src/src/Misc/SpellCheck.cpp: In member function ‘QStringList SpellCheck::suggestPS(const QString&)’:
/home/pnj/Downloads/Sigil-2.4.0-download/sigil-src/src/Misc/SpellCheck.cpp:270:42: warning: ‘int Hunspell::suggest(char***, const char*)’ is deprecated [-Wdeprecated-declarations]
  270 |     int count = m_primary.handle->suggest(&suggestedWords, pba.constData());
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/hunspell/hunspell.hxx:142:20: note: declared here
  142 |   H_DEPRECATED int suggest(char*** slst, const char* word);
      |                    ^~~~~~~
/home/pnj/Downloads/Sigil-2.4.0-download/sigil-src/src/Misc/SpellCheck.cpp:280:40: warning: ‘int Hunspell::suggest(char***, const char*)’ is deprecated [-Wdeprecated-declarations]
  280 |     count = m_secondary.handle->suggest(&suggestedWords2, sba.constData());
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/hunspell/hunspell.hxx:142:20: note: declared here
  142 |   H_DEPRECATED int suggest(char*** slst, const char* word);
      |                    ^~~~~~~
/home/pnj/Downloads/Sigil-2.4.0-download/sigil-src/src/Misc/SpellCheck.cpp:288:34: warning: ‘void Hunspell::free_list(char***, int)’ is deprecated [-Wdeprecated-declarations]
  288 |     m_secondary.handle->free_list(&suggestedWords2, count);
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/hunspell/hunspell.hxx:156:21: note: declared here
  156 |   H_DEPRECATED void free_list(char*** slst, int n);
      |                     ^~~~~~~~~

It doesn't affect Sigil's normal workings but might interest Kevin and DiapDealer. Could it be due to outdated stuff in my distro?

[DiapDealer]

Originally Posted by philja

Could it be due to outdated stuff in my distro?

Nah. More likely outdated stuff in Sigil's hunspell code. It's probably because your system's gcc compiler was updated and is now flashing more warnings. We've not updated any hunspell code in Sigil 2.4.0.

I've always gotten a lot of hunspell warnings when building on Linux with more recent versions of gcc. We'll take a look to be sure though. Thanks.

NOTE: you can also use your distro's own hunspell (instead of Sigil's bundled version) by installing your distro's hunspell development package (libhunspell-dev on Ubuntu) and telling cmake to use it instead by adding -DUSE_SYSTEM_LIBS=1 to your original sigil cmake configure command. That might reduce some of the deprecation warnings.

[KevinH]

I have actually turned off those deprecations (they have been there for years and years) in our Sigil version of hunspell as the code they deprecated would break the entire C interface to hunspell and are required for python code to use hunspell and so should never go away.

Whoever deprecated that interface, clearly was not thinking clearly.

If that C interface ever does get actually removed, we will simply move to our own version of hunspell.

You must be building with system hunspell on Linux as both Windows and Mac use our own supplied hunspell.

You can safely ignore those deprecations.

[DiapDealer]

Originally Posted by KevinH

I have actually turned off those deprecations (they have been there for years and years) in our Sigil version of hunspell as the code they deprecated would break the entire C interface to hunspell and are required for python code to use hunspell and so should never go away.

Whomever deprecated that interface, clearly was not thinking clearly.

If that C interface ever does get actually removed, we will simply move to our own version of hunspell.

You must be building with system hunspell on Linux as both Windows and Mac use our own supplied hunspell.

You can safely ignore those deprecations.

Ohhh.... I never considered that the deprecation warnings were BECAUSE the system hunspell was being used. That makes sense. I use the bundled hunspell on Arch linux and see warnings, but no deprecations warnings.

[philja]

Originally Posted by KevinH

I have actually turned off those deprecations (they have been there for years and years) in our Sigil version of hunspell as the code they deprecated would break the entire C interface to hunspell and are required for python code to use hunspell and so should never go away.

Whoever deprecated that interface, clearly was not thinking clearly.

If that C interface ever does get actually removed, we will simply move to our own version of hunspell.

You must be building with system hunspell on Linux as both Windows and Mac use our own supplied hunspell.

You can safely ignore those deprecations.

I did use the system hunspell on my linux build - that's why I wondered if I had out of date stuff. But your explanation puts that straight. I'll make a note for next time to use the bundled version.

[DiapDealer]

Originally Posted by philja

I did use the system hunspell on my linux build - that's why I wondered if I had out of date stuff. But your explanation puts that straight. I'll make a note for next time to use the bundled version.

There's likely very little difference. The deprecation warnings are just turned off in the bundled version. The repo maintainers have been using the system version (with deprecation warnings) for a long, long time.

[DiapDealer]

This release of Sigil is now available to Windows users via winget.

For reasons that drive me absolutely bonkers: Sigil will only be available for installation from winget as a system wide (machine scope) installation from now on. Getting a user scope installation of software that has a system wide dependency (VCRedist) validated on winget-pkgs is unfortunately broken. Has been for a while. I'd hoped they would fix it, but I've given up trying to get them to tackle fixing it.

[KevinH]

The maintainers of hunspell already broke things back in 2016 when they released hunspell 1.5 and the had to backtrack and release 1.5.1

Here is the pertinent issue:
https://github.com/Sigil-Ebook/Sigil/issues/261

And for the record, here is my change disabling those idiotic deprecations that has been used since 2016:

https://github.com/Sigil-Ebook/Sigil...nspell.hxx#L92

until line 102.

I created that interface for MySpell which later became hunspell when I retired from that project. It was designed to mimic the interface of its predecessor ispell so it has existed for over 30 years now. So silly to deprecate a C interface to a C++ library for no good reason.

And hunspell 1.7.2 is still the latest official release of hunspell, so aside from disabling the deprecation warnings there should be no difference in a Linux system hunspell and ours, unless they have tweaked their version somehow.

[nabsltd]

Originally Posted by KevinH

Why on earth does Windows virus checkers decide to label something as "potential malware" based only on download and trust counts!? That is incredibly stupid as it will hit every new release or update without fail.

I used software downloaded from a US government site (.gov domain) that likely has less than 1000 downloads per month, since the software is very specialized, runs as a server, and requires a unique ID given to you by the government to install, so you can only have one copy running for your entire organization.

Every single update was blocked on download by Microsoft reputation filters.

[DiapDealer]

What drives me nuts is that as an individual, I can't even buy a code-signing certificate that would eliminate 100% of the warnings that Microsoft scares its users with. And an organizational cert is out of the question without formally creating a full-blown org with a dba, mailing address, and all the checks that go with it. So I'm not doing any of it. This a hobby for me. Trust me or don't.

Or use one of the Windows software repositories that Microsoft lends more credibility to:

winget install -e --id Sigil-Ebook.Sigil

[ndenyal]

Originally Posted by DNSB

Personally, I would suggest replacing your antivirus. You are getting upset over a false positive.

4 of the 69 scanners reported an issue. Those 4 were Avast, AVG, Bkav Pro and Skyhigh (SWG).
.

I have Avast and it deleted the installer file (well, "quarantined" it).