PageEdit-0.9.5 Released - Page 2

un_pogaz · 09-06-2019, 08:00 AM

The crash occurs when changing a new document with the navigation buttons (when you are in ereader mode after "opening" the OPF) and not when Sigil closes (it keeps the file in memory and is editable normally, but fails to save it).
PageEdit does not check the existing files when using the navigation buttons and therefore tried to load a non-existent one.

EDIT:

Quote:

Originally Posted by KevinH

I will try to add more file exists checks but deleting any resource as it is being actively loaded is going to still be an issue.

I understand that verifying (other than at the time of saving) the existence of the currently loaded document is unnecessarily complex and exaggerated (and useless since it cannot be saved).

PS: One click before the crash:

KevinH · 09-06-2019, 09:13 AM

Does it crash trying to save the modified state or when navigating to the next file?
In other words, if you do not modify anything, is simple navigation to the next file enough to cause the crash?

If so, we can handle that case in UpdatePage.

KevinH · 09-06-2019, 10:10 AM

Here is what I added to UpdatePage() which gets invoked when you press on a navigation icon or use the navigation menu itself. Please note, this is only a partial fix:

Code:

    try {
        text = Utility::ReadUnicodeTextFile(filename_url);
    } catch (std::exception &e) {
        Utility::DisplayStdErrorDialog(tr("File load failed"), e.what());
        text = "<html><head><title></title></head><body><h1>" + tr("File Load Failed") + "</h1></body></html>";
        file_path = "";
        m_CurrentFilePath = "";
    }

because between the time we check that the xhtml file still exists and then attempt to load QtWebEngine with the page, any of the separate file resources (external images, styles, fonts, etc) could be deleted causing a load deep inside Qt webengine to possibly hang or worse crash.

Even if I parsed the entire xhtml file to find and build links to every external resource, and checked if they still exist, since file loading is not an atomic operations, the actual timing of the delete will always be an issue.

un_pogaz · 09-09-2019, 03:50 AM

Yes, it is the navigation (UpdatePage) that causes the crash, so: Thanks.

Personal opinion, if the files disappear during the 20ms between UpdatePage() and the actual loading into QtWebEngine: either you did it voluntarily, or your computer is really crappy.

brent63 · 10-02-2019, 10:57 AM

A Help icon with the PageEdit version Number.

Right now I have to go to explorer and look at the zip file I downloaded and saved in the PageEdit folder.

A notification when a newer version is released.

I only found out that my PageEdit was a couple version outdated when I received a notification the Sigil had an update.

Can a printer feature be added to Pageedit, something that can format the pages to two columns per page and both front and back of sheet?

Thanks
Brent

KevinH · 10-02-2019, 11:28 AM

Quote:

Originally Posted by brent63

A Help icon with the PageEdit version Number.
Right now I have to go to explorer and look at the zip file I downloaded and saved in the PageEdit folder.

Already exists in the new PageEdit About box that was added to PageEdit 0.9.5

Quote:

A notification when a newer version is released.

Not easy as that feature in Sigil uses the embedded python interpreter which PageEdit does not have. So this one will probably not happen. That said, I do not expect new features to be added at the rate they are to Sigil so
expect a much longer life for each release after PageEdit goes 1.0.

Quote:

I only found out that my PageEdit was a couple version outdated when I received a notification the Sigil had an update.

We will probably be releasing them at the same time until both hit 1.0.

Quote:

Can a printer feature be added to Pageedit, something that can format the pages to two columns per page and both front and back of sheet?

That is not on PageEdit's radar at all. There are javascripts that can format to two columns and even allot pages but they are not planned for PageEdit anymore as Calibre has (or will soon release) an improved ebook reader that should support page layout, printing and multiple columns. PageEdit is for proofing and simple edits.

BetterRed · 10-02-2019, 05:53 PM

@brent63 - if you create an account at GitHub, you can Watch the Release page - I think it's email notifications.

@KevinH, DiapDealer - suggestion: put an RSS link on Sigil and Page Edit Release Pages for those who don't have or want to create an account at GitHub or don't like email notifications.

Calibre's new viewer does not have a print function, I think its on hold awaiting Kovid's replacement of the pdf library he currently uses, which is deficient, and/or buggy, and/or orphaned.

BR

DiapDealer · 10-02-2019, 07:19 PM

Quote:

Originally Posted by BetterRed

@KevinH, DiapDealer - suggestion: put an RSS link on Sigil and Page Edit Release Pages for those who don't have or want to create an account at GitHub or don't like email notifications.

Surely the people who know how to make use of an RSS feed (and are still inclined to do so) can easily search for the url to use for any github project's releases feed?

https://github.com/Sigil-Ebook/Sigil/releases.atom

Tex2002ans · 10-03-2019, 03:09 PM

Quote:

Originally Posted by DiapDealer

Surely the people who know how to make use of an RSS feed (and are still inclined to do so) can easily search for the url to use for any github project's releases feed?

I had no idea this was a thing. How did you find this link?

A search for "RSS" or "atom" on this page finds nothing?

https://github.com/Sigil-Ebook/Sigil/

Side Note: I'm still so pissed when Firefox removed built-in RSS support "due to 0.01% usage" (Firefox 64, December 2018)... but even years before that, they were completely crippling easy RSS access. If a page had a feed, there used to be a simple RSS button that showed up in the URL bar... then they buried it in some non-intuitive menu, and then finally killed it off.

My readership to many sites has gone wayyyy down since then.

PS. Does anyone know of any good RSS readers (Windows and/or Android)? I tried to test a few last year, but haven't been satisfied with them.

DiapDealer · 10-03-2019, 04:12 PM

Quote:

Originally Posted by Tex2002ans

A search for "RSS" or "atom" on this page finds nothing?

https://github.com/Sigil-Ebook/Sigil/

Of course there's nothing. Because it's got nothing to do with Sigil. We don't make, or control the feed, Github does it automatically--for all public repos.

github.com/[org|user]/[repo]/releases.atom

will get you the RSS releases feed for any public github project that makes releases.

https://github.com/Sigil-Ebook/PageEdit/releases.atom

https://github.com/dougmassay/tagmec.../releases.atom

http://github.com/kevinhendricks/kin.../releases.atom

https://github.com/retext-project/retext/releases.atom

https://github.com/microsoft/vscode/releases.atom

Doitsu · 10-03-2019, 04:49 PM

Quote:

Originally Posted by Tex2002ans

PS. Does anyone know of any good RSS readers (Windows and/or Android)? I tried to test a few last year, but haven't been satisfied with them.

Have you tried the Firefox Livemarks add-on?

Tex2002ans · 10-03-2019, 05:04 PM

Quote:

Originally Posted by DiapDealer

Of course there's nothing. Because it's got nothing to do with Sigil. We don't make, or control the feed, Github does it automatically--for all public repos.

Indeed, Github generates them... but where on the page could you find this info (button, etc.)? Or do you just have to intuitively know to append /releases.atom at the end?

As an example, many sites had the little RSS logo somewhere on the page.

Quote:

Originally Posted by Doitsu

Have you tried the Firefox Livemarks add-on?

Thanks. I'll take a look. Looks like that might be just what I needed.

When Mozilla announced it, they did have this help page:

Feed reader replacements for Firefox

which linked over to "a curated list of add-ons" here (aaaaaaaand it now leads to 0 hits):

https://addons.mozilla.org/en-US/fir.../feed-readers/

I spent quite a bit of time testing their recommendations and trying to find a replacement... but I gave up a few months in and haven't looked back since (and been very grumpy about it!).

BetterRed · 10-03-2019, 05:43 PM

Quote:

Originally Posted by Tex2002ans

Side Note: I'm still so pissed when Firefox removed built-in RSS support "due to less than 1% usage" (Firefox 64, December 2018)... but even years before that, they were completely crippling easy RSS access. If a page had a feed, there used to be a simple RSS button that showed up in the URL bar... then they buried it in some non-intuitive menu, and then finally killed it off.

My readership to many sites has gone wayyyy down since then.

PS. Does anyone know of any good RSS readers (Windows and/or Android)? I tried to test a few last year, but haven't been satisfied with them.

Side Note: ...

My reader ...

PS: Does anyo ....

Going forward in reverse. You'll read all sorts of rationale for the demise of RSS, like no one used it and security waffle, I suspect 'they' are killing it off because it's not easily monetised

BR

BetterRed · 10-03-2019, 05:51 PM

Quote:

Originally Posted by Tex2002ans

Indeed, Github generates them... but where on the page could you find this info (button, etc.)? Or do you just have to intuitively know to append /releases.atom at the end?

As an example, many sites had the little RSS logo somewhere on the page.

Thanks. I'll take a look. Looks like that might be just what I needed.

When Mozilla announced it, they did have this help page:

Feed reader replacements for Firefox

which linked over to "a curated list of add-ons" here (aaaaaaaand it now leads to 0 hits):

https://addons.mozilla.org/en-US/fir.../feed-readers/

I spent quite a bit of time testing their recommendations and trying to find a replacement... but I gave up a few months in and haven't looked back since (and been very grumpy about it!).

to all that too, we must live in a parallel universe :lol:

I did find something re RSS and Github, on stackoverflow I think, but it was written in scriptych technobabble.

BR

Tex2002ans · 10-03-2019, 06:24 PM

Anyway, this is going way far off-topic... so this'll be my last post on RSS.

Quote:

Originally Posted by BetterRed

to all that too, we must live in a parallel universe :lol:

So far, within the hour of using the Livemarks add-on, it seems VERY close to the old Live Bookmarks.

I substituted back all my RSS feeds... and now I can skim every single article title with a simple mouse hover down the list of sites! (Glorious, glorious, you don't know how productive you've made me again, Doitsu!)

The problem I'm now seeing is that the add-on works by "hacking" the Bookmarks functionality by bookmarking the latest articles from the RSS feeds ~ every few minutes.

This means any time I begin typing in the URL bar, it displays:

Latest "bookmarked" article titles
- All these RSS feed articles are now "my favorites"... so they take much higher priority over many of the other search results.
Open Tabs
Usual browser history
- Very lowest priority, easily driven off the bottom of the list of 10 URLs.

Let's say I'm trying to dig through my history to find some technical topic I read months ago... the entire thing is potentially buried by the RSS results.

Quote:

Originally Posted by BetterRed

I suspect 'they' are killing it off because it's not easily monetised

Perhaps. At least podcasts seem to still completely rely on it, and podcasts and doing better than ever.

Now websites are pushing all this "Push Notifications" garbage (which I have since disabled):

https://support.mozilla.org/en-US/kb...ations-firefox

(And again, to disable it, it's this completely buried and non-intuitive checkbox.)

Quote:

Originally Posted by BetterRed

I did find something re RSS and Github, on stackoverflow I think, but it was written in scriptych technobabble.

I usually first look for the little RSS logo (or search "RSS" on a page), then I (used to) look for the little logo in the URL bar.

When they got rid of the little button, Firefox buried it under Menu > Library > Bookmarks > Subscribe Live Bookmarks (or something as preposterous as that)... but by then, I pretty much had 99% of the sites I consistently visit in the RSS feeds, so I never bothered to add many feeds after that.

Github, I don't follow many projects on there, but the ones I do, I'm usually checking the sites consistently anyway (Sigil, LanguageTool, NetGuard, AdAway, etc.)... but now knowing there's Atom will save me lots of time. Now it'll just be a few simple mouse movements to see if there were any updates posted.

09-06-2019, 10:10 AM	#18
KevinH Sigil Developer Posts: 8,779 Karma: 6000000 Join Date: Nov 2009 Device: many	Here is what I added to UpdatePage() which gets invoked when you press on a navigation icon or use the navigation menu itself. Please note, this is only a partial fix: Code: try { text = Utility::ReadUnicodeTextFile(filename_url); } catch (std::exception &e) { Utility::DisplayStdErrorDialog(tr("File load failed"), e.what()); text = "<html><head><title></title></head><body><h1>" + tr("File Load Failed") + "</h1></body></html>"; file_path = ""; m_CurrentFilePath = ""; } because between the time we check that the xhtml file still exists and then attempt to load QtWebEngine with the page, any of the separate file resources (external images, styles, fonts, etc) could be deleted causing a load deep inside Qt webengine to possibly hang or worse crash. Even if I parsed the entire xhtml file to find and build links to every external resource, and checked if they still exist, since file loading is not an atomic operations, the actual timing of the delete will always be an issue.

10-02-2019, 10:57 AM	#20
brent63 Zealot Posts: 110 Karma: 10 Join Date: Aug 2018 Location: New Jersey Device: Samsung Tab E nook	A couple of feature for PageEdit A Help icon with the PageEdit version Number. Right now I have to go to explorer and look at the zip file I downloaded and saved in the PageEdit folder. A notification when a newer version is released. I only found out that my PageEdit was a couple version outdated when I received a notification the Sigil had an update. Can a printer feature be added to Pageedit, something that can format the pages to two columns per page and both front and back of sheet? Thanks Brent

10-02-2019, 05:53 PM	#22
BetterRed null operator (he/him) Posts: 21,740 Karma: 30237526 Join Date: Mar 2012 Location: Sydney Australia Device: none	@brent63 - if you create an account at GitHub, you can Watch the Release page - I think it's email notifications. @KevinH, DiapDealer - suggestion: put an RSS link on Sigil and Page Edit Release Pages for those who don't have or want to create an account at GitHub or don't like email notifications. Calibre's new viewer does not have a print function, I think its on hold awaiting Kovid's replacement of the pdf library he currently uses, which is deficient, and/or buggy, and/or orphaned. BR Last edited by BetterRed; 10-02-2019 at 06:27 PM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
pageedit in Sigil	C-novice	Sigil	10	11-27-2019 10:02 AM
PageEdit-0.8.0 Released	DiapDealer	Sigil	37	08-25-2019 04:14 PM
PageEdit-0.7.1 Released	DiapDealer	Sigil	37	08-09-2019 02:23 AM
Why PageEdit is separated software?	un_pogaz	Sigil	1	06-26-2019 09:55 AM
KINDLE DEAL: Released: A Story of God’s Power Released in Pro Baseball ($	gospelebooks	Deals and Resources (No Self-Promotion or Affiliate Links)	0	07-14-2011 09:12 PM

09-06-2019, 09:13 AM	#17
KevinH Sigil Developer Posts: 8,779 Karma: 6000000 Join Date: Nov 2009 Device: many	Does it crash trying to save the modified state or when navigating to the next file? In other words, if you do not modify anything, is simple navigation to the next file enough to cause the crash? If so, we can handle that case in UpdatePage.

09-09-2019, 03:50 AM	#19
un_pogaz Chalut o/ Posts: 439 Karma: 145424 Join Date: Dec 2017 Device: Kobo	Yes, it is the navigation (UpdatePage) that causes the crash, so: Thanks. Personal opinion, if the files disappear during the 20ms between UpdatePage() and the actual loading into QtWebEngine: either you did it voluntarily, or your computer is really crappy.

Advert

Advert