Plugin devs: Upcoming migration to Qt 6

[chaley]

Originally Posted by kovidgoyal

that commit assumes images are in the plugin root which. I suppose adding support for an extra images sub-folder shouldnt be too bad.

This is more-or-less required, because plugins put the default icons in an images subdirectory in the zip file.

And FWIW: if I remove 'images' as in

icon = get_icons('icon.png', 'Interface Plugin Demo')

it works if the overridden icons exist. As a consequence of the above, it doesn't work if there aren't any overridden icons.

[kovidgoyal]

https://github.com/kovidgoyal/calibr...ff68e1444a769b

[chaley]

Originally Posted by kovidgoyal

https://github.com/kovidgoyal/calibr...ff68e1444a769b

Works fine now. I tested without any overrides, using a plain override in an images subfolder(icon.png), and a theme-based icon (icon-for-light-theme.png).

[Nicolas F]

Thanks everyone

Just to be sure, in the past I always put the icons in 'resources\images\PluginName'.

Should I put the icons in 'resources\images\PluginName\images' or in 'resources\images\PluginName'?

[kovidgoyal]

Originally Posted by Nicolas F

Should I put the icons in 'resources\images\PluginName\images' or in 'resources\images\PluginName'?

Depends on what the plugin uses. The interface demo plugin uses an images sub-folder.

[Nicolas F]

Originally Posted by kovidgoyal

Depends on what the plugin uses. The interface demo plugin uses an images sub-folder.

Ok thank you

[thiago.eec]

Originally Posted by kovidgoyal

https://github.com/kovidgoyal/calibr...ff68e1444a769b

Great!

Now that @chaley mentioned, I remember the reason I decided not to use get_icons() directly: the 'images' sub-folder.

Two questions:

1) My plugin zip file contains two sets of icons, so it works for both themes out of the box. Would it be possible for calibre to look for the variants inside the zip file too?
2) Sometimes, I use calibre general icons (like 'marked.png'). The problem is get_icons() do not look for those. Would it be possible to include general icons?

[kovidgoyal]

If you are using a calibre icon just use it directly, there is no reason to call get_icons(). Why would you want to do that?

[JimmXinu]

Thanks, Kovid. New version works for me.

FYI, my plugins' get_icon() looks first for eg 'icon.png' then automatically 'images/icon.png' to cover both cases.

And I use it for calibre icons all the time without issue.

[thiago.eec]

Originally Posted by JimmXinu

Thanks, Kovid. New version works for me.

FYI, my plugins' get_icon() looks first for eg 'icon.png' then automatically 'images/icon.png' to cover both cases.

And I use it for calibre icons all the time without issue.

Sure, my version works too. I'm tlaking about calibre get_icons(). It doesn't get calibre icons.

[thiago.eec]

Originally Posted by kovidgoyal

If you are using a calibre icon just use it directly, there is no reason to call get_icons(). Why would you want to do that?

Sorry. How can I use directly?

[chaley]

Originally Posted by thiago.eec

Sure, my version works too. I'm tlaking about calibre get_icons(). It doesn't get calibre icons.

If you know the icon is a calibre icon then use cal_icon = QIcon.ic('icon.png')

[thiago.eec]

Originally Posted by chaley

If you know the icon is a calibre icon then use cal_icon = QIcon.ic('icon.png')

Of course. Thanks!