Sigil-0.9.991 (1.0 Pre-release)

[KevinH]

No Sigil in 2011 simply ignored the incorrect mimetype and forced everything based on the file extension. This approach does not work for generic .xml files and some other files that can represent a number of possibly different media-types.

Sigil now, just like in web browsers treats the media type as important and that does determine how a file is displayed or processed.

I will change Sigil's code to look up the media-type from the manifest item and if that is not recognized, then (assuming the extension is not ".xml") look up the media-type via the file extension.

I will also hard code the bookpath to match the epub zip even if a file's type and mediatype are not recognized.

Thanks for testing.

KevinH

[KevinH]

Originally Posted by snarkophilus

Not sure what to suggest for a fix. Sigil used to be able to edit this, at least in 2011 .

Here's the relevent entries for the fonts in Three Men In A Boat:

    <item id="fontinbold_font" href="fonts/Fontin-Bold.ttf" media-type="application/x-truetype-font"/>
    <item id="fontinitalic_font" href="fonts/Fontin-Italic.ttf" media-type="application/x-truetype-font"/>
        <item id="fontinregular_font" href="fonts/Fontin-Regular.ttf" media-type="application/x-truetype-font"/>

Yes x-truetype-font is not the correct mediatype either. There are many acceptable mediatypes for truetype fonts but that is not one of them (x-font-ttf, x-font-ttc, font/ttf, etc.) Multiple valid entries exist for otf fonts as well.

They are recognizable so I can add them as even more equivalents to the long list we already recognize.

[snarkophilus]

Originally Posted by KevinH

They are recognizable so I can add them as even more equivalents to the long list we already recognize.

I've no idea how you implement this growing list, but is there ever a case where it would be useful for a user to be able to configure something to add to the list so that they could deal with a funny mime type without having to report a bug and wait for an update/release?

[KevinH]

Wouldn't it just be easier to edit the OPF and replace the broken mediatype?

FWIW, There is actually a core limited set of mediatypes that epub3 may use (see the epub3 spec) without supplying an alternative file. We already cover those covered by the spec.

[snarkophilus]

Originally Posted by KevinH

Wouldn't it just be easier to edit the OPF and replace the broken mediatype?

Hah, I obviously didn't think that through (or well and truly over-thought it!). Yes, just changing the media type seems much easier.

[KevinH]

Okay, I just now pushed a fix to master to try to harden Sigilaginst unrecognized mediatypes.

I can not use the Three Men in a Boat to test it as I have added those font mimetypes so that they are now recognized.

So after the appveyor build completes, would you please grab it and test it with your 2011 epub and let me know if I have succeeded or still have more work to do.

Thanks,

KevinH

I am a bit worried about your page-template file as it does use a recognized mediatype just not the proper mediatype for that file so we may still have issues with that one.

[snarkophilus]

Originally Posted by KevinH

Okay, I just now pushed a fix to master to try to harden Sigilaginst unrecognized mediatypes.

I can not use the Three Men in a Boat to test it as I have added those font mimetypes so that they are now recognized.

So after the appveyor build completes, would you please grab it and test it with your 2011 epub and let me know if I have succeeded or still have more work to do.

Thanks,

KevinH

I am a bit worried about your page-template file as it does use a recognized mediatype just not the proper mediatype for that file so we may still have issues with that one.

I tested with both -29 and a -30 that showed up a little later. Both Three Men In A Boat (as expected as you said) and my other epub open now and work properly. The other epub still says

Debug: Warning: unrecognized mediatype in OPF:  "txt/css"

but there are no warnings about the page-template file.

To be honest, I've no idea what that page-template file actually does. I tinkered with a few margins mentioned in that file and nothing seemed to change in the Sigil preview window. Don't care what it does, happy I can open the epub now .

Thanks very much for your work on this and the other tab closing issue!

[snarkophilus]

Originally Posted by snarkophilus

but there are no warnings about the page-template file.

Well ... if I rename another file within that epub, then I get the attached message. Sigil keeps working, other that the pop-up everything else works. I expect that's related to updating/changing the contents.opf?

[snarkophilus]

There's a problem with changing the target of a TOC entry in the TOC editor.

• Choose: Tools -> Table of Contents -> Edit table of contents ...
• Pick any entry in the TOC
• Click "Select Target"
• segfault

The segfaults every time I've tried it in a number of epubs, including my sample 50 little image epub, a Calibre news recipe and "normal" books.

Maybe I should change my profile blurb to "I break things"?

[Doitsu]

Originally Posted by snarkophilus

There's a problem with changing the target of a TOC entry in the TOC editor.

I was able to re-create this bug on my Windows 10 machine with standard and non-standard epubs.

[DiapDealer]

Originally Posted by snarkophilus

Maybe I should change my profile blurb to "I break things"?

Better to find them in the alpha and beta releases, than in the official 1.0 release. Feel free to keep on "breaking" things in 0.9.991.

Does it happen with both EPUB2 and EPUB3?

[snarkophilus]

Originally Posted by DiapDealer

Better to find them in the alpha and beta releases, than in the official 1.0 release. Feel free to keep on "breaking" things in 0.9.991.

I'll keep editing and report things that break. Maybe if I can't find a problem on any given day I'll try harder to do random stuff.

Does it happen with both EPUB2 and EPUB3?

I think I may have an epub3 or two or three if I looked hard enough, but I've only tried with epub2.

[Doitsu]

Originally Posted by DiapDealer

Does it happen with both EPUB2 and EPUB3?

It happens with standard and non-standard EPUB2 and EPUB3 books.

[DiapDealer]

Any sign of the selection dialog trying to appear after clicking Select Target, or is the segfault immediate?

[snarkophilus]

Originally Posted by DiapDealer

Any sign of the selection dialog trying to appear after clicking Select Target, or is the segfault immediate?

No sign of the selection dialog. For me, I get the dreaded little Windows spinny circle of death for maybe 5 seconds, then the segfault message.