Incorrect proxy detection on Windows [0.6.19]

[mikeage]

Hi,

I'm running Calibre 0.6.19 on Windows, and I have a problem with the proxy detection.

Calibre thinks that I have a proxy defined:

C:\Program Files\Calibre - E-book Management>calibre-debug -c "from calibre import get_proxies; print get_proxies()"
Unable to detect proxy settings: need more than 1 value to unpack
Using proxies: {'http': 'proxy:8080', 'https': 'proxy:8080'}
{'http': 'proxy:8080', 'https': 'proxy:8080'}

This is technically true, except that I have proxies disabled [these are the proxies I use when enabling a proxy server].

To be precise, Calibre is reading from HKEY_CURRENT_USER\Software\Microsoft\Windows\Curre ntVersion\Internet Settings\ProxyServer [or perhaps HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\Curr entVersion\Internet Settings], but is ignoring HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\Curr entVersion\Internet Settings\ProxyEnable.

For some reason, the proxy server is defined in both HKCU and HKLM, but ProxyEnable only exists in HKLM.

Note that with 0.6.18, I didn't have this problem (since it read from the environment variable http_proxy), but it did have a problem parsing the format I gave (http://proxy:8080/). I think that for Windows, following the IE proxy settings is probably more correct, even though personally I prefer environment variables.

[kovidgoyal]

As far as I know, proxy settings should be read from HKCU not HKLM, see for example

http://blogs.technet.com/heyscriptin...xy-server.aspx

[mikeage]

could be, but my experience suggests that when toggling the proxy on/off, only HKLM is affected. In fact, I just tried this with a new windows install [well, not new, but one never configured to use a proxy] and saw the same thing

[kovidgoyal]

What software are you using to toggle the proxy?

[mikeage]

Originally I was using something in-house from my company, but I also tried using the Windows "Internet Options" dialog

[kovidgoyal]

OK open a ticket for it and I'll investigate when I have some time.