[GUI Plugin] Modify ePub

[JSWolf]

What are your settings for Modify ePub? I've found that an error can happen when certain settings are used. I didn't have an error. Also, can you scramble your ePub and see if the rror still happens and if so, post it?

[ottischwenk]

Which settings?

[JSWolf]

Originally Posted by ottischwenk

Which settings?

The settings shown on the settings window right before you run Modify ePub.

[ottischwenk]

Originally Posted by JSWolf

The settings shown on the settings window right before you run Modify ePub.

With modify_epub-1.8.11.zip it works correct - not with with modify_epub-1.8.13.zip.

[DNSB]

I just tested on 4 ePubs and with the settings in the attached image, the font files were removed. The @font-face links to the fonts in the CSS stylesheet were removed however other font-family references in the CSS were not removed. I've attached images of the start of the stylesheet before/after modify ePub and the settings I am using in Modify ePub.

The cover html after a Sigil Mend/Prettify is:

<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE html>

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">
<head>
  <meta name="calibre:cover" content="true"/>
  <title>Death Comes Calling</title>
  <style type="text/css" title="override_css">
            @page {padding: 0pt; margin:0pt}
            body { text-align: center; padding:0pt; margin: 0pt; }
        </style>
</head>

<body>
  <div>
    <svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="100%" height="100%" viewBox="0 0 1000 1500" preserveAspectRatio="xMidYMid meet"><title>Death Come Calling</title>

<image width="1000" height="1500" xlink:href="../Images/cover.jpeg"/></svg>
  </div>
</body>
</html>

[JSWolf]

There is a problem with removing fonts.

calibre, version 9.18.0
ERROR: Modify ePub changed no files: No ePub files were updated. If this isn't what you expected then press the Show details button to check for errors in the log.

Modify ePubs version (1, 8, 13)
Logfile for book ID 3814 (Star Trek: Echoes in Eternity / David Mack)
Job details 3814

  Modifying:  C:\Users\jswol\AppData\Local\Temp\calibre-h5wqv1ca\kld52cp7_modify_epub\3814.epub

	  Parsing xml file: 9781668233696.opf
	  Parsing xml file: toc.ncx
	Remove cover

Star Trek: Echoes in Eternity - ERROR: Traceback (most recent call last):
  File "calibre_plugins.modify_epub.modify", line 74, in process_book
  File "calibre_plugins.modify_epub.modify", line 160, in _process_book
  File "calibre_plugins.modify_epub.modify", line 866, in _remove_cover

TypeError: CoverUpdater.__init__() missing 1 required positional argument: 'opts'

ePub not changed after 0.09 seconds

The problem is when Remove existing cover is checked, removing fonts does not work. I tried this with just the two options set and it failed as seen above.