New Features or Improvements post Sigil 2.8.1

[BetterRed]

Suggestion:



If that could be done, I would rarely need to use Get Info.

[KevinH]

Originally Posted by BetterRed

Suggestion:

Attachment 224971

If that could be done, I would rarely need to use Get Info.

You do realize that the actual size of the image on disk will change with any resize and trim (crop operation), colour depth changes, image file compression level chosen, etc. And of course none of that can be known until you actually save that image to disk (removing the chance of undo).
So what you ask for makes no sense in an image editor as it can not be dynamically updated until the file itself is actually written to.

How does only knowing the initial file size when editing actually help?

GetInfo is lightning fast and is a single right click away.
It provides all the same image info, and file size.

And right click and selecting View Image is just as fast and shows the current File size (since it does not do editing) and image width, height, bpp info as well.

Pick your poison, so to speak.

[BetterRed]

Originally Posted by KevinH

You do realize that the actual size of the image on disk will change with any resize and trim (crop operation), colour depth changes, image file compression level chosen, etc. And of course none of that can be known until you actually save that image to disk (removing the chance of undo).
So what you ask for makes no sense in an image editor as it can not be dynamically updated until the file itself is actually written to.

How does only knowing the initial file size when editing actually help?

GetInfo is lightning fast and is a single right click away.
It provides all the same image info, and file size.

And right click and selecting View Image is just as fast and shows the current File size (since it does not do editing) and image width, height, bpp info as well.

Pick your poison, so to speak.

Easy to say of you can use a mouse proficiently, but for those of us who can't, in my case due to disability, being able to see the size of an image file at a glance would be preferable to:

• give focus to Book browser (Ctrl+Shift+B)
• use arrow keys to navigate to image
• press menu key or Shift+F10
• use arrow keys to navigate to Get info
• dismiss Get info
• give focus back to Code view (Ctrl+Shift+C)

I don't use Sigil's image editing feature (nor calibre's), I prefer to use an external image editor (not always the same one) via Book browser Open with… i.e. poisons with which I am familiar :-)

BR

[KevinH]

So how does that change to open an Image editing Tab. You still have to navigate to BookBrowser, You still have to mouse down to the image you want. So the only difference is hitting the shortcut or double click to open a tab versus doing a View Image that has the info you want (including file size).

What if you could set a shortcut to View Image. If that would help I could register it for a BookBrowser keyboard shortcut like GetInfo already had. That would be a trivial change.

Either way you still have to accept the dialogs to exit them (or I guess you could just leave the Image Tab open) and still have to move keyboard focus back to CodeView.

So I do not see any significant improvement for those who only use the keyboard. What am I missing?

Why open an Image Tab if you do not want to edit it when View Image shows the Image, with dimensions, and bpp and provides File size on disk and can be launched as needed in place of the Image Tab.

And if it would help I can register a BookBrowser keyboard shortcut for View Image. Just let me know.

[BetterRed]

My suggestion to display the size of an image file alongside its dimensions etc was prompted by post #72 from @3333 and @Turtle91's reply.

When I'm interested in the size of an image file, usually because I think it might be unnecessarily large, I pop the Reports window and have a look at the sizes of all the image files. Because it's not modal I can leave the Reports window open.

I cannot recall ever using View image,

BR

[KevinH]

I still need to hear people's opinions and justifications for 3333's proposed feature (that he has already coded up so no work for me!) to allow any hover over an image in BookBrowser to show a thumbnail image complete with file size and dimensions.

If people want this feature, they really need to speak up, as it duplicates our pop-up menu item View Image but is easier to trigger.

So far I have 3 votes for (3333, philja, Turtle91) and only 1 against. Still need to hear more voices to come to any conclusion here.

[icallaci]

Originally Posted by KevinH

I still need to hear people's opinions and justifications for 3333's proposed feature (that he has already coded up so no work for me!) to allow any hover over an image in BookBrowser to show a thumbnail image complete with file size and dimensions.

If people want this feature, they really need to speak up, as it duplicates our pop-up menu item View Image but is easier to trigger.

So far I have 3 votes for (3333, philja, Turtle91) and only 1 against. Still need to hear more voices to come to any conclusion here.

Count me in as another vote FOR this feature. Thanks.

[KevinH]

Originally Posted by icallaci

Count me in as another vote FOR this feature. Thanks.

Please add the reason you like it. I am trying to understand how this is useful in everyday work for most users over a popup menu View Image we already have.

[DiapDealer]

I just don't feel its going to be something that a lot of Sigil users will utilize. That, and the fact that it comes with a potentially huge memory footprint mean it's a no for me.

My mouse moves/drifts around my screen all the time. I wiggle it to make sure I know where it is. Accidentally triggering huge pop-ups would tend to annoy me.

[KevinH]

I have similar thoughts but to be fair, a limit on cache size can be set. So its memory foot print should be controllable.

You can check out his code implementation here:

https://github.com/rinne1998/Sigil/c...75743429e7ac88

Sigil ImageResources already know how to describe themselves so we could simplify that code a bit.

Also we could change the BookView header to use its own BookTreeView pointer to remove the need to static cast anything.

We could also remove the use of auto in places since the actual classes/types are all known and actual typing is always preferred.

An alternative is that all ImageResources could build their own thumbnails on the fly if we wanted that but his cache approach should be faster and take up less memory than each resource building its own QImage thumbnail image on the fly and then remembering them.

Anyway, some things to consider.

[DiapDealer]

Fair enough. We'll see what the masses think. I may have to incorporate a back door to turn it off if it gets approved (no new prefs settings that aren't absolutely necessary). In the time I park my mouse over an image file and right-click it to rename it, I'd hate to have a pop-up preview of the image steal the focus.

What would be the "right" default delay setting before the preview opens? I can't imagine one size would fit all here. And that probably means preferences.

I'll try to build it locally and see what I think.

[philja]

Originally Posted by KevinH

I still need to hear people's opinions and justifications for 3333's proposed feature (that he has already coded up so no work for me!) to allow any hover over an image in BookBrowser to show a thumbnail image complete with file size and dimensions.

If people want this feature, they really need to speak up, as it duplicates our pop-up menu item View Image but is easier to trigger.

So far I have 3 votes for (3333, philja, Turtle91) and only 1 against. Still need to hear more voices to come to any conclusion here.

My vote 'for' was conditional on not having adverse coding consequences. From your comments, Kevin, I don't think it would be worthwhile.

Anyway, it's not something I would need very often and there are other ways of checking on an image which are not onerous.

[KevinH]

So noted. Thanks for the explanation, I will update the vote count.

[retiredbiker]

Personally, this is not something I would find useful. The view image is fine as is. Any serious image manipulation I do elsewhere anyway, and I agree with others that having images pop up with accidental mouse positioning would be a distraction.

[Turtle91]

Soooo......

I was under the, mistaken, impression that "View Image" was the same thing as opening the image with a double click.
I almost never use the right-click menu - it's much faster for me to just double-click than to right-click then find the selection then left-click. Since the file size is not listed on the image edit view, I just thought it was only available in reports or Get Info... all of which (including View Image) required extra work to get.... I know, first-world-problems...

Getting an image thumbnail, dimensions, and file size on a hover just seemed easy. I'm lucky enough to not be concerned about memory usage - memory is cheap. I also grew up in the time where every bit of memory was precious when programming so I get it, but it just doesn't matter to me much anymore. Although I can definitely see where having the ability to turn off that feature in preferences would help those that ARE concerned about the memory usage. Maybe add thumbnail size selector as well as display delay at the same time. Or, for that matter, can you have the option for zero image size and only display the dimensions and file size on hover??

Having that kind of feature is pure convenience, but a nice one.