Selective binarization and re-encoding program for use with KoReader

[embryo]

The app themes are great!!
Great improvement.
Really appreciate it..🙏

Originally Posted by LegeApps

The adaptive binarization default value change was really the big fix. I use fixed threshold a lot because I know the good values to pick (180 for dark color pages, 128 for light color pages) but I dont expect users to know that, and adaptive binarization is a more complex process that has its place.

For the Fixed Threshold and also for the Custom Adaptive values, you're right. The user can't know what is what (Custom adaptive doesn't even have a max/min value at the tooltip)..
So, the solution I propose is a drop-down menu (or some buttons if the GUI lib does not provide one), with 3-4 presets like "Cleaner text - Balanced - Cleaner background, or whatever the outcome is likely to be.
You know better than us what the values do, so you can name them in a helpful for the user way..

Not sure what you mean. either you saw it using it in the CLI or it doesnt. The GPU is doing all it can do, I can guarantee that at this point. You should look at the code or ask a model to explain whats happening.

rendering=cpu via pdfium
resize=gpu where it helps
inference=gpu
binarization=gpu
encoding=cpu

This has all been nearly completely optimized.

I use GPU-Z to monitor the GPU's processing, memory, power draw, etc., but you can see it if you look at the Windows task manager (Performance>Cuda).
95% of the processing is for Preparing Pipeline / Initializing.
At this stage only 1 CPU thread is working (I have 8 cores - 16 threads). No GPU work at all.
After that its the Render | Infer | Encode stage that takes almost no time at all.
At this stage I see some spikes of GPU processing (only for some ms) and then it ends.
This is what I mean by "overall the processing was done at the CPU".
A great improvement would be if this was utilizing all the available threads, but maybe the library doesn't support this.

That's not how the adaptive option works, it's a completely different binarizatio method than fixed threshold; it uses a fusion of Otsu and Sauvola which are two well known page binarization techniques. The "heavy model" is also Sauvola, but more intensive. I do not think implementing what you suggest would be coherent in code. What is the effect you are seeing in outputs that makes you want a feature like that?

As I said, I had to use the Fixed threshold because of the false letters that the adaptive was detecting.
I do thing that an adaptive mode would work better in a book with text and images of different brightness, since it will treat every page differently, but it might need some fine tuning like the book I mentioned.
If there is no such option, let's forget it..

I did it in 1.4.61, I added dark modes based on color palettes I always wanted to add, from a Sanzo Wada color book. check them out in the new release. I think you'll like it.

No nitpicking is what im here for, keep it up, as long as it's coherent nitpicking that I can act on. Thank you for your nitpicking.

OK then, more problems.

- Cropping is not working again.
It crops wherever it likes.
Turning the Layout detection Off, improves things sometimes, but not always.
I do recall that you said that you're gone set Free Aspect as default.
Well, I don't thing it is.
Even in the cases that cropping is almost working, all pages have almost the same size, even the ones that don't need to (a lot of blank space leftover)

- This is the taskbar icon of the app

and this is the app's window icon at dark themed Windows

It is almost impossible to be seen.
What I usually do for that, is to add a 1-pixel white (or light gray) runaround that is invisible at a light background, but shows the image if the background is dark..

[LegeApps]

https://github.com/LegeApp/Lege/rele...Lege-win64.zip

Originally Posted by embryo

The app themes are great!!
Great improvement.
Really appreciate it..��

Great..

For the Fixed Threshold and also for the Custom Adaptive values, you're right. The user can't know what is what (Custom adaptive doesn't even have a max/min value at the tooltip)..
So, the solution I propose is a drop-down menu (or some buttons if the GUI lib does not provide one), with 3-4 presets like "Cleaner text - Balanced - Cleaner background, or whatever the outcome is likely to be.
You know better than us what the values do, so you can name them in a helpful for the user way..

In the documentation towards the end i explain what the options that I think are best for any given job..documentation can be seen from about page. it's been there since nearly the beginning of the program. I don't want to clutter the GUI with that stuff.

I use GPU-Z to monitor the GPU's processing, memory, power draw, etc., but you can see it if you look at the Windows task manager (Performance>Cuda).
95% of the processing is for Preparing Pipeline / Initializing.
At this stage only 1 CPU thread is working (I have 8 cores - 16 threads). No GPU work at all.
After that its the Render | Infer | Encode stage that takes almost no time at all.
At this stage I see some spikes of GPU processing (only for some ms) and then it ends.
This is what I mean by "overall the processing was done at the CPU".
A great improvement would be if this was utilizing all the available threads, but maybe the library doesn't support this.

My custom GPU library is very high performance and doesn't need to use much GPU. I can guarantee that it is using your GPU if you have one. Just stick to reporting what you see versus what you would like to see, rather than what you think the code does, in the future, with any feedback reporting..i've spent so much time on multithreading. I'll indulge you for a second..:

pdfium - not threadsafe. behind a mutex. cannot be parallelized.
my custom onnx runtime can but if pdfium can't, it doesn't matter, everything downstream depends on pdfium. in PNG folder mode, the multithreading works. binarizing and encoding always fan out to threads.

As I said, I had to use the Fixed threshold because of the false letters that the adaptive was detecting.
I do thing that an adaptive mode would work better in a book with text and images of different brightness, since it will treat every page differently, but it might need some fine tuning like the book I mentioned.
If there is no such option, let's forget it..

It already works per page, it never gets an entire book average. Why would a book have different brightness per page anyway? This just seems so complex for a user to use in the GUI that I have. Might as well use Scantailor if you need to do that.

OK then, more problems.
- Cropping is not working again.
It crops wherever it likes.
Turning the Layout detection Off, improves things sometimes, but not always.
I do recall that you said that you're gone set Free Aspect as default.
Well, I don't thing it is.
Even in the cases that cropping is almost working, all pages have almost the same size, even the ones that don't need to (a lot of blank space leftover)

Fixed in 1.4.63. Thank you for the bug report. It was working on my test files. It works on even more now.

- This is the taskbar icon of the app

and this is the app's window icon at dark themed Windows

It is almost impossible to be seen.
What I usually do for that, is to add a 1-pixel white (or light gray) runaround that is invisible at a light background, but shows the image if the background is dark..

I added a change for this, but if it doesn't show up, whatever.

But the big change this patch besides the backend stuff is grayscale mode, which should further address the "bad photocopy" complaint (i don't see it that way but thats ok). now there is an MRC based grayscale mode. It cleans the page via a different method than binarizing, then overlays a JBIG2 mask on top of the grayscale, so that the file size is only 20% larger than binarized output, and you get aliased text that looks better. It's not perfect but it's pretty good. Dare anyone to find a better one in a free program. I hope this will be the last version for awhile but something always comes up.

[embryo]

Just downloaded the latest GitHub release, but it's not 1.4.63. The About box says 1.4.62.
- One of my sample file doesn't get converted at all (used to get converted just fine)
- Cropping is still non-usable
.. didn't check more ..
I'll wait for an updated version..

[LegeApps]

Originally Posted by embryo

Just downloaded the latest GitHub release, but it's not 1.4.63. The About box says 1.4.62.
- One of my sample file doesn't get converted at all (used to get converted just fine)
- Cropping is still non-usable
.. didn't check more ..
I'll wait for an updated version..

Hi thanks for this update, although it's vague and more like a complaint than a bug report. I already finished an update to cropping with agent help, this will be in the next release, which will be 1.4.7, since there is going to be a major improvement to the pipeline in it.

It turns out that existing PDF renderers, including pdfium which Lege uses, are garbage [july 22 edit- it's not garbage, just began from obsolete architecture and never changed]. I believed they were single threaded by nature for some fundamental reason but they aren't. with fable and codex help I have created a stateless PDF renderer, first of its kind, that is currently rendering up to 10x faster than pdfium (this will not hold true in production due to thread contention). It was 2x faster without any optimization at all. This also allows a much better pdf viewer to be created, since every single PDF viewer besides Adobe Acrobat uses pdfium or poppler under the hood. So I am doing that in conjunction. Never been done before. Real things happening. Not just slop over here folks. I've got a 15,000 strong PDF library for regression tests and it isn't failing on a single one now.

Also the PDf writer has been replaced with custom code, so after the renderer is in, Lege will be custom end to end. Thanks to this year's models. May have been possible last year to some extent and I just wasn't asking the right questions.

Sorry for the more glaring bugs but they should be largely fixed now. I am doing my best to work it all out in the service of something even better and more advanced.