Improvements? New Features? post sigil 2.7.6

[DiapDealer]

Originally Posted by KevinH

All thoughts and comments welcome. I know it is a bit complicated but once set it should be very very flexible to match your preferred prettyprint style then it can be forgotten about.

Seems to work the way it was intended.

I'm curious why when right-clicking in Code View and choosing to Mend and Prettify the current file, the cursor always moves to the opening body tag?

To be clear: this happened in previous versions of Sigil as well (and I don't think it's a huge deal by any means). I just wondered if there's a reason behind it?

[KevinH]

Mend and Prettify both are based on parsing the complete xhtml file into its gumbo DOM tree of nodes and then serializing it back to xhtml following specific rules. So as a guess only ... when you prettify, you can change lines and add or remove chars, etc, so any character offset stored before we prettify will typically be wrong so maybe we just store the line?

Or maybe we try storing a webpath and hope to get close upon return?

Will have to check the code on that.

[KevinH]

Okay, I took a closer look at the gitee code to do prettyrint after spending hours updating its use of QRegExp (which was removed for Qt6 but still in Qt5 compat) to use QRegularExpression and getting it to compile it became clear it basically punts and never condenses any text no matter what.

That is not something I consider an actual prettyprint tool. It is more like a lint tool of some sort.

So imho it is not worth adding to Sigil either.

So we are have only one user controllable PrettyPrint option, not two.

So please give what is in master a try, and let me know if it does what you need.

Thanks.

[KevinH]

I am thinking of adding a safety check to our PrettyPrint which will walk all linked css files and internal xhtml style tags looking for the use of the white-space property with any value other than "normal" and refuse to prettyprint that file. FWIW, pre tags contents will properly not be condensed but not eveyone uses pre tags in their html.

Thoughts?

Update: This safer prettprint approach has now been pushed to master.

[KevinH]

I have also revisited the prettyprint code from that gitee sigil-modified site. I was able to extract and fix it to properly condense text. I will add create a plugin version of it (once translated to python) for people to try out as an alternative to our built in gumbo based prettyprinting.

[DNSB]

For anyone interested in testing the new code, here's a link to my compile of the latest code from Sigil's Github repository: Sigil-2.7.6-Windows-x64-Setup.exe.