Improvements? New Features? post sigil 2.7.6

[Turtle91]

Most often I get a lot of open tabs when I am using a regex to jump through the ePub. Creating a bookmark every time before clicking “next” doesn’t sound very fun.

[KevinH]

Okay, I have pushed the following to Sigil master:

- Becky's patch for ImageView.cpp so it fits image to the window and moved description to the top.

- use of actual times symbol in ResourceObjects/ImageResource.cpp so that it is used in GetInfo (again from BeckyEbook).

I have not implemented these changes in the ImageTab as I still want one way of seeing the image at its actual size. I will move its size information to the top though.

This is now in master.

[KevinH]

And I just tested opening Chapter10 of Alice in Sigil, hitting Bookmark, then opening the css and when done editing it, I hit Return (and you can assign shortcuts to these) and it all worked as expected.

So the capability to remember a Tab and return to it is already implemented in Sigil.

Even better, if you right click on a class in CodeView in an open Tab, it will take you to the css tab for editing and right to that class definition and it ***auto sets the Bookmarkl!*** so just hitting the back Button (see the BookMark and Return toolbar or using shortcuts or menus) will bring you back to your previously open tab.

So all of the functionality being asked for already exists in Sigil and works.

[KevinH]

So for all suggestions so far:

- image resized to fit to with descriptive info on top for ImageViewer (BeckyEbook)
- use full size image but with descriptive info on top for the ImageTab (my compromise)
- better use of multiply for GetInfo (ImageResource.cpp) (BeckyEbook)

are all in master now and:

- the ability to return to a previous spot (long implemented in Sigil). And the most common use case for right clicking on a class in CodeView automatically sets a BookMark so the Back button will always take you back.

So all that leaves is if and how to better visually highlight the active tab under Windows using the classic dark theme. I will leave that up to DiapDealer and BeckyEbook to work out.

So if anyone has any other suggestions/new feature requests please do let me know here.

[theducks]

Originally Posted by KevinH

Have you tried adding a BookMark before going to another tab. Then using the Return. Doesn't that work?

Been doing it the by tab way since I first started and never thought to look

[KevinH]

Originally Posted by Turtle91

Most often I get a lot of open tabs when I am using a regex to jump through the ePub. Creating a bookmark every time before clicking “next” doesn’t sound very fun.

That is not a use case where you expect Bookmarks to be auto set. Search and replace always follows the order provided by the search parameters over the domain range also provided by the search parameters. So if you want to return to the start of the search then by all means bookmark the start.

If you want to peruse a long list of potential replacements, then use the Dry-Run tool or use the FilterReplacements tool.

If you are just hoping around, there is no history of Tabs tool. And I really can not see the need for one either to be honest.

[DNSB]

Originally Posted by KevinH

To try to summarize for my sake:

We have 1 vote for full size images (me) and 3 or 4 votes for fitted images.

I can see that if all you want is size info without scrolling, the move to top for the descriptive info will save scrolling for some full size images, (but Get Info will tell you the same thing).

I do not think it matters, if images are fitted, whether the descriptive info is at top or bottom (no good arguments yet presented one way or the other).

Is this pretty much correct?

...

Thoughts on this compromise?

Sounds good me to me. The info at the top saves me from having to scroll to the bottom to get that info especially for cover images which tend to be the largest when dealing with full size images. For fitted images, 6 of one and 2 threes of the other.

[KevinH]

Originally Posted by DNSB

Link to my compile of the latest code can be obtained from: Sigil-2.7.6-Windows-x64-Setup.exe

Thanks so much for creating and posting this, as it allows others to try things out so they can comment on them!

[DNSB]

Originally Posted by KevinH

Thanks so much for creating and posting this, as it allows others to try things out so they can comment on them!

It takes very little effort after I compile the code for my use and as you said, it allows others to try things out and increases the chances that someone will spot an issue.

[BeckyEbook]

I’ve been out all day, but I’m back now and have read all the new posts.

To clarify:
Ad 1 (fitting the image to the window): a brilliant, truly Solomon-like solution – dimensions at the top, double-clicking on the image gives the full size, but going via ‘Go To Link’ allows for a quick preview of the whole image.

Ad 2 (active tab): I regard this QSS code as a curiosity that might be useful to a certain group of people who miss this additional active tab indicator.
This is a group of people who:
a) use Windows
b) use dark mode
c) use classic dark mode [i.e. NOT @BetterRed, as he uses the Qt style]
d) may have some vision problems (which is entirely understandable)
That is why, especially for these people, I have presented the ready-made QSS code, which they may, but are under no obligation to, use.
I spent far longer than I should have tinkering with the tab styling myself, simply because I was worried that by ‘removing’ that red close symbol, I might make it harder for someone with vision problems to use Sigil, and that made me feel bad.

Ad 3 (multiplication sign). That’s exactly what I meant. The previous character (U+2715) was too conspicuous. Thank you.

[BetterRed]

@DiapDealer - Spellchecking using the Spell checker will jump in and out of existing tabs and append new ones as each misspelt word is dealt with.

Knowing where one is in a work helps provides context. Some spelling errors are not 'wrong', e.g, could be a mispronounced word in dialogue, could be jargon, could be a quote from a US publication, in a work set to use UK dictionary.

BR

[BetterRed]

Originally Posted by BeckyEbook

This is a group of people who:
a) use Windows
b) use dark mode
c) use classic dark mode [i.e. NOT @BetterRed, as he uses the Qt style]

Because it gives me the red cross differentiator on CV tabs.

Originally Posted by BeckyEbook

I have presented the ready-made QSS code, which they may, but are under no obligation to, use.

I'll be giving it a try it later.

BR

[BetterRed]

I'll be giving it a try it later.

I will go back to where I was, and leave it at that.

Suggestion for Kevin - a Restart option.

BR

[KevinH]

I think you are using qss to show focus in Sigil in yellow that interferes with the new top border. Perhaps these changes should be limited to just the TabBar class used in Sigil's TabManger.

If so, I think that qss BeckyEbook supplied needs to only specify just the Tabbar that is a child of the TabManager which has a setObjectName of "tabmgr".

So those selectors might need to use a descendent selector something like the following:

QTabWidget#tabmgr QTabBar

instead of just QTabBar

Of course I have not tested that but it should work in theory based on my reading of the Qt qss documentation.

If that doesn't work we can use setObjectName in TabBar.cpp to set its specific id so that is can be more easily identified uniquely. That would be an easy one-line change to make in the code.

[jugaor]

BeckyEbook: Thank you so much for following up on my requests and providing solutions.

After the initial negative response, I had come up with a simple solution:

/* diferenciar pestaña activa */
QTabBar::tab:selected {
	background-color: Green;
	font-weight: bold;
}

but your qt_styles.qss redesign is beautiful! (now I don't know which one to choose )

Originally Posted by KevinH

So those selectors might need to use a descendent selector something like the following:

QTabWidget#tabmgr QTabBar

instead of just QTabBar

Of course I have not tested that but it should work in theory based on my reading of the Qt qss documentation.

Kevin, your specificity works very well.
Although, in my case, I prefer the change to be global (it doesn’t conflict with Classic Dark Mode).