|
|
#11656 | |
|
Guru
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 833
Karma: 2873645
Join Date: Jul 2008
Location: Texas
Device: PW5, Oasis 3, K4B(NT), K3/KK
|
Quote:
|
|
|
|
|
|
|
#11657 |
|
Plugin Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 7,266
Karma: 5007213
Join Date: Dec 2011
Location: Midwest USA
Device: Kobo Clara Colour running KOReader
|
New Test Version Posted
2026-02-02 - Refactor metadata entry and settings name code a bit - Remove Site: swi.org.ru No DNS for site. - Make some metadata entries immutable - adapter_adultfanfictionorg: Fixes for site changes #1305 |
|
|
|
|
|
#11658 |
|
Connoisseur
![]() Posts: 53
Karma: 10
Join Date: Oct 2014
Device: Kindle Fire HD
|
It looks like whatever change was made to the RoyalRoad plugin in 4.54.0 has broken all downloads from that website. It now shows an error along the lines of "Nonetype has no attribute 'startswith'".
Broken in both 4.54.0 and latest test version, working in 4.53.0 after downgrading. Edit: Using Calibre plugin, Windows 10 |
|
|
|
|
|
#11659 |
|
Plugin Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 7,266
Karma: 5007213
Join Date: Dec 2011
Location: Midwest USA
Device: Kobo Clara Colour running KOReader
|
I'm not seeing that. Story URL? (SFW please)
|
|
|
|
|
|
#11660 |
|
Plugin Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 7,266
Karma: 5007213
Join Date: Dec 2011
Location: Midwest USA
Device: Kobo Clara Colour running KOReader
|
New Test Version Posted
2026-02-02 - Refactor metadata entry and settings name code a bit - Remove Site: swi.org.ru No DNS for site. - Make some metadata entries immutable - adapter_adultfanfictionorg: Fixes for site changes #1305 - adapter_fimfictionnet/adapter_royalroadcom: Better handling of cover image size fall back #1306 I still haven't seen it happen, but I speculate that watani's problem comes from either the story cover image being smaller than cover_min_size, or in cover_exclusion_regexp. Last edited by JimmXinu; Yesterday at 03:20 PM. Reason: Reword |
|
|
|
|
|
#11661 |
|
Enthusiast
![]() ![]() Posts: 27
Karma: 110
Join Date: Oct 2018
Device: Kindle
|
I get the NoneType startswith issue on all RoyalRoad stories I had. Example: https://www.royalroad.com/fiction/12...petent-history
Found two issues Line 280 - logger.debug("stars:(%s)"%self.story.getMetadata(' stars')) and then line 292 - if self.setCoverImage(url,cover_url.replace('/covers-full/', '/covers-large/'))[0].startswith("failedtoload"): Not sure why either of them would be None, but I added extra None checks to the second (and commented out the first), and it worked. Last edited by theducks; Yesterday at 07:53 PM. Reason: disabled smilies |
|
|
|
|
|
#11662 |
|
Connoisseur
![]() Posts: 53
Karma: 10
Join Date: Oct 2014
Device: Kindle Fire HD
|
Updated to latest test version and it seems like things are working again. I suspect it was Line 292 in the royalroad plugin as mentioned by fanfictioneer, which I've seen you've already fixed.
Edit: Since I noticed that royalroad was always downloading the low res version of the cover in the past, I had set FFF to globally never make covers for royalroad fics and instead I would manually download the high res cover for each new fic. This setting is probably why I encountered the issue and not you. Last edited by watani; Yesterday at 08:01 PM. Reason: Providing possible reason for seeing issue |
|
|
|
![]() |
| Tags |
| fanfiction |
|
Similar Threads
|
||||
| Thread | Thread Starter | Forum | Replies | Last Post |
| [GUI Plugin] KindleUnpack - The Plugin | DiapDealer | Plugins | 529 | 01-28-2026 11:32 AM |
| [GUI Plugin] Open With | kiwidude | Plugins | 404 | 02-21-2025 06:42 AM |
| [GUI Plugin] Marvin XD | Philantrop | Plugins | 126 | 01-29-2017 01:48 PM |
| [GUI Plugin] KiNotes | -axel- | Plugins | 0 | 07-14-2013 07:39 PM |
| [GUI Plugin] Plugin Updater **Deprecated** | kiwidude | Plugins | 159 | 06-19-2011 01:27 PM |