Beta testers for calibre 9 needed

[DisabledReader]

Originally Posted by theducks

You can change the column TITLE for your Pages. I just made mine read PagesPI (do not change the lookup: #pages. the # makes it different)

PI = PlugIn version

Yes, I can.
I raised the point though for the thousands of users of the plugin that are not technically minded.
Telling them to go away and just make changes to their library setup, is likely to cause greater issues.
As the development is still in beta it would be better to change the internal column name, in my view anyway.

[kovidgoyal]

You can have any number of columns with the same name. The new builtin column is not visible by default, most people would not even be aware it exists. And since column names is a global namespace such clashes are inevitable, the price of allowing people to create their own columns.

[DisabledReader]

Originally Posted by kovidgoyal

You can have any number of columns with the same name. The new builtin column is not visible by default, most people would not even be aware it exists. And since column names is a global namespace such clashes are inevitable, the price of allowing people to create their own columns.

Thank you for the clarification, Kovid.

[JSWolf]

Originally Posted by theducks

You can change the column TITLE for your Pages. I just made mine read PagesPI (do not change the lookup: #pages. the # makes it different)

PI = PlugIn version

But then we could have used our Pages column for other things. So it's a matter of having to change something. And given this is a beta. it's best to have to change what's new.

[BetterRed]

Originally Posted by kovidgoyal

You can have any number of columns with the same name. The new builtin column is not visible by default, most people would not even be aware it exists. And since column names is a global namespace such clashes are inevitable, the price of allowing people to create their own columns.

Users cannot create two custom columns in the same library with the same Lookup name or Column header value.



The built-in "pages/Pages" column is visible in several places e.g.



FTR - my (just for the sake of it) #space/Space column



Hmmm - #swidth/Swidth (spine width) would be better.

BR

[un_pogaz]

Originally Posted by BetterRed

Users cannot create two custom columns in the same library with the same Lookup name or Column header value.

[...]

Hmmm - #swidth/Swidth (spine width) would be better.

BR

Yes, except that this limitation only apply on custom columns, you can create a cc with the same header than a build-in column without issue.


And using any other name than "Pages (pages)" will not reflect that this column store a Pages count value. Yes, this value is mostly used in the Bookshelf but this value is transformed and could be used elsewhere, either by calibre or others users.

[un_pogaz]

Hey @Kovid, after running the pages count on my entire library, I encounter this error:

Callstack:t#0 Error Source: main/PdfParser.cpp(97), Information: Unable to load objects from file
t#1 Error Source: main/PdfParser.cpp(143), Information: Unable to load xref entries
t#2 Error Source: main/PdfParser.cpp(356)
File: main/PdfParser.cpp Line: 97 Unable to load objects from file
File: main/PdfParser.cpp Line: 143 Unable to load xref entries
File: main/PdfParser.cpp Line: 356 

Traceback (most recent call last):
  File "/mnt/data/Workspaces/calibre/src/calibre/library/page_count.py", line 257, in serve_requests
    result = count_pages(path, executor)
  File "/mnt/data/Workspaces/calibre/src/calibre/library/page_count.py", line 188, in count_pages
    return count_pages_pdf(pathtoebook)
  File "/mnt/data/Workspaces/calibre/src/calibre/library/page_count.py", line 42, in count_pages_pdf
    return get_page_count(pathtoebook)
  File "/mnt/data/Workspaces/calibre/src/calibre/utils/podofo/__init__.py", line 183, in get_page_count
    p.load(raw)
    ~~~~~~^^^^^
podofo.Error: PdfErrorCode::NoEOFToken, No EOF Marker was found in the PDF file.
Callstack:t#0 Error Source: main/PdfParser.cpp(97), Information: Unable to load objects from file
t#1 Error Source: main/PdfParser.cpp(143), Information: Unable to load xref entries
t#2 Error Source: main/PdfParser.cpp(356)
File: main/PdfParser.cpp Line: 97 Unable to load objects from file
File: main/PdfParser.cpp Line: 143 Unable to load xref entries
File: main/PdfParser.cpp Line: 356

hmm, damn, after open it in Okular, page count seem out of sync, realy strange.
Since is a PDF I don't know how to share it.

[kovidgoyal]

That's a corrupted PDF that podofo cant read. It's not as tolerant of corrupted PDF as other software. And you can always share files by putting them in zip archives.

[JSWolf]

Are any fixes for 8.16.2 going to be part of the beta?

[Karellen]

@kovidgoyal

Not sure if this is a bug with Check Book in v8.99.x or if it has always been like this.

Noticed a paragraph with nested <p></p> tags but Check Book did not pick this up as an error. Tried with <div></div> tags also, and no error.

PHP Code:

<p>This is a <p></p>paragraph.</p> 


Should this be found?

[kovidgoyal]

@Karellen: No nested <p> tags are not an error as they dont cause actual issues on any actual renderers that I know of.

@JSWolf: yes

[Karellen]

ok thanks @kovidgoyal

[JSWolf]

Originally Posted by Karellen

@kovidgoyal

Not sure if this is a bug with Check Book in v8.99.x or if it has always been like this.

Noticed a paragraph with nested <p></p> tags but Check Book did not pick this up as an error. Tried with <div></div> tags also, and no error.

PHP Code:

<p>This is a <p></p>paragraph.</p> 


Should this be found?

epubcheck also will not flag these as an error because while bad code, they are not an error.

[JimmXinu]

Originally Posted by un_pogaz

Yes, except that this limitation only apply on custom columns, you can create a cc with the same header than a build-in column without issue.

Actually, I see the same thing: Trying to create custom column with lookup name mypages and Column heading Pages fails: "The heading Pages is already in use."

Creating a custom column headed 'Authors'--your example--works, but not 'Pages'.

Creating a cc headed Pages in 8.16.2 and then opening in 8.99.3 gives the same error "The heading Pages is already in use" if I try to edit that cc.

[Karellen]

Originally Posted by JSWolf

epubcheck also will not flag these as an error because while bad code, they are not an error.

Bzzzz! Wrong.

.