![]() |
#586 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 28,659
Karma: 205039118
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
Are you sure? It was my understanding that AlternateBase (in plugin_utils.py) is being assigned the same color as the Window role from Sigil.
https://github.com/Sigil-Ebook/Sigil...unner.cpp#L244 https://github.com/dougmassay/sigil-..._utils.py#L264 https://github.com/dougmassay/sigil-..._utils.py#L272 Unless Base and Window are the same color. I'm not opposed to your suggestion, but I would ultimately like the actual system alternateBase color to be used. With a hard-coded color in plugin_utils.py being embedded in tons of Qt plugins, that might not be a realistic hope. I'd rather we didn't have to do this (match_dark_palette) on Windows at all, but... ![]() |
![]() |
![]() |
![]() |
#587 |
Guru
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 854
Karma: 3341026
Join Date: Jan 2017
Location: Poland
Device: Various
|
Of course – not Base, but Window.
|
![]() |
![]() |
![]() |
#588 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 28,659
Karma: 205039118
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
I went ahead and updated plugin_utils.py (and the light version) with your suggested color. Thanks!
|
![]() |
![]() |
![]() |
#589 |
Enthusiast
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 48
Karma: 605108
Join Date: Apr 2016
Device: none
|
Ok, I updated my copy of plugin_utils too.
One question for DiapDealer: the readme of the sigil-plugin-utils repository indicates the GPL v3 license but the notice at the top of each file shows the 2-clause BSD license. Is the latter the valid one or do you have another preference? |
![]() |
![]() |
![]() |
#590 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 28,659
Karma: 205039118
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
I prefer the 2-clause BSD (more permissive than GPLv3). I think GitHub might have just defaulted to GPLv3 when I quickly created the repo. I'll try to make them match. Thanks.
EDIT: I think I got everything updated to match on GitHub. Thanks again. Last edited by DiapDealer; Yesterday at 12:10 PM. |
![]() |
![]() |
![]() |
|
![]() |
||||
Thread | Thread Starter | Forum | Replies | Last Post |
Loading Plugin in development | Sladd | Development | 6 | 06-17-2014 06:57 PM |
Question for plugin development gurus | DiapDealer | Plugins | 2 | 02-04-2012 11:33 PM |
DR800 Plugin development for DR800/DR1000 | yuri_b | iRex Developer's Corner | 0 | 09-18-2010 09:46 AM |
Device plugin development | reader42 | Plugins | 10 | 03-29-2010 12:39 PM |
Calibre plugin development - Newbie problems | minstrel | Plugins | 5 | 04-12-2009 12:44 PM |