![]() |
#1 |
Bibliophagist
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 44,446
Karma: 167726581
Join Date: Jul 2010
Location: Vancouver
Device: Kobo Sage, Libra Colour, Lenovo M8 FHD, Paperwhite 4, Tolino epos
|
Images duplicated in removal screen
I was noticing an oddity when removing unused images. I was cleaning up a book today where the creator had used a separate but identical image for each chapter header and scene break. In the XHTML files, I renamed the images to the same name and then deleted the unused images. I noticed that I had 2 entries in the unused images list for each image. This was using my compiled version of the Sigil beta. I decided before grumbling to try Kevin's precompiled beta 2 (Sigil 2.5.0, QT 6.8.2). Sadly I got the same results when removing unused images. It seems to be purely cosmetic but a bit of a shock when I first noticed.
|
![]() |
![]() |
![]() |
#2 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 28,335
Karma: 203719142
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
I'm using a pre-beta version of 2.4.2 and can see this problem too. It also manifests when using "Insert File". I get duplicates of all images available to insert.
|
![]() |
![]() |
![]() |
#3 |
Sigil Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 8,434
Karma: 5702578
Join Date: Nov 2009
Device: many
|
Wow! That is a new one I have never seen before. Not sure what is doubling Images for Delete File and Insert File. Perhaps a multithreaded thing?
I will look into it. |
![]() |
![]() |
![]() |
#4 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 28,335
Karma: 203719142
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
Maybe something went wrong with an ifdef removal in one of our code cleanups?
|
![]() |
![]() |
![]() |
#5 |
Sigil Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 8,434
Karma: 5702578
Join Date: Nov 2009
Device: many
|
Both issues were caused by trying to treat svgimages as a separate resource type but they are stored in the same BookBrowser Images folder as regular images so everything in the Images folder gets added twice. So fix one bug cause another. Either way, this is now fixed in Sigil master for both delete unused media and insert files.
Thanks for the bug report! |
![]() |
![]() |
![]() |
#6 |
Bibliophagist
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 44,446
Karma: 167726581
Join Date: Jul 2010
Location: Vancouver
Device: Kobo Sage, Libra Colour, Lenovo M8 FHD, Paperwhite 4, Tolino epos
|
You're welcome!
Edit: Built the updated version and looks good. Last edited by DNSB; 03-04-2025 at 07:26 PM. Reason: Build new version |
![]() |
![]() |
![]() |
#7 |
Sigil Developer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 8,434
Karma: 5702578
Join Date: Nov 2009
Device: many
|
FYI - In case you did not want to build your own again, I just now added Beta4 binaries on my repo (See the end of the New Features thread) which have that bug fix already in place.
|
![]() |
![]() |
![]() |
|
![]() |
||||
Thread | Thread Starter | Forum | Replies | Last Post |
Moon+ Reader Pro: Enabling "Fit all images to screen" makes some images smaller | inter | Android Devices | 0 | 03-25-2024 11:53 PM |
EPUB to PDF: how to keep duplicated images? | Bidasci | Conversion | 3 | 09-08-2021 01:11 PM |
Aura HD Full screen in-book images | omnimodis78 | Kobo Reader | 12 | 06-02-2014 04:18 PM |
Full-Screen images on the K2? | Thorkin | Amazon Kindle | 1 | 03-12-2009 07:48 PM |
screen updates (images) | whopper | iRex | 4 | 11-24-2008 02:00 PM |