Suggestions for filter replacements dialog

[KevinH]

Originally Posted by bravosx

Today I installed version 2.4.0 on Windows 10 22H2 and so far I see no disadvantages, only advantages. The checkboxes work fine. In my opinion, it is worth including the fix in the target version.

Thanks, regards bravosx

Thank you for testing and reporting back. Also glad to hear my Windows 11 build was a success. It worked on my machine, but testing it on the same machine used to build it, often is not rigorous enough to catch all build issues with potentially missing dlls.

[KevinH]

Originally Posted by retiredbiker

Sorry, I've been busy, actually this is very good for my work in Sigil. I've often spent a lot of time just going through a search one step at a time. I just rebuilt (on Linux) this morning and yes I see the checkboxes, and they work a treat! Thank you!

Thank you for testing and reporting back.

It seems everyone so far sees no disadvantages for using checkboxes.

[DNSB]

I installed your Windows build. The checkbox feature works and I didn't notice any oddities editing a couple of epubs. Looks like your Windows build process is a happy camper.

[KevinH]

Originally Posted by DNSB

I installed your Windows build. The checkbox feature works and I didn't notice any oddities editing a couple of epubs. Looks like your Windows build process is a happy camper.

Great! Thank you!

[KevinH]

Since all testers appear to be in agreement with the OP's feature request, I have now pushed those changes to Sigil master. They will appear in the upcoming release.

[askerkacagi]

Originally Posted by KevinH

Since all testers appear to be in agreement with the OP's feature request, I have now pushed those changes to Sigil master. They will appear in the upcoming release.

I think it's a very useful feature. I think I could use it. I have only one problem:
I use saved searches for OCR corrections. When I selected a group within saved searches, in previous versions (2.1.0 and earlier) I would press the Find button with the mouse a few times and then press the spacebar on the keyboard to move on to the next search and word. Unfortunately, I can't do this in the 2.2.0 and 2.4.0 test versions.
Maybe you want to look at this before the new version.
Many thanks to the Sigil team.
If I can, I will add a screenshot to explain better.

I signed up to report this
I wrote it using Google Translate, I apologize in advance for my mistakes.

https://imgur.com/a/pPZKlKx

[KevinH]

Using space was not a planned feature. Space was never an intended key for changing things. On some platforms like Mac it was used because the user did not select the Mac system preferences to use Tab navigation. My guess is a down arrow or tab will do the same thing, won't it?

What platform are you using? Which widget has keyboard focus when you press the space?

[askerkacagi]

Thank you for your answer.

Unfortunately no. This does not do what I want.

In version 2.1.0, moving to the next word or find and replace with the spacebar both eliminates the mouse click sound and requires less effort.
You can switch within a group with the up or down arrow keys. The Tab key also allows you to navigate columns and rows in a similar way.


It is in the screenshot in the link (Imgur site, I could not add it here, I am trying to figure it out). In Saved searches

I forgot to write my system Windows 10 22H2 Single Language, Turkish.

[KevinH]

I really need you to be much more specific. Testing with the 2.4.0-Beta-1 build only.

Please provide an exact sequence of instructions (which widget, exactly what is entered or typed when and where, etc, include which widget has keyboard focus, etc) that will illustrate the issue so I can recreate it.

Your images do not show which widget has focus when you hit "space" and when exactly (what sequence) you are doing.

Use a public domain epub in your instructions as an example, that way everyone can get access to it. Export a sample saved search to csv so we are working on the exact same thing.

As an alternative, instead create two annotated videos, one showing Sigil 2.1 and the other showing the Sigil 2.4-Beta-1in which you describe what you are doing while doing it.

Once I understand what exactly you are doing and what widget has focus, I will look into the possibility of restoring that lost functionality.

[askerkacagi]

Thanks. I think it would be best to record a video.

Version 2.1.0:

Sigil-201.avi

It doesn't really matter what the search terms are in the saved search, it's just that after the first few mouse clicks on the searched phrase, the search should continue with the space bar.

Version 2.4.0 beta:

Sigil-240-1.avi

Sigil-240-2.avi

I think I can show this with a video. If I can't add it here, I hope to add the links somehow. I need a little more practice in writing and editing messages. I would be happy if you could show me the right way in case of any possible mistakes I make. Thank you very much.

[KevinH]

Unfortunately, avi movies do not work on MacOS with the native video player.

So I played around with the Sigil-2.1 version on MacOS. I do notice a difference. In Sigil 2.1 the Find button inside the Saved Search dialog maintains keyboard focus (you can see a light blue focus ring around that button).

So all the "space' bar is doing is the equivalent of clicking on the the Saved Searches Find button again.

In Sigil 2.4.0-Beta-1, the Find button inside the Saved Searches Dialog, does not maintain keyboard focus at all allowing focus to go back to the Saved Searches tree instead.

I would probably be better for Sigil to create a shortcut for the Find button inside the Saved Search dialog so that keyboard can be used to effectively "click" on that button.

I will see how doable that really is.

[askerkacagi]

Originally Posted by KevinH

Unfortunately, avi movies do not work on MacOS with the native video player.

So I played around with the Sigil-2.1 version on MacOS. I do notice a difference. In Sigil 2.1 the Find button inside the Saved Search dialog maintains keyboard focus (you can see a light blue focus ring around that button).

So all the "space' bar is doing is the equivalent of clicking on the the Saved Searches Find button again.

In Sigil 2.4.0-Beta-1, the Find button inside the Saved Searches Dialog, does not maintain keyboard focus at all allowing focus to go back to the Saved Searches tree instead.

I would probably be better for Sigil to create a shortcut for the Find button inside the Saved Search dialog so that keyboard can be used to effectively "click" on that button.

I will see how doable that really is.

Ah, thank you very much. I think I was able to express the problem correctly. From what you wrote, I understood that the focus change was the cause, and I think that was the problem.

By the way, I sometimes forget how many operating systems there are (windows, linux, mac etc.) so when I thought only about the Windows operating system and the forum only allowed me to upload avi, I guess we encountered such a situation.

Maybe you can see it on imgur.

https://imgur.com/a/5AlcJu8

[KevinH]

I grabbed the free vlc player that I use on Linux and downloaded the MacOS video. I was able to play both videos but unfortunately the Sigil 2.1 video does not even show the SavedSearches Dialog at all. And the Sigil-2.40-1.avi shows the Saved Searches dialog in the movie but does not show you using it at all.

Either way, I think the change in focus is what lead to this issue. That change was made so that the Saved Searches tree can be navigated using Tab and Shift-Tab. In fact the trick to use a spacebar, actually only worked in that specific version of Sigil. Both earlier and later versions (than Sigil 2.2.1) did not have the strong focus policy on the Find button which enabled the spacebar use which is why I was unfamiliar with it.

I will look to see if assigning a keyboard shortcut will help.

[askerkacagi]

Originally Posted by KevinH

I grabbed the free vlc player that I use on Linux and downloaded the MacOS video. I was able to play both videos but unfortunately the Sigil 2.1 video does not even show the SavedSearches Dialog at all. And the Sigil-2.40-1.avi shows the Saved Searches dialog in the movie but does not show you using it at all.

Either way, I think the change in focus is what lead to this issue. That change was made so that the Saved Searches tree can be navigated using Tab and Shift-Tab. In fact the trick to use a spacebar, actually only worked in that specific version of Sigil. Both earlier and later versions (than Sigil 2.2.1) did not have the strong focus policy on the Find button which enabled the spacebar use which is why I was unfamiliar with it.

I will look to see if assigning a keyboard shortcut will help.

I really feel embarrassed that you spent so much time on me.

I used Alice’s Adventures in Wonderland epub file on Mobilread.

And as you said, when using 2.1.0, the blue focus point is around the find button, but not in 2.4.0.


I used the following .ini file for saved searches (I took only one group from the existing saved searches, just for testing. I saved it as txt to upload it here.)

test-txt.txt

Thank you so much...

[BetterRed]

@KevinH - FWIW: one of the reasons I prefer the Sigil editor to calibre's is that I can Tab to the Find button and then press space to step through all occurrences of the search term. It's invaluable in dealing with content inconsistencies. I wouldn't want to lose it.

Windows 10, Sigil 2.3.0

BR