[GUI Plugin] Reading Goal

[ownedbycats]

Small bug: When sorting by series, the series index is sorted alphabetically and books may appear in the wrong order.

[ownedbycats]

Since it's stored as "Horses of Half-Moon Ranch [8]" in the json, I tried editing the series to pad with 0s - worked for older years, not the current.

It didn't really look good though so I reverted it.

[chaley]

Originally Posted by ownedbycats

Small bug: When sorting by series, the series index is sorted alphabetically and books may appear in the wrong order.

If you use utils.icu.numeric_sort_key as the key function when the list is sorted then the problem should go away.

[thiago.eec]

Originally Posted by ownedbycats

Small bug: When sorting by series, the series index is sorted alphabetically and books may appear in the wrong order.

Please test the attached version. It should be fixed.

Originally Posted by chaley

If you use utils.icu.numeric_sort_key as the key function when the list is sorted then the problem should go away.

Thanks for the tip. I'm already overriding the __lt__ method in QTreeWidgetItem to fix other sorting issues, so it felt easier to deal with it the same way.

Spoiler:

class QTreeWidgetItem(QtWidgets.QTreeWidgetItem):
    def __lt__(self, other):
        column = self.treeWidget().sortColumn()
        if column == 4:  # Fix for Series sorting (account for series_index)
            first = self.text(4)
            first_series_name = re.sub(' \[\d+\.\d+\]', '', first)
            first_series_index = re.search('\[\d+\.\d+\]', first)
            second = other.text(4)
            second_series_name = re.sub(' \[\d+\.\d+\]', '', second)
            second_series_index = re.search('\[\d+\.\d+\]', second)
            if first_series_name == second_series_name and first_series_index and second_series_index:
                return float(first_series_index[0].strip('[]')) < float(second_series_index[0].strip('[]'))

[ownedbycats]

Sorting is working, but there's also another (hopefully) unintended effect lol.

[thiago.eec]

Originally Posted by ownedbycats

Sorting is working, but there's also another (hopefully) unintended effect lol.

Do you mean the floating point? I added it to fix sorting for non integer series indexes. Using the last stable release, [2.5] would be listed before [2.0]. But I'll check if I can fix this in any other way.

Fixed. Test the attached version.

[ownedbycats]

[thiago.eec]

Version 1.7.7 - 25 Nov 2024

- Fix the Series column sort not working properly

[ownedbycats]

Odd calculation. I have a short book with two entries. I began it just before midnight and finished it just before 3 a.m.

      "page_count": 37,
      "read_pages": 37,
      "records": {
        "0": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-11-29T03:48:22.529778+00:00"
          },
          "read_pages": 0,
          "status": 0
        },
        "1": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-11-29T06:57:30.081154+00:00"
          },
          "read_pages": 37,
          "status": 100.0
        }
      },

However, the tooltip shows "finished in 2 days." I thought it should say 1?

[thiago.eec]

The algorithm does not count hours, only days. Since you have records in two different days, it counts as two.
Yours is an edge case, though. I'll see if I can come up with extra tests to detect scenarios like this.

[rantanplan]

I tried to create a custom challenge for 2025, but the date selectors won't let me select any timeframe outside 2024.

[ownedbycats]

Originally Posted by rantanplan

I tried to create a custom challenge for 2025, but the date selectors won't let me select any timeframe outside 2024.

That's intentional. Wait until 2025.

[thiago.eec]

Version 1.7.8 - 01 Jan 2025

- Fix a bug in the Statistics dialog, when choosing 'All' and the new year is empty

[thiago.eec]

Version 1.7.9 - 01 Jan 2025

- New feature: added a year dropdown menu to the 'Custom challenges' dialog

[sandrilea]

When I used calibre/reading goal the first time in the new year I got an error message:

Invalid year: These books could not be updated/added to your reading goal because the reading date does not match the reading goal year.

One book was marked: Baustellen der Nation

That book was the only one I was "reading". It belongs to the annual challenge 2024 and to the custom challenge Sachbuch I created last year.

I tried to delete the custom challenge, to remove this book from the challenge, from the reading goal, nothing works. I even tried to edit the json-file but I don't want to mess it up as I don't know what I am doing.

What can I do?