[GUI Plugin] Reading Goal

[thiago.eec]

Originally Posted by Terisa de morgan

@thiago.eec, would you accept a new Spanish translation? "Sin libros ha sido añadido a la base de datos" (or something like that) is making me crazy

Sure! I'll wait for you to send it before releasing the new version fixing @Wiggo's problem.

[chaley]

Originally Posted by thiago.eec

I tested here using your RP column and got the same error. Apparently the switch_if function only return strings. Test the version attached version with a fix.

FWIW: All template functions return only strings. Even float and integer column references return strings.

[Wiggo]

Originally Posted by thiago.eec

I tested here using your RP column and got the same error. Apparently the switch_if function only return strings. Test the version attached version with a fix.

Thank you so much thiago, it works again!

Just one thing. My rereads are displayed with (1x), but are no longer in orange respectively in the rereading shelf. When I click on ‘show books records’, only the respective year is shown.

[thiago.eec]

Originally Posted by chaley

FWIW: All template functions return only strings. Even float and integer column references return strings.

Thank you for the tip. And just to be sure... is that the case even using Python mode?

Originally Posted by Wiggo

Thank you so much thiago, it works again!

Just one thing. My rereads are displayed with (1x), but are no longer in orange respectively in the rereading shelf. When I click on ‘show books records’, only the respective year is shown.

1) Mark the option 'Keep 'Rereading' color for finished books in the config dialog
2) When you are visualizing your 2024's goal, you only see records for that year. If you want to see other years too, you need to chose 'All' in the year dropdown menu.

[chaley]

Originally Posted by chaley

FWIW: All template functions return only strings. Even float and integer column references return strings.

Originally Posted by thiago.eec

Thank you for the tip. And just to be sure... is that the case even using Python mode?

The formatter interpreter requires that a template function, even a user-defined one, return a string. All built-in template functions return strings.

However, it is possible to work around the formatter coercing the returned value to a string. A user-defined template function can successfully return a non-string if it is directly called by python code such as a python template. A stored python template can return a non-string if it is directly called by python code or a python template. Non-string arguments can be passed as an argument to a python stored template and a user-defined template function. These uses are edge-case, very fragile, and not recommended.

I can think of one exception to the above: using stored python templates or functions as a python code library, called by stored python templates using context.funcs. Calling via context.funcs avoids the formatter interpreter. Although this is possible, it is pushing the limits of what the template system was designed to do. I think it would be better to write this kind of code as a plugin.

[thiago.eec]

I see. I think it's better keep it simple. The plugin is just using int(str) to convert the value, since it is supposed to be a number, even if represented as a string.

[Wiggo]

Originally Posted by thiago.eec

1) Mark the option 'Keep 'Rereading' color for finished books in the config dialog

'Keep rereading colour' is marked - never changed it
If I switch to rereading shelf, no entries as mentioned above

2) When you are visualizing your 2024's goal, you only see records for that year. If you want to see other years too, you need to chose 'All' in the year dropdown menu.

I had forgotten that - thank you. On "All" show book records "shows" all reading dates - strange.

Should I send you the json file?

[thiago.eec]

Originally Posted by Wiggo

'Keep rereading colour' is marked - never changed it
If I switch to rereading shelf, no entries as mentioned above

Choosing a rereading shelf doesn't work for you because you chose not to fill in the reading progress. Your template only gives 0% or 100%, so you will never see books under 'Reading' or 'Rereading'. That would require a value between 0 and 100.

I added some more options to the 'Rereading' shelf/color a while ago. Maybe, you need to reset your config options. Try this:

1) Uncheck all the checkboxes on the first tab of the config dialog
2) Click OK to confirm
3) Open the 'Edit reading goal' dialog and close it
4) Open the config dialog and check the boxes you want
4) Reopen the 'Edit reading goal' dialog and see if it fixed the issues

If that doesn't help, then send me your json.

Originally Posted by Wiggo

On "All" show book records "shows" all reading dates - strange.

Why do you think is strange? When you choose 'All', the plugin aggregates all your data, from all years, so all the records are there. If you choose a single year, then only that year's data is available on the records.

[ownedbycats]

A strange behaviour that I've been wondering is intended.

I start off with a book with 0% percentread and no date. Then I add a date and delete the old entry:



However, upon the next update:



To get around this, I instead set it to 1%, then back to 0% before deleting the two old entries:

[Wiggo]

Originally Posted by thiago.eec

Choosing a rereading shelf doesn't work for you because you chose not to fill in the reading progress. Your template only gives 0% or 100%, so you will never see books under 'Reading' or 'Rereading'. That would require a value between 0 and 100.

I added some more options to the 'Rereading' shelf/color a while ago. Maybe, you need to reset your config options. Try this:

1) Uncheck all the checkboxes on the first tab of the config dialog
2) Click OK to confirm
3) Open the 'Edit reading goal' dialog and close it
4) Open the config dialog and check the boxes you want
4) Reopen the 'Edit reading goal' dialog and see if it fixed the issues

If that doesn't help, then send me your json.

Didn't work.

Why do you think is strange? When you choose 'All', the plugin aggregates all your data, from all years, so all the records are there. If you choose a single year, then only that year's data is available on the records.

Strange in that respect, because the entry is there, but no colour.

Edit: Sent you a PM

[Terisa de morgan]

Originally Posted by thiago.eec

Sure! I'll wait for you to send it before releasing the new version fixing @Wiggo's problem.

I've shared the files with you.

[thiago.eec]

Originally Posted by ownedbycats

A strange behaviour that I've been wondering is intended...

First, every book must have at least one record. So, when you add a book to your goal, a record is set (in your case, a 0% record).

Now, you must understand that the main entry for the book is constantly updated with the latest metadata. This is not a 'record' per se. If you delete all records, the main entry still have the current values from your calibre library.

When you delete the 0% record, it is in fact deleted. But, since you cannot have zero records, a new record will be created with the current value the next time you interact with the plugin. If you don't want a 0% record, you can add the book and wait to delete the 0% record on your next update.

Since I want a 0% record (so my reading speed is correctly calculated), this is how I do it:

1) I add the book to my goal with 0% (the date doesn't matter);
2) Then, when I start reading, I update the date
3) Open the Edit Reading Goal dialog and delete the old entry
4) Then, I open again the Edit dialog, so a new updated record is created
5) The next day, let's say I read 20% and update it

Now, I have a dated 0% record marking my start and a 20% record the next day.

P.S.: Now that you mentioned, I think step 4 could be eliminated by adjusting the code to created the new record immediately, when all records have been deleted.

Originally Posted by Wiggo

Didn't work.

Strange in that respect, because the entry is there, but no colour.

Edit: Sent you a PM

Now I see the problem. The plugin is using the color only for the current year, but no for past years. I'll fix it.

Originally Posted by Terisa de morgan

I've shared the files with you.

Thank you Terisa. I'll add it on the next update.

[ownedbycats]

Originally Posted by thiago.eec

Since I want a 0% record (so my reading speed is correctly calculated), this is how I do it:

1) I add the book to my goal with 0% (the date doesn't matter);
2) Then, when I start reading, I update the date
3) Open the Edit Reading Goal dialog and delete the old entry
4) Then, I open again the Edit dialog, so a new updated record is created
5) The next day, let's say I read 20% and update it

Now, I have a dated 0% record marking my start and a 20% record the next day.

Yeah, I want a dated 0% record. I add the book to the goal with an empty date and then add it when I'm about to start reading.

I followed your instructions and it worked

[Wiggo]

Originally Posted by thiago.eec

Now I see the problem. The plugin is using the color only for the current year, but no for past years. I'll fix it.

And once again many thanks.

[thiago.eec]

Version 1.6.7 - 23 Sep 2024

- Bug fix: ensure the 'Keep Rereading color' option works for past years too
- Bug fix: when deleting the last record, create a new updated one immediately, instead of waiting for the next interaction
- Updated ES translation