[GUI Plugin] Reading Goal

[rantanplan]

Did you, by any chance, start a new book with 0% progress?

[ownedbycats]

All my reading goal books start out at 0%, but those records don't have any dates.

[thiago.eec]

Originally Posted by ownedbycats

Got an error trying to open Edit Goal:

ERROR: Unhandled exception: <b>ZeroDivisionError</b>:division by zero

It doesn't occur when I reinstall the test version from #447.

The only way I can imagine this happening is to have the last record set to an earlier date then the first record. Empty dates don't cause an error.

Anyway, try the version attached to see if it fixes the problem.

[ownedbycats]

I guess it's possible that one of my book logs got screwed up somehow, not sure how to identify the specific book. The new version does fix it though!

[ownedbycats]

One of my books, the individual reading speed seems to be stuck at 25.0 pages/day, even after adding new records. Other book entries their speed changes when I update them.

    "1801": {
      "authors": [
        "Richard Adams"
      ],
      "challenges": [
        "Annual"
      ],
      "date": {
        "__class__": "datetime.datetime",
        "__value__": "2024-05-25T07:03:38.546964+00:00"
      },
      "genre": [
        "Physical Books.Fiction"
      ],
      "last_year_pages": 0,
      "page_count": 478,
      "read_pages": 249,
      "records": {
        "0": {
          "date": null,
          "read_pages": 0,
          "status": 0
        },
        "1": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-20T02:20:29.059778+00:00"
          },
          "read_pages": 29,
          "status": 6
        },
        "10": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-22T23:26:47.907649+00:00"
          },
          "read_pages": 134,
          "status": 28
        },
        "11": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-23T01:37:50.672731+00:00"
          },
          "read_pages": 148,
          "status": 31
        },
        "12": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-23T05:01:15.516423+00:00"
          },
          "read_pages": 158,
          "status": 33
        },
        "13": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-23T19:47:05.273696+00:00"
          },
          "read_pages": 167,
          "status": 35
        },
        "14": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-24T00:21:26.098232+00:00"
          },
          "read_pages": 186,
          "status": 39
        },
        "15": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-24T04:17:47.145538+00:00"
          },
          "read_pages": 206,
          "status": 43
        },
        "16": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-24T17:54:31.119463+00:00"
          },
          "read_pages": 215,
          "status": 45
        },
        "17": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-24T21:42:41.506507+00:00"
          },
          "read_pages": 234,
          "status": 49
        },
        "18": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-25T01:01:28.508090+00:00"
          },
          "read_pages": 239,
          "status": 50
        },
        "19": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-25T07:03:38.546964+00:00"
          },
          "read_pages": 249,
          "status": 52
        },
        "2": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-20T06:40:16.377385+00:00"
          },
          "read_pages": 38,
          "status": 8
        },
        "3": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-20T19:51:24.807883+00:00"
          },
          "read_pages": 57,
          "status": 12
        },
        "4": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-21T00:33:16.842925+00:00"
          },
          "read_pages": 67,
          "status": 14
        },
        "5": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-21T05:00:28.927299+00:00"
          },
          "read_pages": 81,
          "status": 17
        },
        "6": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-21T17:00:47.609068+00:00"
          },
          "read_pages": 86,
          "status": 18
        },
        "7": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-21T20:20:24.748048+00:00"
          },
          "read_pages": 100,
          "status": 21
        },
        "8": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-22T02:45:55.936252+00:00"
          },
          "read_pages": 115,
          "status": 24
        },
        "9": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2024-05-22T07:32:12.513985+00:00"
          },
          "read_pages": 129,
          "status": 27
        }
      },
      "reread_count": 3,
      "shelf": "Rereading",
      "status": 52,
      "title": "Watership Down",
      "title_sort": "Watership Down"
    },

The only thing unusual I can think of is the previous re-reads all having a single 100% record. Is there any idea why the speed doesn't change?

[thiago.eec]

My mistake. The JSON dict is unordered* and I forgot to sort the records before calculating.
I'll release a fix in a couple of minutes.

* Actually, it is ordered, but the book ids are treated as strings, so instead of (1, 2, 3, ..., 9, 10, 11, 12, ..., 19, 20, 21), you get (1, 10, 11, 12, ..., 19, 2, 20, 21, 3, 4 ..., 9). So we need to reorder it treating the keys as integers.

[thiago.eec]

Version 1.5.8 - 25 May 2024

- Bug fix: Speed tooltip: Sort book records before calculating reading speed

[ownedbycats]

That fixed it! I now get 31.4 pages a day.

Is it possible this could also have something to do with the error described in #453? I know I have at least one book where records 0 and 1 got deleted.

[thiago.eec]

Originally Posted by ownedbycats

That fixed it! I now get 31.4 pages a day.

Is it possible this could also have something to do with the error described in #453? I know I have at least one book where records 0 and 1 got deleted.

No. Those were two different problems.

The first case is probably what I said and you have a date typo or something. It calculates how many days since first and last record, and in case the last day is just one day earlier than the first, then you get a result of zero, and the speed can't be calculated, throwing the division by zero error.

The second one was just a sorting problem, like I explained.

Both are taking care of.