[GUI Plugin] Reading Goal

[ownedbycats]

Yeah, I thought it was something to do with it being <1 days till January 1st.

[ownedbycats]

'Migrate unfinished books' appears to be failing. 2024 here, I have a single currently-reading book from 2023. I get this error when trying to open edit or statistics.

calibre, version 7.2.0
ERROR: Unhandled exception: <b>KeyError</b>:'summary'

calibre 7.2  embedded-python: True
Windows-10-10.0.19045-SP0 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.19045')
Python 3.11.5
Windows: ('10', '10.0.19045', 'SP0', 'Multiprocessor Free')
Interface language: None
Successfully initialized third party plugins: DeACSM (0, 0, 16) && Gather KFX-ZIP (from KFX Input) (2, 7, 0) && DeDRM (10, 0, 9) && Package KFX (from KFX Input) (2, 7, 0) && Action Chains (1, 18, 20) && Baen (1, 1, 0) && Barnes & Noble (1, 5, 2) && CalibreSpy (1, 0, 92) && Comments Cleaner (1, 12, 0) && Count Pages (1, 13, 4) && Embed Comic Metadata (1, 6, 6) && EpubCheck (0, 2, 5) && EpubMerge (2, 17, 0) && EpubSplit (3, 6, 0) && Extract ISBN (1, 6, 0) && FanFicFare (4, 30, 0) && Fantastic Fiction (1, 6, 4) && Favourites Menu (1, 3, 0) && Find Duplicates (1, 10, 8) && Generate Cover (2, 3, 3) && GetFileName (0, 2, 0) && Goodreads (1, 7, 9) && Import List (1, 9, 1) && Job Spy (1, 0, 239) && KFX metadata reader (from KFX Input) (2, 7, 0) && From KFX (2, 7, 0) && KFX Input (2, 7, 0) && Kindle hi-res covers (0, 5, 0) && KindleUnpack - The Plugin (0, 83, 1) && Kobo Books (1, 9, 2) && Kobo Utilities (2, 16, 13) && KoboTouchExtended (3, 6, 7) && Last Modified (0, 8, 5) && Manage Series (1, 5, 1) && Modify ePub (1, 8, 2) && MultiColumnSearch (1, 0, 96) && Obok DeDRM (7, 2, 1) && Open With (1, 8, 1) && Overdrive Link (2, 57, 0) && Quality Check (1, 13, 6) && Reading Goal (1, 2, 3) && Reading List (1, 15, 1) && Search The Internet (1, 10, 4) && SmartEject (2, 5, 0) && Standard Ebooks (1, 0, 0) && Sum Column (0, 3, 3) && View Manager (1, 10, 2) && Walk Search History (1, 5, 3) && Overdrive Link Metadata Source (2, 57, 0)
Traceback (most recent call last):
  File "calibre_plugins.Reading_Goal.main", line 173, in manage_reading_goal
  File "calibre_plugins.Reading_Goal.main", line 815, in update_database
  File "calibre_plugins.Reading_Goal.main", line 438, in add_to_goal
  File "calibre_plugins.Reading_Goal.main", line 913, in update_summary
KeyError: 'summary'

EDIT: Oddly, error occurs even if I turn off the 'migrate' setting.

[Terisa de morgan]

I still have the error about division by zero (that's what happens when you finish a book the last day of the year ). And migration has worked for me... in a way. Books have been copied from 2023 to 2024, and I have had to remove them manually from 2023. I guess that, when you finish a book, it's removed from both years, but I'm not going to test it (I've already removed 2023 entries).

[thiago.eec]

Version 1.2.4 - 01 Jan 2024

- Fix for rereading count: only count books already started (reading progress > 0%)
- Fix for empty Summary after migrating books from last year
- Fix for auto migrate: delete existing challenges and make 'last_year_pages' to be changed only for the new year
- Fix for 'Division by zero' error in Statistics

[ownedbycats]

That mostly fixed it.

I did have to change the book's #lastread to 2024 or I got an error about it not matching the year, but it migrated (though it shows in the 2024 goal as rereading, which is a bit odd to me). Attempting to delete the book from 2023 deleted it in both years, I took a backup before trying this thankfully.

Unfortunately, I'm still getting a division-by-zero error on Statistics. I finished a book on 2023-12-31.

calibre, version 7.2.0
ERROR: Unhandled exception: <b>ZeroDivisionError</b>:division by zero

calibre 7.2  embedded-python: True
Windows-10-10.0.19045-SP0 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.19045')
Python 3.11.5
Windows: ('10', '10.0.19045', 'SP0', 'Multiprocessor Free')
Interface language: None
Successfully initialized third party plugins: DeACSM (0, 0, 16) && Gather KFX-ZIP (from KFX Input) (2, 7, 0) && DeDRM (10, 0, 9) && Package KFX (from KFX Input) (2, 7, 0) && Action Chains (1, 18, 20) && Baen (1, 1, 0) && Barnes & Noble (1, 5, 2) && CalibreSpy (1, 0, 92) && Comments Cleaner (1, 12, 0) && Count Pages (1, 13, 4) && Embed Comic Metadata (1, 6, 6) && EpubCheck (0, 2, 5) && EpubMerge (2, 17, 0) && EpubSplit (3, 6, 0) && Extract ISBN (1, 6, 0) && FanFicFare (4, 30, 0) && Fantastic Fiction (1, 6, 4) && Favourites Menu (1, 3, 0) && Find Duplicates (1, 10, 8) && Generate Cover (2, 3, 3) && GetFileName (0, 2, 0) && Goodreads (1, 7, 9) && Import List (1, 9, 1) && Job Spy (1, 0, 239) && KFX metadata reader (from KFX Input) (2, 7, 0) && From KFX (2, 7, 0) && KFX Input (2, 7, 0) && Kindle hi-res covers (0, 5, 0) && KindleUnpack - The Plugin (0, 83, 1) && Kobo Books (1, 9, 2) && Kobo Utilities (2, 16, 13) && KoboTouchExtended (3, 6, 7) && Last Modified (0, 8, 5) && Manage Series (1, 5, 1) && Modify ePub (1, 8, 2) && MultiColumnSearch (1, 0, 96) && Obok DeDRM (7, 2, 1) && Open With (1, 8, 1) && Overdrive Link (2, 57, 0) && Quality Check (1, 13, 6) && Reading Goal (1, 2, 4) && Reading List (1, 15, 1) && Search The Internet (1, 10, 4) && SmartEject (2, 5, 0) && Standard Ebooks (1, 0, 0) && Sum Column (0, 3, 3) && View Manager (1, 10, 2) && Walk Search History (1, 5, 3) && Overdrive Link Metadata Source (2, 57, 0)
Traceback (most recent call last):
  File "calibre_plugins.Reading_Goal.main", line 217, in manage_reading_goal
  File "calibre_plugins.Reading_Goal.main", line 2800, in statistics_main
  File "calibre_plugins.Reading_Goal.main", line 2704, in statistics_tree
ZeroDivisionError: division by zero

[thiago.eec]

Originally Posted by ownedbycats

'Migrate unfinished books' appears to be failing. 2024 here, I have a single currently-reading book from 2023. I get this error when trying to open edit or statistics.

This is fixed now. Check out the new release.

Originally Posted by ownedbycats

EDIT: Oddly, error occurs even if I turn off the 'migrate' setting.

The migration process occurs the first time you interact with the plugin after a year change. So, changing the setting after this will have no effect, since the migration already happened.

Originally Posted by Terisa de morgan

I still have the error about division by zero (that's what happens when you finish a book the last day of the year ).

Check the new version I just released. This is supposed to be fixed now.

Originally Posted by Terisa de morgan

And migration has worked for me... in a way. Books have been copied from 2023 to 2024, and I have had to remove them manually from 2023.

Why? That's not really necessary. Suppose you read 200 pages out of 350. Your 2023's statistics will count only 200 pages. Your 2024's statistics will start at 0 pages, and then add the remaining 150 when you finish the book.

Originally Posted by Terisa de morgan

I guess that, when you finish a book, it's removed from both years, but I'm not going to test it (I've already removed 2023 entries).

No. The plugin never change any information in your past years.

[Terisa de morgan]

Originally Posted by ownedbycats

That mostly fixed it.

I did have to change the book's #lastread to 2024 or I got an error about it not matching the year, but it migrated (though it shows in the 2024 goal as rereading, which is a bit odd to me). Attempting to delete the book from 2023 deleted it in both years, I took a backup before trying this thankfully.

Unfortunately, I'm still getting a division-by-zero error on Statistics. I finished a book on 2023-12-31.

calibre, version 7.2.0
ERROR: Unhandled exception: <b>ZeroDivisionError</b>:division by zero

calibre 7.2  embedded-python: True
Windows-10-10.0.19045-SP0 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.19045')
Python 3.11.5
Windows: ('10', '10.0.19045', 'SP0', 'Multiprocessor Free')
Interface language: None
Successfully initialized third party plugins: DeACSM (0, 0, 16) && Gather KFX-ZIP (from KFX Input) (2, 7, 0) && DeDRM (10, 0, 9) && Package KFX (from KFX Input) (2, 7, 0) && Action Chains (1, 18, 20) && Baen (1, 1, 0) && Barnes & Noble (1, 5, 2) && CalibreSpy (1, 0, 92) && Comments Cleaner (1, 12, 0) && Count Pages (1, 13, 4) && Embed Comic Metadata (1, 6, 6) && EpubCheck (0, 2, 5) && EpubMerge (2, 17, 0) && EpubSplit (3, 6, 0) && Extract ISBN (1, 6, 0) && FanFicFare (4, 30, 0) && Fantastic Fiction (1, 6, 4) && Favourites Menu (1, 3, 0) && Find Duplicates (1, 10, 8) && Generate Cover (2, 3, 3) && GetFileName (0, 2, 0) && Goodreads (1, 7, 9) && Import List (1, 9, 1) && Job Spy (1, 0, 239) && KFX metadata reader (from KFX Input) (2, 7, 0) && From KFX (2, 7, 0) && KFX Input (2, 7, 0) && Kindle hi-res covers (0, 5, 0) && KindleUnpack - The Plugin (0, 83, 1) && Kobo Books (1, 9, 2) && Kobo Utilities (2, 16, 13) && KoboTouchExtended (3, 6, 7) && Last Modified (0, 8, 5) && Manage Series (1, 5, 1) && Modify ePub (1, 8, 2) && MultiColumnSearch (1, 0, 96) && Obok DeDRM (7, 2, 1) && Open With (1, 8, 1) && Overdrive Link (2, 57, 0) && Quality Check (1, 13, 6) && Reading Goal (1, 2, 4) && Reading List (1, 15, 1) && Search The Internet (1, 10, 4) && SmartEject (2, 5, 0) && Standard Ebooks (1, 0, 0) && Sum Column (0, 3, 3) && View Manager (1, 10, 2) && Walk Search History (1, 5, 3) && Overdrive Link Metadata Source (2, 57, 0)
Traceback (most recent call last):
  File "calibre_plugins.Reading_Goal.main", line 217, in manage_reading_goal
  File "calibre_plugins.Reading_Goal.main", line 2800, in statistics_main
  File "calibre_plugins.Reading_Goal.main", line 2704, in statistics_tree
ZeroDivisionError: division by zero

Same error here... and book finished at 2023-12-31 too.

[thiago.eec]

Originally Posted by ownedbycats

That mostly fixed it.

I did have to change the book's #lastread to 2024 or I got an error about it not matching the year, but it migrated (though it shows in the 2024 goal as rereading, which is a bit odd to me).

Yeah, you need to change the date manually, since the plugin never change your calibre library.
About the rereading, I'm not sure how to proceed. This happens only for books you started, but did not finish before migrating. Books with 0% will not have this problem.
The only way I can think of is to consider a rereading only if the book reached 100% in the past year. Not ideal, but maybe a better solution.

Originally Posted by ownedbycats

Attempting to delete the book from 2023 deleted it in both years, I took a backup before trying this thankfully.

Can you give me steps to reproduce?

Originally Posted by ownedbycats

Unfortunately, I'm still getting a division-by-zero error on Statistics. I finished a book on 2023-12-31.

That's weird. I also have a book finished in 2023-12-31 and have no problem. Could you please send me your database file?

[thiago.eec]

Originally Posted by Terisa de morgan

Same error here... and book finished at 2023-12-31 too.

The error happens when you open the statistics dialog or when you change to 2023 using the dropdown?

[Terisa de morgan]

Originally Posted by thiago.eec

The error happens when you open the statistics dialog or when you change to 2023 using the dropdown?

When I try to open the statistics dialog.

[ownedbycats]

Originally Posted by thiago.eec

Can you give me steps to reproduce?

Steps to reproduce:

1. Have a currently-reading book migrated from 2023 > 2024.

2. Open Edit Reading Goal. The book will appear as Reading in 2023 and Rereading in 2024. Both will have a full set of records.

3. In 2023, click the book record and Remove from Reading Goal. Then apply. This removes it from both years.

That's weird. I also have a book finished in 2023-12-31 and have no problem. Could you please send me your database file?

Attached. Look for book id 5999.

[thiago.eec]

Originally Posted by Terisa de morgan

When I try to open the statistics dialog.

Can you please send me your database file? I'll try to reproduce here.

I don't think the book finished in 2023-12-31 is the problem, because when you open the Statistics dialog, the year is 2024, so a 2023 book can't cause any problem.

If it happened when changing from 2024 to 2023, then it could be case.

Originally Posted by ownedbycats

Steps to reproduce:

1. Have a currently-reading book migrated from 2023 > 2024.

2. Open Edit Reading Goal. The book will appear as Reading in 2023 and Rereading in 2024. Both will have a full set of records.

3. In 2023, click the book record and Remove from Reading Goal. Then apply. This removes it from both years.

Attached. Look for book id 5999.

I could not reproduce here with your database or mine. When I delete it from 2023's goal, it still remains on the 2024's. Can you try repeating the process with your backup and see if it happens again?

P.S.: The book id I found is 7753, not 5999.

[ownedbycats]

Originally Posted by thiago.eec

I could not reproduce here with your database or mine. When I delete it from 2023's goal, it still remains on the 2024's. Can you try repeating the process with your backup and see if it happens again?

P.S.: The book id I found is 7753, not 5999.

The book I finished on 2023-12-31, which I suspected of causing the division-by-zero error, is 5999.

The 7753 deletion issue I was able to replicate a second time after restoring my backup.

It's possible the division error could be caused by the migration?

[Terisa de morgan]

Originally Posted by thiago.eec

Can you please send me your database file? I'll try to reproduce here.

I've already sent you the link to the file, thank you very much (it happened before changing from 2023 to 2024 too).

[Terisa de morgan]

BTW, Thiago, I think the problem is today is the first day of the year, so calculating the current speed is not going well. I'll be back to you tomorrow to confirm it.