[GUI Plugin] FanFicFare

[apm]

Hi, I'm having an issue where FFF is only downloading the first two chapters of a ten-chapter story. I think it's related to the author changing the name of the story after those two chapters.

Update: Working from the CLI, it works fine, so just an issue with the plugin version it seems.

[mrEd]

SOL is broken again. Only the chapter index page is being downloaded.

[JimmXinu]

Originally Posted by apm

Hi, I'm having an issue where FFF is only downloading the first two chapters of a ten-chapter story. I think it's related to the author changing the name of the story after those two chapters.

Moderator Notice
NSFW links removed by Mod--please don't post NSFW links on MobileRead. You can use PM instead.

If I put in any of the later URLs, it still only downloads chapters 1-2.

Originally Posted by apm

Update: Working from the CLI, it works fine, so just an issue with the plugin version it seems.

This is a known issue that, IMO, is a site bug. See this post last month.

Originally Posted by mrEd

SOL is broken again. Only the chapter index page is being downloaded.

See Issue #1013.

[JimmXinu]

New Test Version Posted

2023-11-19
- adapter_storiesonlinenet: Update for chapter URL change. See #1013

Note that this change invalidates the existing chapter URLs in existing EPUBs.

When you update an existing EPUB, FFF will download all chapters again because the chapter URLs in existing EPUB chapters won't match what the site now shows. See #1013 for full details.

[JimmXinu]

New Test Version Posted

2023-11-19
- adapter_storiesonlinenet: Update for chapter URL change. See #1013
- adapter_fanfictionnet: Only use data-original cover images.

Originally Posted by JimmXinu

The code says it only loads the author page if there's a cover URL found and both skip_author_cover and include_images are true. Without an example, I assume either a bad image URL, or the site hiding the <img> tag with CSS.

Looking at this in more depth, it appears that ffnet no longer ever uses cover images that aren't defined with 'data-original' (ie, you can click and see a slightly larger version) and always sets src="/static/images/d_60_90.jpg" now.

So we're ignoring any cover image tag that doesn't have data-original.

[ownedbycats]

Thank you!

[mrEd]

Thanks

[bpothier]

The initial fix for issue 1013 breaks for paid SOL users with error:
line 550, in getChapterText
AttributeError: 'NoneType' object has no attribute 'find'

and

Error https://storiesonline.net/s/00001/this-is-a-test 'NoneType' object has no attribute 'find'

Paid users get 2 links per chapter within the same list. The "download chapter" link use format URL like "/library/download.php?id=xxxxxx" and the URL links of format "/s/00001/this-is-a-test/1"

submitted new pull request to only grab URLs containing "/s/".

[JimmXinu]

New Test Version Posted

2023-11-20
- adapter_storiesonlinenet: Update for chapter URL change for paid subs. See #1014, thanks bpothier!

[mrEd]

Another issue with some SOL stories, They're using /n/ instead of /s/ for some stories, which gives a bad story url error.

Using the python CLI and changing n to s, it downloads but still does the thing of only putting links in the book, with no chapters. Version 4.29.4

Example URL:
n/25243/variation-on-a-theme-book-5

[mrEd]

Very quick fix for the latest test version of the plugin:

Change line 90 of adapter_storiesonlinenet.py to

return r"https?://"+re.escape(self.getSiteDomain())+r"/(s|n|library)/(storyInfo.php\?id=)?(?P<id>\d+)(?P<chapter>:\d+)?(?P<title>/.+)?((;\d+)?$|(:i)?$)?"

Under line 225, add this:

chapters += soup.select('div#index-list a[href*="/n/"]')

There's a whole load of other places where it's looking for /s/, but this at least gets the chapters read correctly.

[JimmXinu]

Originally Posted by mrEd

Very quick fix for the latest test version of the plugin:

That will also break it for /s/ stories.

If you wait a little while, I have a fix; but also I'm looking at another problem to potentially include in the next test version.

[mrEd]

Just tested, working fine on /s/ stories as well.

Just looked at the code posted, second part should have been +=, not just equals. Will edit now.

[JimmXinu]

New Test Version Posted

2023-11-20
- adapter_storiesonlinenet: Allow /n/ as well as /s/ paths
- adapter_storiesonlinenet: Update for chapter URL change for paid subs. See #1014, thanks bpothier!

[Da Man]

Is it right that I have to redownload the complete fic to get chapters that got updated? It would be nice if FFF could detect updated chapters to prevent having to do that, especially from FFN.