PageEdit-2.0.0 Released - Page 6

KevinH · 10-13-2023, 07:47 PM

FWIW, Sigil is a Qt app and testing has already shown that copying a table out of Sigil's Preview and pasting it in PageEdit works. My guess is it will work for other Qt apps like the qutebrowser, the Qt SimpleBrowser, and cross platform browsers like KDE/Falkon browsers and the Kate text editor that is Qt as well.

BetterRed · 10-13-2023, 08:11 PM

Kevin, I've doffed my fedora and donned my periwig - in other words I'm being devil's advocate.

IMO someone should draw this thread to the attention of Kovid.

FTR: I see was wrong, it wasn't the markdown changes that threw a spanner into the works, it was a minor glitch with text alignment not being copied. That explains why I had to go back to 6.14.1 rather than 6.16, which was bothering me.

I'll but out now.

BR

KevinH · 10-13-2023, 10:02 PM

As I said, if pasting a table in PageEdit from common major apps like Word, LibreOffice, Edge, FireFox, Chrome has problems and the problem is similar to calibre, I would be happy to try a workaround.

As for Kovid, feel free to direct him to this thread. He will understand his code changes and should be able to say if it causes the removal of the html and body tags from the clipboard html code. All I have is a guess as to the cause based on the last working version to first non-working version change log.

KevinH · 10-14-2023, 11:13 AM

After doing some more searching and reading of Qtwebengine code, I filed the following qtbug report:

https://bugreports.qt.io/browse/QTBUG-118121

Hopefully future pasting in QtWebEngine will be made more robust.

KevinH · 10-15-2023, 02:52 PM

There is also a possibility of adding a Windows specific patch to QtWebEngine's clipboard code to fix this issue. But it probably won't come in the next release unless DiapDealer has the time to rebuild Qt 6.5.3 and simeone is willing to test if it works.

DiapDealer · 10-15-2023, 05:24 PM

Quote:

Originally Posted by KevinH

There is also a possibility of adding a Windows specific patch to QtWebEngine's clipboard code to fix this issue. But it probably won't come in the next release unless DiapDealer has the time to rebuild Qt 6.5.3 and simeone is willing to test if it works.

That would be a pretty-tough sell before the next release.

It only manifests on a fairly unique workflow (that already seems to have solid workarounds). I'd also hate to wait on a 6 hour Qt build only to find that the patch required more tweaking.

KevinH · 10-15-2023, 05:30 PM

That makes sense.

DiapDealer · 10-15-2023, 06:28 PM

I guess it would technically only be around 5 hours. I could build QtWebEngine independently, but that wouldn't save much time. The rest of Qt builds in a little over an hour. WebEngine takes the remaining 5!

KevinH · 10-15-2023, 08:13 PM

@BetterRed
When you get a free moment (no rush at all), would you try downloading a new debug build of PageEdit, setting the env var for debug.txt creation, and try copying a table out of calibre metadata and pasting it into PageEdit with its Edit->Paste menu and saying "No".

I have included new debug output and a potential workaround.

I am hoping the workaround will allow things to work but either way the debug output will confirm if this really is a Qt bug.

The new debug build with potential workaround can be found here:

https://github.com/kevinhendricks/Bu...OnMac/releases

And like before it is named pageedit-installer.zip

Please start with an empty debug.txt file in case the old one is still lying around.

Thanks!

BetterRed · 10-16-2023, 02:24 AM

Quote:

Originally Posted by KevinH

@BetterRed
When you get a free moment (no rush at all), would you try downloading a new debug build of PageEdit, setting the env var for debug.txt creation, and try copying a table out of calibre metadata and pasting it into PageEdit with its Edit->Paste menu and saying "No".

I have included new debug output and a potential workaround.

I am hoping the workaround will allow things to work but either way the debug output will confirm if this really is a Qt bug.

The new debug build with potential workaround can be found here:

https://github.com/kevinhendricks/Bu...OnMac/releases

And like before it is named pageedit-installer.zip

Please start with an empty debug.txt file in case the old one is still lying around.

Thanks!

works for me.

log attached

Hopefully it'll work for Leonatus too.

BR

Leonatus · 10-16-2023, 03:10 AM

Thank you so much for your work!
Alas, I have no experience with debug workarounds. Is there a new version of PageEdit to come?

BetterRed · 10-16-2023, 05:26 AM

Quote:

Originally Posted by Leonatus

Thank you so much for your work!
Alas, I have no experience with debug workarounds. Is there a new version of PageEdit to come?

Go to the link in Kevin's last post, download the file:

Code:

pageedit-installer.zip

Unzip it and install

Code:

PageEdit-2.0.2-Windows-x64-Setup.exe

Run it from Sigil as you normally do

Copy your Annotations table from calibre to the clipboard

You must paste the clipboard into PageEdit via the Edit->Paste menu item, you'll get this popup:

Click image for larger version

Name: Screenshot 2023-10-16 200933.jpg
Views: 952
Size: 21.5 KB
ID: 204306

Click No and you should get a table.

If you don't, Kevin or I will walk you through getting a log.

If you get a table, it's over to the devs to create a release. Meantime you can reinstall the old version you've been using.

Good luck - BR ��

Leonatus · 10-16-2023, 06:54 AM

It works! Great! Thank you for your guidance!
I think this issue is fixed so far and can be closed.
Once more, so many thanks!

KevinH · 10-16-2023, 08:03 AM

Great news! So the problem is a real QtWebEngine bug, and adding back the technically non-required (according to the win cf_html spec) context (html and body tag pairs) allows it to work.

We can keep this workaround fix in the next release until a real fix comes in Qt.

KevinH · 10-16-2023, 08:12 AM

Unfortunately, the workaround only works when using the Edit->Paste menu as using the shortcuts to paste uses a direct path to the QWebEngineView/Page that I can not intercept to add in the workaround code needed.

Hopefully, Qt will create an official fix for this that works on all ways of doing a paste.

10-13-2023, 08:11 PM	#77
BetterRed null operator (he/him) Posts: 21,777 Karma: 30237628 Join Date: Mar 2012 Location: Sydney Australia Device: none	Kevin, I've doffed my fedora and donned my periwig - in other words I'm being devil's advocate. IMO someone should draw this thread to the attention of Kovid. FTR: I see was wrong, it wasn't the markdown changes that threw a spanner into the works, it was a minor glitch with text alignment not being copied. That explains why I had to go back to 6.14.1 rather than 6.16, which was bothering me. I'll but out now. BR Last edited by BetterRed; 10-13-2023 at 08:14 PM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
PageEdit-1.7.0 Released	DiapDealer	Sigil	1	07-22-2021 11:44 AM
PageEdit-1.5.0 Released	DiapDealer	Sigil	1	03-19-2021 10:59 AM
PageEdit-1.3.0 Released	DiapDealer	Sigil	26	08-19-2020 04:22 PM
PageEdit-1.2.0 Released	DiapDealer	Sigil	13	04-02-2020 04:16 AM
PageEdit-0.9.6 Released	DiapDealer	Sigil	22	01-30-2020 09:00 PM

10-13-2023, 07:47 PM	#76
KevinH Sigil Developer Posts: 8,847 Karma: 6120478 Join Date: Nov 2009 Device: many	FWIW, Sigil is a Qt app and testing has already shown that copying a table out of Sigil's Preview and pasting it in PageEdit works. My guess is it will work for other Qt apps like the qutebrowser, the Qt SimpleBrowser, and cross platform browsers like KDE/Falkon browsers and the Kate text editor that is Qt as well.

10-13-2023, 10:02 PM	#78
KevinH Sigil Developer Posts: 8,847 Karma: 6120478 Join Date: Nov 2009 Device: many	As I said, if pasting a table in PageEdit from common major apps like Word, LibreOffice, Edge, FireFox, Chrome has problems and the problem is similar to calibre, I would be happy to try a workaround. As for Kovid, feel free to direct him to this thread. He will understand his code changes and should be able to say if it causes the removal of the html and body tags from the clipboard html code. All I have is a guess as to the cause based on the last working version to first non-working version change log.

10-14-2023, 11:13 AM	#79
KevinH Sigil Developer Posts: 8,847 Karma: 6120478 Join Date: Nov 2009 Device: many	After doing some more searching and reading of Qtwebengine code, I filed the following qtbug report: https://bugreports.qt.io/browse/QTBUG-118121 Hopefully future pasting in QtWebEngine will be made more robust.

10-15-2023, 02:52 PM	#80
KevinH Sigil Developer Posts: 8,847 Karma: 6120478 Join Date: Nov 2009 Device: many	There is also a possibility of adding a Windows specific patch to QtWebEngine's clipboard code to fix this issue. But it probably won't come in the next release unless DiapDealer has the time to rebuild Qt 6.5.3 and simeone is willing to test if it works.

10-15-2023, 05:30 PM	#82
KevinH Sigil Developer Posts: 8,847 Karma: 6120478 Join Date: Nov 2009 Device: many	That makes sense.

10-15-2023, 06:28 PM	#83
DiapDealer Grand Sorcerer Posts: 28,646 Karma: 204624552 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	I guess it would technically only be around 5 hours. I could build QtWebEngine independently, but that wouldn't save much time. The rest of Qt builds in a little over an hour. WebEngine takes the remaining 5!

10-15-2023, 08:13 PM	#84
KevinH Sigil Developer Posts: 8,847 Karma: 6120478 Join Date: Nov 2009 Device: many	@BetterRed When you get a free moment (no rush at all), would you try downloading a new debug build of PageEdit, setting the env var for debug.txt creation, and try copying a table out of calibre metadata and pasting it into PageEdit with its Edit->Paste menu and saying "No". I have included new debug output and a potential workaround. I am hoping the workaround will allow things to work but either way the debug output will confirm if this really is a Qt bug. The new debug build with potential workaround can be found here: https://github.com/kevinhendricks/Bu...OnMac/releases And like before it is named pageedit-installer.zip Please start with an empty debug.txt file in case the old one is still lying around. Thanks!

10-16-2023, 03:10 AM	#86
Leonatus Wizard Posts: 1,060 Karma: 11391181 Join Date: Mar 2013 Location: Guben, Brandenburg, Germany Device: Kobo Clara 2E, Tolino Shine 3	Thank you so much for your work! Alas, I have no experience with debug workarounds. Is there a new version of PageEdit to come?

10-16-2023, 06:54 AM	#88
Leonatus Wizard Posts: 1,060 Karma: 11391181 Join Date: Mar 2013 Location: Guben, Brandenburg, Germany Device: Kobo Clara 2E, Tolino Shine 3	It works! Great! Thank you for your guidance! I think this issue is fixed so far and can be closed. Once more, so many thanks!

10-16-2023, 08:03 AM	#89
KevinH Sigil Developer Posts: 8,847 Karma: 6120478 Join Date: Nov 2009 Device: many	Great news! So the problem is a real QtWebEngine bug, and adding back the technically non-required (according to the win cf_html spec) context (html and body tag pairs) allows it to work. We can keep this workaround fix in the next release until a real fix comes in Qt.

10-16-2023, 08:12 AM	#90
KevinH Sigil Developer Posts: 8,847 Karma: 6120478 Join Date: Nov 2009 Device: many	Unfortunately, the workaround only works when using the Edit->Paste menu as using the shortcuts to paste uses a direct path to the QWebEngineView/Page that I can not intercept to add in the workaround code needed. Hopefully, Qt will create an official fix for this that works on all ways of doing a paste.