[GUI Plugin] Reading Goal

[thiago.eec]

Originally Posted by ownedbycats

I see that now. Maybe change the dialog to indicate books are updated?

I'll take a look at that.

[ownedbycats]

How would I get rid of an empty genre? I'm not sure how this happened. I looked in the JSON and found the book it was associated with. I wonder why it didn't appear in Genre.

EDIT: Also, Statistics > By Genre > All doesn't seem to be working.

[thiago.eec]

Originally Posted by ownedbycats

How would I get rid of an empty genre? I'm not sure how this happened. I looked in the JSON and found the book it was associated with. I wonder why it didn't appear in Genre.

Hmmm... that's odd. The plugin parses all the books from that year and create a list of all genres. Then get the most read genres (12, IIRC) and create a graphic.

Please send the JSON, so I can figure out what is happening.

Originally Posted by ownedbycats

EDIT: Also, Statistics > By Genre > All doesn't seem to be working.

That's expected behavior. How could it show a genre view for each year? It would need some king of hierarchical graphic.

[Wiggo]

I think @obc means the top 12 genres for all years summary.
That would be really nice

[Comfy.n]

Originally Posted by thiago.eec

Hi!

You said you can't add books to past years. I can't reproduce it here with last version. Test the new version I'm about to release.

Also, you said can't remove books from past years. This functionality was not touched in recent updates. It works fine here (via 'Edit reading goal' dialog > Select the year > Select the books > Press the 'Remove' button or press 'Del' on the keyboard > Apply).

I use mostly the context menu for the books in the library, and I still get either the "No book was added" message box when adding books to past years or it just fails silently, i.e., it doesn't give any message but the selected book(s) aren't actually added.

As for removing, I can do it in the Edit Reading Goal window -> remove button, however if using the context menu, it gives me the message attached. I've also attached my configs.

[ownedbycats]

Originally Posted by thiago.eec

Hmmm... that's odd. The plugin parses all the books from that year and create a list of all genres. Then get the most read genres (12, IIRC) and create a graphic.

Please send the JSON, so I can figure out what is happening.

Will remove this once confirmed downloaded. Look for book id 6926.

[ownedbycats]

Originally Posted by Wiggo

I think @obc means the top 12 genres for all years summary.
That would be really nice

Yes, I was expecting something like that.

[thiago.eec]

Originally Posted by Wiggo

I think @obc means the top 12 genres for all years summary.
That would be really nice

Got it. I don't remember if there was a problem preventing this, but I'll check if it is possible.

Originally Posted by Comfy.n

I use mostly the context menu for the books in the library, and I still get either the "No book was added" message box when adding books to past years or it just fails silently, i.e., it doesn't give any message but the selected book(s) aren't actually added.

The no books added message means just no NEW books. I'll change that message, to be more descriptive. As for failing silently, I would need steps to reproduce. It doesn't happen here with the current version. One of the versions in 1.1.4, 1.1.5 and 1.1.6 may have this problem.

Originally Posted by Comfy.n

As for removing, I can do it in the Edit Reading Goal window -> remove button, however if using the context menu, it gives me the message attached. I've also attached my configs.

It's like I said before. The main menu actions (Add/remove to/from reading goal) are meant for the current year. If you hover it, you'll see the description at the status bar. Since the context menu actions are the same as the main menu, the result is the same. To remove from past years, you need to use the remove option from the 'Edit reading goal' dialog.

[Comfy.n]

Originally Posted by thiago.eec

The no books added message means just no NEW books. I'll change that message, to be more descriptive. As for failing silently, I would need steps to reproduce. It doesn't happen here with the current version. One of the versions in 1.1.4, 1.1.5 and 1.1.6 may have this problem.

I'm using 1.1.7... While attempting to log the steps in order to reproduce this on a clean slate, I just noticed this: I hit the clear database, got the confirmation message "All existing data will be permanently deleted. Do you want to proceed?", but the Edit Goal Window wouldn't update, as it would still show years 1990 and 2023, with no book records... Then after opening it again after some time, it was actually cleared

I'll do more tests in a bit

[Comfy.n]

This is on a clean slate in v1.1.7, after clearing the database: even 2023 records don't get added.

However if I install v. (1, 1, 0), it works fine

[thiago.eec]

Originally Posted by Comfy.n

... as it would still show years 1990 and 2023, with no book records... Then after opening it again after some time, it was actually cleared

Yes, the year menu is retaining the last database years. Although it's harmless, I'll fix it.

Originally Posted by Comfy.n

This is on a clean slate in v1.1.7, after clearing the database: even 2023 records don't get added.

It's a bug. Can't add a new book to a clean database when the 'Allow other years' is checked (if you uncheck, then you can add normally). I'm going to investigate this. I think this happened before and I fixed it. Maybe something got mixed here and the fix was lost.

But with an existing database, everything seems to work fine here.

[ownedbycats]

Suggestion, if it makes sense: When using the 'add to reading goal' menu option, an option to add a value to a column. I would use the same readinggoal:yyyy in #admintags that I use as the autoadd value.

Unexpected behaviour: If I open Edit Reading Goal, click one of the headers (Want to Read, etc), then Mark Selected Books, I get an empty marked:2023 search. I'd expect either it to mark all the 'want to read' books or to get an error.

[ownedbycats]

Originally Posted by thiago.eec

Version 1.1.7 - 17 Sep 2023

- Fix a remaining timezone issue for book records

This error happens trying to open records if any were added in this version (older ones are still okay)

calibre, version 6.26.0
ERROR: Unhandled exception: <b>AttributeError</b>:'NoneType' object has no attribute 'astimezone'

...
Traceback (most recent call last):
  File "calibre_plugins.Reading_Goal.main", line 2354, in handler
  File "calibre_plugins.Reading_Goal.main", line 2491, in show_records
AttributeError: 'NoneType' object has no attribute 'astimezone'

[thiago.eec]

Originally Posted by ownedbycats

I see that now. Maybe change the dialog to indicate books are updated?

Added an extra message if some books were just updated.

Originally Posted by ownedbycats

How would I get rid of an empty genre? I'm not sure how this happened. I looked in the JSON and found the book it was associated with. I wonder why it didn't appear in Genre.

The problem was that you have two identical 'tag leafs': 'Mystery' and 'Fiction.Mystery'. Also, you have the same* book listed twice (one in each tag). *Same title/author, but different page count
This is fixed now.

Originally Posted by ownedbycats

EDIT: Also, Statistics > By Genre > All doesn't seem to be working.

Fixed. It now shows the most read genres in all the years.

Originally Posted by Comfy.n

I'm using 1.1.7... While attempting to log the steps in order to reproduce this on a clean slate, I just noticed this: I hit the clear database, got the confirmation message "All existing data will be permanently deleted. Do you want to proceed?", but the Edit Goal Window wouldn't update, as it would still show years 1990 and 2023, with no book records... Then after opening it again after some time, it was actually cleared

Fixed.

Originally Posted by Comfy.n

This is on a clean slate in v1.1.7, after clearing the database: even 2023 records don't get added.

Fixed. As for your other problems, I will need the exact steps to reproduce, since I could not reproduce it here.

Originally Posted by ownedbycats

Suggestion, if it makes sense: When using the 'add to reading goal' menu option, an option to add a value to a column. I would use the same readinggoal:yyyy in #admintags that I use as the autoadd value.

I'll see what I can do.

Originally Posted by ownedbycats

Unexpected behaviour: If I open Edit Reading Goal, click one of the headers (Want to Read, etc), then Mark Selected Books, I get an empty marked:2023 search. I'd expect either it to mark all the 'want to read' books or to get an error.

Fixed. I was not sure how to proceed here: consider it an empty selection (like it happens for the other buttons), or let it mark all the books in that shelf. I ended up choosing the second approach. Although it may be a little inconsistent, this is just 'marking', so no change to the database.

Originally Posted by ownedbycats

This error happens trying to open records if any were added in this version (older ones are still okay)

'NoneType' object has no attribute 'astimezone'

I could not reproduce it here:
1) Add a new book to the current year (or other year)
2) Open the 'Edit reading goal' dialog
3) Click on the added book
4) Click on the 'Show records' button
5) Records are shown
6) Deleting records also works

Test the new version that will be released in a few moments and tell me if it still happens. If so, please give me the complete steps to reproduce.

[thiago.eec]

Version 1.1.8 - 18 Sep 2023

- Add to reading goal: Added an extra message if the books are already in the database, and they were just updated
- Add a genre view for the 'All' years option
- Fix for repeated genres in different levels (e.g.: 'Mystery' and 'Fiction.Mystery') no being correctly displayed
- Fix for adding books to an empty database when the 'Allow other years' option is checked (this was fixed before, but came back)
- Fix for 'Mark selected books' when clicking on the shelves' names. Now it marks all the books in that shelf.