Sigil-2.0.0 Released

[democrite]

Thank you very much Kevin. Confirmed crashing fixed.

[KevinH]

Great! It will be part of a 2.0.2 release.

[democrite]

very much looking forward to the new release as I also noticed the loss of focus on macOS and was gonna mention it. 🙏🏿

or perhaps you already have test build you're using and if it's not too trouble to publish a new one, that'd be much appreciated.

[KevinH]

A sigil-2.0.2 should be out soonish. We are just waiting to see if other bugs are reported first as we would like this release to last awhile. There is nothing new that we can not test and verify ourselves so no new test build is needed so far.

[DNSB]

Not sure if this is going to be any help but I've had Sigil 2.0.0 close several times and so downloaded the 2.0.1.0 build. It also gives me the same crashes. I suspect the output from Windows Event Viewer is not going to be that helpful. The crash seems to happen after I've been editing a file for a while.

[KevinH]

@DNSB,

We would love to track this down and get it fixed before releasing any 2.0.2.

Are there any commonalities as to what you are doing when the crashes happen? All that shows is the segfault in Qt Widgets someplace.

Have you by chance enabled any Accessibility tools of features on Windows?

Did you have any similar issues with Sigil-1.9.30?

I truly wish Windows had the built in feature to create an automatic bug report with full backtrace information like macOS has. The backtraces are so detailed that you can either see the problem cause or provides some idea of how to recreate it by showing the code path.

[DNSB]

I've only made notes for the last 3 times and basically, I was replacing bits of the stylesheet using Regex when it happened. But then that is about 80-90% of what I do when editing epubs.

I don't have any Windows accessibility tools enabled.

I had a similar issue with 1.9.3.0 but those were a lot rarer. Once 6-8 weeks and mostly on the first pass at fixing a garbaged epub.

I did have gpu acceleration disabled from an issue with calibre a month or so back but I think that is unlikely to contribute to the errors.

I do have WinDbg installed and will enable it to see if I get any useful results.

[KevinH]

Enabling Windows crashdump and/or obtaining a WinDbg backtrace of the crash would be very helpful.

Most Windows crashing issues according to Qt in Qt 6.5.2 can be tracked back to older graphics cards/drivers or poor angle/opengl software.
So it might be worth trying to re-enable gpu acceleration just for Sigil and see if that fixes the issue.

[KevinH]

@Vanguard3000, @theducks

Qt has officially fixed the two identical monitors with identical edid bug.

DiapDealer has nicely created a whole Sigil test build for Windows that incorporates the official Qt fix.

When you get a chance, would you please confirm that the official Qt fix works so that we can include it in place of our local fix in the next release.

The new Sigil installer can be downloaded from my personal repo here:

https://github.com/kevinhendricks/Bu...OnMac/releases


The file is called Sigil-2.0.1-Windows-x64-Setup.exe

Thanks!

Kevin

Originally Posted by Vanguard3000

Sorry for the wait - I have the day off and don't have much time at my PC. But good news - it works perfectly, at least at the glance I'm able to take.

Originally Posted by theducks

Patched
Thanks for Sigil and your efforts

[Vanguard3000]

Originally Posted by KevinH

Qt has officially fixed the two identical monitors with identical edid bug. [...]

Looks good to me - menus and dropdowns work as expected on both monitors.

On a sidenote, I've noticed in this build that filenames show the full path in the Book Browser pane, i.e. "OEBPS/Text/Section0001.xhtml". I'm not sure if this is intentional - I prefer that path be hidden so I can make the pane as narrow as possible.

Also, I've found another bug just this morning: Using the "Delete Unused Stylesheet Selectors..." function will delete selectors if the only time they're invoked has a space after it. For example with:

<p class="blah ">lorem</p>

if "blah" is only ever seen in code with the space after, it'll prompt to delete blah. Kind of a weird edge case but I ran into a retail epub this morning where I blew away a bunch of classes because many of the invocations had a space at the end.

[DNSB]

Originally Posted by Vanguard3000

Looks good to me - menus and dropdowns work as expected on both monitors.

On a sidenote, I've noticed in this build that filenames show the full path in the Book Browser pane, i.e. "OEBPS/Text/Section0001.xhtml". I'm not sure if this is intentional - I prefer that path be hidden so I can make the pane as narrow as possible.

Edit => Preferences => Appearance. Remove the check mark from the BookBrowser should show full paths.

[Vanguard3000]

Originally Posted by DNSB

Edit => Preferences => Appearance. Remove the check mark from the BookBrowser should show full paths.

Oh, perfect. I did a fresh install so my prefs weren't in place yet. Thanks!

[KevinH]

Yes trailing space in a class name is not an allowed part of a class name, meaning that class was never applied as it simply could not be. Spaces in class attributes mean more than one class applies, and spaces in css selectors indicate descendant selectors. They can exist but not alone (with nothing trailing it).

Not sure if there is anyway around it as classes with a space after certainly are "unused" by definition.

[KevinH]

I will look to see if I can trim class names with trailing spaces in some sane way before reporting which are unused.

Hopefully before deleting unused anythings you made a Checkpoint since it is very fast and easy that you could revert to.

And thanks for testing the qt fix and reporting back.

[KevinH]

@democrite

Originally Posted by democrite

very much looking forward to the new release as I also noticed the loss of focus on macOS and was gonna mention it. 🙏🏿

or perhaps you already have test build you're using and if it's not too trouble to publish a new one, that'd be much appreciated.

I needed a new testbuild to test a different accessibility fix so if you want you could try the following build and report back on if it fixes the focus issues you are seeing.

https://www.mobileread.com/forums/sh...7&postcount=16