Sigil-2.0.0 Released - Page 10

democrite · 08-26-2023, 12:09 PM

I think my add existing files crash is somehow related to accessbility and apps that use such. Default Folder X 6 beta and Rectangle, testing several times, both will crash Sigil when used.

https://github.com/rxhanson/Rectangle

KevinH · 08-26-2023, 12:48 PM

Yes, that makes sense as your backtrace includes Accessibility events being delivered just before the abort is triggered.

Nice detective work. I will look into building that Rectangle and seeing if I can recreate the bug.

My guess is Default Folder X beta 6 is the real culprit as tries to override file dialogs. It should only work with native dialogs. Unfortunately, it is not open source and so I do not trust it not to capture and send home personal information, password or tracking data so I will not be installing it on my system. It requires screen capture privileges which can be dangerous.

And Rectangle already has bugs related to issues with Qt 6.5.x.

See:

https://github.com/rxhanson/Rectangle/issues/1145

and a related issue:

https://github.com/PrismLauncher/Pri...cher/pull/1131

And its snap windows capabilities even causes issues with some official Apple software.

Have you tried telling Rectangle to not apply itself to Sigil?

nabsltd · 08-26-2023, 01:25 PM

Quote:

Originally Posted by theducks

I have 2 sets of dual screens handy (Acer and LG).

I checked at work (3x identical monitors) and home (2x identical), but all correctly report different serial numbers, so the bug doesn't manifest.

Check the EDID info in your registry to see if you have different values for the otherwise identical monitors. If so, you won't trigger the bug, either.

JSWolf · 08-26-2023, 03:14 PM

Would it be a good idea to delete the registry entries for the two identical monitor entries and let them be repopulated in hope they become different entries?

KevinH · 08-26-2023, 03:38 PM

Quote:

Originally Posted by JSWolf

Would it be a good idea to delete the registry entries for the two identical monitor entries and let them be repopulated in hope they become different entries?

How would they change? The EDID blocks are read directly from a monitor's firmware even if the monitor is not powered up. They are read only.

That is why there are edid pass thru devices to modify the edid scan and sync rates.

democrite · 08-26-2023, 04:48 PM

Quote:

Originally Posted by KevinH

Have you tried telling Rectangle to not apply itself to Sigil?

I saw that bug related to Chrome but didn’t read it carefully. I wasn’t aware it could be configured as such. Perhaps you meant Default Folder X which does have an exclusion option I haven’t tried. I’ll take a look when I have a chance. As a shortcut to Desktop or some other folder on the left panel works without triggering the issue, that works well enough for now.

Thanks for looking into it.

KevinH · 08-27-2023, 01:38 PM

Quote:

Originally Posted by democrite

I saw that bug related to Chrome but didn’t read it carefully. I wasn’t aware it could be configured as such. Perhaps you meant Default Folder X which does have an exclusion option I haven’t tried. I’ll take a look when I have a chance. As a shortcut to Desktop or some other folder on the left panel works without triggering the issue, that works well enough for now.

Thanks for looking into it.

According to the Rectangle.app README you can tell it to ignore an app like Sigil by:

Quote:

Ignore an app

Focus the app that you want to ignore (make a window from that app frontmost).
Open the Rectangle menu and select "Ignore app"

Once I installed Rectangle.app and used it to change the size of the FileDialog to take up half the screen, then navigating to random folders or selecting items, it immediately caused a crash. It does not have the same crash backtrace as Default Folder X 6 crash you posted earlier but crashes none the less.

So this bug is in Qt but there is little I can do to fix it as it is deep in the QAccessibility code. I did file a bug report with Qt itself.

https://bugreports.qt.io/browse/QTBUG-116507

So please tell both your Rectangle.app and your Default Folder X to ignore the Sigil app until a fix can be found.

democrite · 08-27-2023, 07:29 PM

Thanks Kevin for checking it out. I tried a bit yesterday excluding in both and restarting Sigil without effect. I'll try more later. Who knows if a reboot or something else like also restarting those apps is needed.

Indeed seems like a bug with Qt. In my earlier own builds with Qt6, at the time of trying to compile for Apple Silicon, I don't recall if I used add files at the time. I've since then removed most of the dev environment with 2.0 available.

Looking at bugs, it seemed like there was at least one issue fixed, something about files triggering a permissions request. Perhaps that means there have been a fair amount of changes to file dialog. Yet perhaps it is best left to them to find the source.

KevinH · 08-27-2023, 09:03 PM

If you do build your own again, I can show you where in the source files you can disable use of non-native file dialogs.

I did test Rectangle.app with native file dialogs and there was no crashing. If no Qt fix is provided before the next release, I will revert back to using native file dialogs for macOS just to prevent crashes, with the hopes that earlier native dialogue crashes have now been fixed.

I personally prefer the non-native dialogs as they originally were much more stable.

democrite · 08-28-2023, 12:45 AM

I may try a build but I'd likely have to start over creating the environment. I understand adapting to each environment with a bunch condtionals may lead to messy code that's more work to maintain. it may lead to a better xperience per platform but is indeed perhaps much more work to write maintain test etc. I so highly prefer the experience if possible yet am somewhat aware of the difficulty. Either way. Maybe indeed when i have more time maybe in a few weeks or later may try a build again.

KevinH · 08-29-2023, 10:40 AM

@democrite,
Better yet. Qt devs tracked down and fixed an Accessibility bug and posted a patch online. I was able to rebuild Qt6.5.2 with their patch. To test it I fired up Rectangle.app and now no crashes inside non-native QFileDialogs on my arm64 machine.

I have posted a testbuild for Sigil with the Qt patches in place here:

https://github.com/kevinhendricks/Bu...OnMac/releases

Grab Sigil.app-testbuild-Mac-arm64.txz

Please give it a try and confirm if this fixes both the crash with Rectangle.app and with your Default Folder X app.

If so I will make this Qt6.5.2 bug patch part of the next official release.

Thank you for your bug report!

DiapDealer · 08-29-2023, 10:49 AM

Does the patch only affect macOS?

KevinH · 08-29-2023, 11:25 AM

Quote:

Originally Posted by DiapDealer

Does the patch only affect macOS?

Good question. I am not sure. There are general changes to qlistview.cpp, and qitemview.cpp and to internal QAccessible code but there is also a piece that is macOS only.

The bug requires accessibility being enabled. It also hits when using QListView which are used in non-native QFileDialogs which Windows does not use in Sigil. I do not know if Windows has an Accessibiity API that integrates with Qt's Accessbility code at all.

Let it pass review on Qt first and if so, we can add it as an official general patch as Qt code for those would change for all platforms.

See https://bugreports.qt.io/browse/QTBUG-114423 near the bottom for the link to the patch.

KevinH · 08-29-2023, 11:35 AM

Just checked QAccessible docs and it integrates with Windows Accessibility software as well.
So including it for all platforms can not hurt.

KevinH · 08-29-2023, 11:44 AM

The small changes that are macOS specific only split one joint assert into two and prevent accessing things out of range.

The bulk of the fix is cross platform and should be used by all.

08-26-2023, 12:48 PM	#137
KevinH Sigil Developer Posts: 8,860 Karma: 6120478 Join Date: Nov 2009 Device: many	Yes, that makes sense as your backtrace includes Accessibility events being delivered just before the abort is triggered. Nice detective work. I will look into building that Rectangle and seeing if I can recreate the bug. My guess is Default Folder X beta 6 is the real culprit as tries to override file dialogs. It should only work with native dialogs. Unfortunately, it is not open source and so I do not trust it not to capture and send home personal information, password or tracking data so I will not be installing it on my system. It requires screen capture privileges which can be dangerous. And Rectangle already has bugs related to issues with Qt 6.5.x. See: https://github.com/rxhanson/Rectangle/issues/1145 and a related issue: https://github.com/PrismLauncher/Pri...cher/pull/1131 And its snap windows capabilities even causes issues with some official Apple software. Have you tried telling Rectangle to not apply itself to Sigil? Last edited by KevinH; 08-26-2023 at 04:06 PM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Sigil-1.9.20 Released	DiapDealer	Sigil	12	01-28-2023 09:41 AM
Sigil-0.9.12 Released	DiapDealer	Sigil	194	03-15-2019 03:51 PM
Sigil-0.9.11 Released	DiapDealer	Sigil	37	02-18-2019 06:56 PM
Sigil-0.8.900 released for testing - Wait for Sigil-0.8.901	KevinH	Sigil	106	10-04-2015 10:41 AM
Sigil 0.6.0 Released	user_none	Sigil	93	11-24-2012 06:50 PM

08-26-2023, 12:09 PM	#136
democrite Evangelist Posts: 441 Karma: 77256 Join Date: Sep 2011 Device: none	I think my add existing files crash is somehow related to accessbility and apps that use such. Default Folder X 6 beta and Rectangle, testing several times, both will crash Sigil when used. https://github.com/rxhanson/Rectangle

08-26-2023, 03:14 PM	#139
JSWolf Resident Curmudgeon Posts: 79,899 Karma: 146918083 Join Date: Nov 2006 Location: Roslindale, Massachusetts Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3	Would it be a good idea to delete the registry entries for the two identical monitor entries and let them be repopulated in hope they become different entries?

08-27-2023, 07:29 PM	#143
democrite Evangelist Posts: 441 Karma: 77256 Join Date: Sep 2011 Device: none	Thanks Kevin for checking it out. I tried a bit yesterday excluding in both and restarting Sigil without effect. I'll try more later. Who knows if a reboot or something else like also restarting those apps is needed. Indeed seems like a bug with Qt. In my earlier own builds with Qt6, at the time of trying to compile for Apple Silicon, I don't recall if I used add files at the time. I've since then removed most of the dev environment with 2.0 available. Looking at bugs, it seemed like there was at least one issue fixed, something about files triggering a permissions request. Perhaps that means there have been a fair amount of changes to file dialog. Yet perhaps it is best left to them to find the source.

08-27-2023, 09:03 PM	#144
KevinH Sigil Developer Posts: 8,860 Karma: 6120478 Join Date: Nov 2009 Device: many	If you do build your own again, I can show you where in the source files you can disable use of non-native file dialogs. I did test Rectangle.app with native file dialogs and there was no crashing. If no Qt fix is provided before the next release, I will revert back to using native file dialogs for macOS just to prevent crashes, with the hopes that earlier native dialogue crashes have now been fixed. I personally prefer the non-native dialogs as they originally were much more stable.

08-28-2023, 12:45 AM	#145
democrite Evangelist Posts: 441 Karma: 77256 Join Date: Sep 2011 Device: none	I may try a build but I'd likely have to start over creating the environment. I understand adapting to each environment with a bunch condtionals may lead to messy code that's more work to maintain. it may lead to a better xperience per platform but is indeed perhaps much more work to write maintain test etc. I so highly prefer the experience if possible yet am somewhat aware of the difficulty. Either way. Maybe indeed when i have more time maybe in a few weeks or later may try a build again.

08-29-2023, 10:40 AM	#146
KevinH Sigil Developer Posts: 8,860 Karma: 6120478 Join Date: Nov 2009 Device: many	@democrite, Better yet. Qt devs tracked down and fixed an Accessibility bug and posted a patch online. I was able to rebuild Qt6.5.2 with their patch. To test it I fired up Rectangle.app and now no crashes inside non-native QFileDialogs on my arm64 machine. I have posted a testbuild for Sigil with the Qt patches in place here: https://github.com/kevinhendricks/Bu...OnMac/releases Grab Sigil.app-testbuild-Mac-arm64.txz Please give it a try and confirm if this fixes both the crash with Rectangle.app and with your Default Folder X app. If so I will make this Qt6.5.2 bug patch part of the next official release. Thank you for your bug report!

08-29-2023, 10:49 AM	#147
DiapDealer Grand Sorcerer Posts: 28,664 Karma: 205039118 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	Does the patch only affect macOS?

08-29-2023, 11:35 AM	#149
KevinH Sigil Developer Posts: 8,860 Karma: 6120478 Join Date: Nov 2009 Device: many	Just checked QAccessible docs and it integrates with Windows Accessibility software as well. So including it for all platforms can not hurt.

08-29-2023, 11:44 AM	#150
KevinH Sigil Developer Posts: 8,860 Karma: 6120478 Join Date: Nov 2009 Device: many	The small changes that are macOS specific only split one joint assert into two and prevent accessing things out of range. The bulk of the fix is cross platform and should be used by all.