Searched for words inside a book. "This text is hidden and cannot be displayed"

[droopy]

Hi Kovid developer,

I searched for some text in a book and it found it. But it says

"This text is hidden and cannot be displayed".

Please see screenshot.
Using Calibre 6.20.

[DNSB]

What does the CSS and styling around that search item look like? Considering the repeated bits of text such as 175, QUEEN MARGARET, & EDWARD, which are unlikely to be visible.

For what it's worth, I downloaded the ePub3 version from Gutenberg and it did not have any issues with searching. Where did you obtain your copy? I did find a PDF copy that had those numbers.

[thiago.eec]

Originally Posted by droopy

Hi Kovid developer,

I searched for some text in a book and it found it. But it says

"This text is hidden and cannot be displayed".

Please see screenshot.
Using Calibre 6.20.

Looks like a bug to me.

When searching for a term that is not visible on the viewer, you get that message. The numbers are probably hidden either by CSS (display: none) or using the HTML 'hidden' property. But that should not affect searching for the term near it, hence the bug.

Test case:

<p>Ordinary text being displayed.</p>
<p style="display:none">Hidden text</p>

If you search for 'Ordinary text being displayed', you get that same error. I think that's because calibre also get the surrounding context when displaying the searched term. And when it gets a hidden text for context, then the bug occurs.

[kovidgoyal]

That's unavoidable given how search works it has to search for context as well to find the correct match.

[thiago.eec]

Originally Posted by kovidgoyal

That's unavoidable given how search works it has to search for context as well to find the correct match.

Well, can't the viewer highlight just the searched term if it is visible text? I mean, calibre does find and display the searched term (and context). Also, the viewer already opens the right chapter (html file).

[kovidgoyal]

There are technical reasons why this is not possible, if you know a way to make it possible feel free to submit a patch. Relevant code is in viewer/search.py and read_book/find.pyj

EDIT: You can have it show matches with hidden context, by simply commenting out 30-32 in find.pyj but doing this will mean that when searching for hidden text, the result wiil be displayed but clicking on it wont highlight anything.

[kovidgoyal]

On second thoughts, this should improve the situation, making detection of hidden text more robust.

https://github.com/kovidgoyal/calibr...5cd22366c972a4

[thiago.eec]

Thanks, Kovid!

Searching for a term next to the hidden text now works perfectly (jumps to it and highlights).
About searching for hidden text, now it doesn't show the alert, as before. I don't know if it's because I'm running from source.

[kovidgoyal]

It will now show the alert when you click on the result witht he hidden text.

[thiago.eec]

Originally Posted by kovidgoyal

It will now show the alert when you click on the result witht he hidden text.

It doesn't show for me.

[kovidgoyal]

post a book and a search for which it happens

[thiago.eec]

I added this code to the original Project Gutenberg's book:

..as he fled with more than
mortal speed.</p>
<p style="display:none">Example of hidden text</p>
<p>I pursued him; and for many months this has been my task...

When searching for: 'I pursued him', it jumps to the page and highlights it.

Now, if I search for 'hidden text', it shows the result without the alert; clicking on it doesn't show the alert either.

[kovidgoyal]

Works for me, see attached.

[kovidgoyal]

Ah but it doesnt work when searching for multiple hidden words.

[kovidgoyal]

And that should take care of it.

https://github.com/kovidgoyal/calibr...7164e88f20e184