Thanks for the Extra data files (minor remark)

[BetterRed]

The book/data folders don't seem to be copied at all, even they only contain one file.

I only tried copy, not copy and delete, I copied to an empty library, with and without custom columns.

BR

[thiago.eec]

Originally Posted by BetterRed

I have this in my Links Column

<p><a href="file:///D:/Calibre/Libraries/Test/Anat%20Admati/The%20Bankers'%20New%20Clothes%20(159)/data/"><span style="color: #9e7852">Attachments</span></a></p></

BR

What kind of custom column is that? I was under the impression that only 'Long text' could show HTML. But 'Long text' behaves like 'comments', and always appear at the end of the Book Details panel.

I did some testing here but couldn't figure it out.

Also, you said 'I have this in my Links Column', but you certainly have more, right?

[chaley]

Originally Posted by BetterRed

The book/data folders don't seem to be copied at all, even they only contain one file.

I only tried copy, not copy and delete, I copied to an empty library, with and without custom columns.

BR

@kovid: I can replicate this problem. It seems to be caused by this in db.copy_to_library
line 108 is

                nbp = newdb.field_for('path', book_id)

but should be

                nbp = newdb.field_for('path', new_book_id)

I didn't push the change because I am not confident enough that I understand all the ramifications. However, with the change, "Copy to library" does copy the data files.

[kovidgoyal]

@chaley: That was indeed the correct fix, thanks. https://github.com/kovidgoyal/calibr...520a8e220e9e84

[chaley]

Originally Posted by thiago.eec

What kind of custom column is that? I was under the impression that only 'Long text' could show HTML. But 'Long text' behaves like 'comments', and always appear at the end of the Book Details panel.

I did some testing here but couldn't figure it out.

Also, you said 'I have this in my Links Column', but you certainly have more, right?

In the column definition, set "Column heading" (the second one of these with a drop down list) to "Show heading to the side of the text". That changes it to appear with the other fields instead of with comments.

And yes, I will fix the label of that row in column definition, and I will improve the documentation in book details column selection.

Edit: That second "Column heading:" label is now "Heading position". The tool tips were changed to say how positioning affects placement in book details.

[thiago.eec]

Originally Posted by chaley

In the column definition, set "Column heading" (the second one of these with a drop down list) to "Show heading to the side of the text". That changes it to appear with the other fields instead of with comments.

And yes, I will fix the label of that row in column definition, and I will improve the documentation in book details column selection.

Edit: That second "Column heading:" label is now "Heading position". The tool tips were changed to say how positioning affects placement in book details.

Thanks! I would never had guessed that.

[revjoe]

This is really nice addition, thanks!

[thiago.eec]

@kovid @chaley

Do you guys think it would be possible to click links directly on custom columns (main window)? Maybe using 'shift+click'.

[ownedbycats]

Originally Posted by thiago.eec

What kind of custom column is that? I was under the impression that only 'Long text' could show HTML. But 'Long text' behaves like 'comments', and always appear at the end of the Book Details panel.

I did some testing here but couldn't figure it out.

Also, you said 'I have this in my Links Column', but you certainly have more, right?

I think BR uses HTML longtext column. Job Spy has a new feature to view longtexts in a popup window.

[BetterRed]

Originally Posted by chaley

@kovid: I can replicate this problem. It seems to be caused by this in db.copy_to_library
<snip>
I didn't push the change because I am not confident enough that I understand all the ramifications. However, with the change, "Copy to library" does copy the data files.

Originally Posted by kovidgoyal

@chaley: That was indeed the correct fix, thanks.

Whew, I thought it was just me with my inter/intra-library links!

My sole use of the Copy to library feature is to copy books from my Intake library to my Books, Journals and Media libraries and I add any attachments after that.

Has anyone else noticed the little green popup offering Undo immediately after to doing a Remove - it appears just under the title bar. If you have icons in your toolbar you mayn't notice it.

BR

[ownedbycats]

I noticed it. Is easy to miss though. I thought it could've been a bit more visible.

[BetterRed]

Originally Posted by thiago.eec

@kovid @chaley

Do you guys think it would be possible to click links directly on custom columns (main window)? Maybe using 'shift+click'.

It's at my finger tips, F3, Ctrl+N, Tab to link, Enter



BR

[BetterRed]

I may have raised this before.

The Browse button in the long text editor Link tool does not allow selection of a folder. If you want the resultant file:\\\ URL to open the folder, you must select a file within the folder, and then cut it out of the Enter URL: field.

I have a sneaking suspicion this maybe a Qt issue.

BR

[kovidgoyal]

Originally Posted by ownedbycats

I noticed it. Is easy to miss though. I thought it could've been a bit more visible.

It's the same one that's used in the editor for deleting files. It's meant to be subtle so it doesnt get in the way for an operation thats very rarely used.

[kovidgoyal]

Originally Posted by BetterRed

I may have raised this before.

The Browse button in the long text editor Link tool does not allow selection of a folder. If you want the resultant file:\\\ URL to open the folder, you must select a file within the folder, and then cut it out of the Enter URL: field.

I have a sneaking suspicion this maybe a Qt issue.

BR

https://github.com/kovidgoyal/calibr...d950290e74e10d