[GUI Plugin] Job Spy

[BetterRed]

Originally Posted by DaltonST

I use the Tab key and the Arrow keys to "traverse" the search results list. Please clarify what you are thinking about.


DaltonST

Thanks for the changes.

Sorting on BookID should be numeric, see attachment (note the Snippet - maybe it should be first two lines if first is very short - without the line feed).

I'd also prefer to set and forget a default Sort sequence - for me it would be BookID ascending. Ditto with AJ - which for me would be checked.

The RegExp field doesn't appear to have a 'Alt+' shortcut

The following error can also occur if the user does a NV search and then does a book list search that takes NV search results out of sight. You might want to add " or you did library search, or clicked a VL tab". I hit Alt+A in the book list which does a search for current author

calibre, version 6.15.0
ERROR: Notes Viewer: Book does not currently exist. Either you recently deleted it, or you are using a Virtual Library that does not contain it.

BR

[BetterRed]

I found the hidden Easter egg, if you have an LT column with multiple links you can Tab/Backtab to them and press enter to get at them.

I also found that file:/// links to a folder don't work in NV, but they do in Book Details - it opens the folder in file explorer.



file:/// links to a file are fine - including to a windows shortcut to the folder. Bit ugly though, folder shortcuts inside the target folder was a kludge I used on my Heath Robinson library manager 20 years ago.

Added: How can I give focus to the note content widget from the keyboard?

Added 2: I'd rather the NV didn't close if I hit Escape.

BR

[DaltonST]

Originally Posted by BetterRed

Added: How can I give focus to the note content widget from the keyboard?

Added 2: I'd rather the NV didn't close if I hit Escape.

BR

[1] See the attached ToolTips for the Edit Mode label for the Edit radio-button. Focus only exists in Edit Mode. That is a Qt thing. You can use Tab to move the focus next to it, but not within it, in View Mode.

[2] Escape natively closes all Qt Widgets; that is a Qt thing that I also dislike.


DaltonST

[DaltonST]

Version 1.0.228 -2023-04-07 Notes Viewer: Various enhancements. Refer to the attached images for details.


DaltonST

[BetterRed]

If the Note has embedded links the Tab key will land on them and Enter will 'click' on them - that's the Easter egg I mentioned. Copy this to a note and use Tab in the note.

<div>
<p><a href="https://www.mobileread.com/forums/showthread.php?p=4312753#post4312753"><span style="color: #6cb4ee">MobileRead Forum Thread</span></a></p>
<p style="color: #6cb4ee"> </p>
<p>blah blah blah</p>
<p> </p>
<p><a href="https://en.wikipedia.org/wiki/Great_Expectations"><span style="color: #6cb4ee">WP - Great Expectations</span></a></p>
<p> </p>
<p>blah blah blah</p>
<p> </p>
<p><a href="https://johnmenadue.com/easter-message-power-control-autocracy-empire/"><span style="color: #6cb4ee">Menadue's Blog</span></a></p>
<p> </p></div>

Qt permitting, if I could give the text box keyboard focus from the keyboard it'd be another nail in the mouse's coffin. Chaley wrangled a way to toggle kb focus between the book list and tag browser using user defined shortcuts, maybe there's a clue there.

Why does NV react to what I do in the book list, viz:



Country is a Text like tags column.

BR

[chaley]

Originally Posted by DaltonST

[2] Escape natively closes all Qt Widgets; that is a Qt thing that I also dislike.

DaltonST

I had this problem in the template tester dialog. Solved it by checking key presses for the ESC key.

    def keyPressEvent(self, ev):
        if ev.key() == Qt.Key.Key_Escape:
            # Check about ESC to avoid killing the dialog by mistake
            if self.textbox.toPlainText() != self.original_text:
                r = question_dialog(self, _('Discard changes?'),
                      _('Do you really want to close this dialog, discarding any changes?'))
                if not r:
                    return
        QDialog.keyPressEvent(self, ev)

[DaltonST]

Originally Posted by BetterRed

Why does NV react to what I do in the book list, viz:

Attachment 200861

Country is a Text like tags column.

BR

NV is joined at the hip with the Library View. Its driver is a Library View event that is emitted whenever the current cell changes.

self.maingui.library_view.selectionModel().currentChanged.connect(self.refresh_notes_viewer)

I will take your question as an indication that NV is very non-mouse-user friendly. That question would never occur to a pure mouse-user, like myself, who doesn't use shortcuts.


DaltonST

[DaltonST]

Originally Posted by chaley

I had this problem in the template tester dialog. Solved it by checking key presses for the ESC key.

    def keyPressEvent(self, ev):
        if ev.key() == Qt.Key.Key_Escape:
            # Check about ESC to avoid killing the dialog by mistake
            if self.textbox.toPlainText() != self.original_text:
                r = question_dialog(self, _('Discard changes?'),
                      _('Do you really want to close this dialog, discarding any changes?'))
                if not r:
                    return
        QDialog.keyPressEvent(self, ev)

Chaley, thank you kindly. I was prepared to AstroGrep through \calibre-master\src\calibre\ to find the keypress event filter that keeps Calibre itself from closing. Your snippet is much appreciated.


DaltonST

[chaley]

Originally Posted by BetterRed

Chaley wrangled a way to toggle kb focus between the book list and tag browser using user defined shortcuts, maybe there's a clue there.

The code of interest for this is in calibre/gui2/tag_browser/view.py.

The change to allow the tag browser to have the focus is on line 251:

        if gprefs['tag_browser_allow_keyboard_focus']:
            self.setFocusPolicy(Qt.FocusPolicy.StrongFocus)
        else:
            self.setFocusPolicy(Qt.FocusPolicy.NoFocus)

There are some other changes related to focus in the file that may or may not be important, in particular for handing tabs. Searching for "focus2 will find them.

The code for the shortcut to give the tag browser focus is in calibre/gui2/tag_browser/ui.py line 801. This is a toggle, moving the focus between the tag view and the book list.

    def give_tb_focus(self, *args):
        if gprefs['tag_browser_allow_keyboard_focus']:
            tb = self.tags_view
            if tb.hasFocus():
                self._parent.shift_esc()
            elif self._parent.current_view() == self._parent.library_view:
                tb.setFocus()
                idx = tb.currentIndex()
                if not idx.isValid():
                    idx = tb.model().createIndex(0, 0)
                    tb.setCurrentIndex(idx)

The shortcut itself is set up on line 768.

IIRC calibre shortcuts aren't inherited by non-modal windows (such as undocked QuickView), which in your case might be a deal breaker. On the other hand, ALT+Tab (Windows) works, which might be sufficient.

[DaltonST]

Originally Posted by BetterRed

Qt permitting, if I could give the text box keyboard focus from the keyboard it'd be another nail in the mouse's coffin. BR

NV uses 2 QTextEdit widgets (for Plain and Markdown), and 1 QTextBrowser widget (for HTML). The latter inherits from the former.

2 of the above are always hidden and disabled. Which is current is based on the value indicated in the radio-button for format-type.

The "focus in read-only" problem is a QTextEdit design issue. I am toying with it to see what loopholes exist in it that are accessible only programmatically.


DaltonST

[DaltonST]

I also found that file:/// links to a folder don't work in NV, but they do in Book Details - it opens the folder in file explorer.

They work in the next version to be released soon. On my PC, it opens Q-Dir.exe, which is my default file/folder browser.


DaltonST

[DaltonST]

Qt permitting, if I could give the text box keyboard focus from the keyboard it'd be another nail in the mouse's coffin.

QTextEdit for Plain and Markdown, and its descendant QTextBrowser for HTML, seem to be hardcoded in Qt to not permit giving any keyboard focus, and even begrudgingly any mouse cursor focus. Even the Ctrl+A[#1] Qt shortcut for "Select All Text" in View Mode is non-functional without a mouse to click its context menu.

All I can recommend is that you switch to Edit Mode temporarily using its shortcut, then do what you will with the text using the keyboard, and then "Cancel Column Edits" with its shortcut to return to View Mode with whatever you selected still in the Clipboard.

Note [#1]: Yes, Ctrl+A is also the shortcut for sorting Search Results by "Author", but the only possible conflict in NV that could arise from that has been de-conflicted. If you switch to Edit Mode, Ctrl+A will apply only to Edit Mode text (Select All Text), and not at all to the sorting of Search Results. Switch back to View Mode, and Ctrl+A only applies to sorting Search Results. Not an issue. If it were, I would change the sorting by Author shortcut to something else, but it isn't. "A" for "Author" is just too intuitive to let go without an effort to keep it.


DaltonST

[ownedbycats]

Small visual bug:

1. Open NV with a default selected column. Make sure 'lock?' is disabled.
2. Click on another cell in the book list to load that cell.
3. Click 'Lock?'
4. Use the dropdown menu to select a column.

Expected behaviours:
1. The dropdown menu will be disabled if the column is locked.
2. If the dropdown menu is enabled, it will change the displayed column even if locked.

Actual result:
Changing the column with the dropdown menu does not change the displayed one.

[DaltonST]

Originally Posted by ownedbycats

Small visual bug:

1. Open NV with a default selected column. Make sure 'lock?' is disabled.
2. Click on another cell in the book list to load that cell.
3. Click 'Lock?'
4. Use the dropdown menu to select a column.

Expected behaviours:
1. The dropdown menu will be disabled if the column is locked.
2. If the dropdown menu is enabled, it will change the displayed column even if locked.

Actual result:
Changing the column with the dropdown menu does not change the displayed one.

So, you Locked the column while NV was still focused on Title? And then changed the column in the dropdown to #fanficmetadata?

"Lock" means "Lock here, starting right now". "Lock" does not mean "auto-jump to the next new dropdown #column I pick". It simply locked where you were when you clicked "Lock". It just so happened it was not where you wanted to be.

The proper sequence is to have changed the column to #fanficmetadata and then Locked. The changing of the column to #fanficmetadata itself would have caused an immediate "auto-jump" by NV to #fanficmetadata, but that normal auto-jump was blocked by the premature Lock.

Not a bug. User error.


DaltonST

[ownedbycats]

Yes, that's the sequence. I would've expected the dropdown menu to become unavailable to indicate that it wouldn't work.