Editor indicates change when there isn't any

DrChiper · 10-28-2022, 03:00 PM

Sometimes, when I did some editing followed by a "save", the previously changed TAB still indicates that it contents are changed and not saved.
Not a major issue, but annoying and also present in previous versions.

BetterRed · 10-28-2022, 05:37 PM

I can't replicate this (on text or image tabs), but I don't use the button bars instead I use keyboard shortcuts or the menu bar.

It seems unlikely, but trying doing the save with Ctrl+S.

Windows 10 22H1, Calibre 6.7.1

BR

kovidgoyal · 10-29-2022, 12:26 AM

I cant reproduce either, if you can come up with a set of steps to repro I will take a look.

DrChiper · 10-29-2022, 11:08 AM

Currently I'm using Windows 11 and calibre 6.7.1.
It happens now and then during long/short edits followed by a save activity: either after pressing the save-button or using ctrl-S. It is not related to the latest calibre version as I have seen it in previous versions too. It seems to occur randomly and yesterday rather spontaneously so I could make a screen-dump. I wish I had a solid scenario to present, but I cannot, sorry.

UPDATE: I could replicate it on editing an image as indicated in my first msg. I did an image replacement, followed by a save: the save button went grey-out while the change indicator in the image TAB remained.

BetterRed · 10-29-2022, 07:13 PM

Quote:

Originally Posted by DrChiper

UPDATE: I could replicate it on editing an image as indicated in my first msg. I did an image replacement, followed by a save: the save button went grey-out while the change indicator in the image TAB remained.

Confirmed - If I use the File Browser->Replace 00006.jpeg with file... option to replace the existing image with another image with the same name - the diskette icon goes grey after CTRL+S but the changed indicator (quill) persists. See attached screen shot.

If I drag/drop the replacement image into the image tab CV window it's fine - quill shows, do a Ctrl+S, quill goes away and diskette goes grey.

BR

kovidgoyal · 10-30-2022, 12:21 AM

https://github.com/kovidgoyal/calibr...5ae118982db8af

DrChiper · 10-30-2022, 03:17 PM

Great

DrChiper · 11-06-2022, 05:48 PM

The issue has indeed gone in version 6.8, but a new phenomenon has cropped up. When I replace 1 image, then all the TABs with opened images get the "change quill", which is not correct.
Using "Save" makes the quills disapear, which is ok.

kovidgoyal · 11-07-2022, 06:00 AM

That should take care of it

https://github.com/kovidgoyal/calibr...f96e6eab1f37b3

DrChiper · 11-07-2022, 07:24 AM

Great

10-28-2022, 03:00 PM	#1
DrChiper Bookish Posts: 1,049 Karma: 2006208 Join Date: Jun 2011 Device: PC, t1, t2, t3, Clara BW, Clara HD, Libra 2, Libra Color, Nxtpaper 11	Editor indicates change when there isn't any Sometimes, when I did some editing followed by a "save", the previously changed TAB still indicates that it contents are changed and not saved. Not a major issue, but annoying and also present in previous versions. Attached Thumbnails

10-29-2022, 11:08 AM	#4
DrChiper Bookish Posts: 1,049 Karma: 2006208 Join Date: Jun 2011 Device: PC, t1, t2, t3, Clara BW, Clara HD, Libra 2, Libra Color, Nxtpaper 11	Currently I'm using Windows 11 and calibre 6.7.1. It happens now and then during long/short edits followed by a save activity: either after pressing the save-button or using ctrl-S. It is not related to the latest calibre version as I have seen it in previous versions too. It seems to occur randomly and yesterday rather spontaneously so I could make a screen-dump. I wish I had a solid scenario to present, but I cannot, sorry. UPDATE: I could replicate it on editing an image as indicated in my first msg. I did an image replacement, followed by a save: the save button went grey-out while the change indicator in the image TAB remained. Last edited by DrChiper; 10-29-2022 at 11:22 AM.

11-06-2022, 05:48 PM	#8
DrChiper Bookish Posts: 1,049 Karma: 2006208 Join Date: Jun 2011 Device: PC, t1, t2, t3, Clara BW, Clara HD, Libra 2, Libra Color, Nxtpaper 11	The issue has indeed gone in version 6.8, but a new phenomenon has cropped up. When I replace 1 image, then all the TABs with opened images get the "change quill", which is not correct. Using "Save" makes the quills disapear, which is ok. Attached Thumbnails

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Please revert change to 4.21's editor	JSWolf	Editor	29	10-07-2022 02:59 PM
Published Date will not change in metadata editor.	M0rph3us	Calibre	5	05-24-2015 02:56 PM
Editor toolbar button change request?	bauerhjb	Editor	4	09-21-2014 07:04 PM
How to change default text editor	Calyr Elf	Sigil	3	06-01-2012 01:02 PM

10-28-2022, 05:37 PM	#2
BetterRed null operator (he/him) Posts: 22,036 Karma: 30277960 Join Date: Mar 2012 Location: Sydney Australia Device: none	I can't replicate this (on text or image tabs), but I don't use the button bars instead I use keyboard shortcuts or the menu bar. It seems unlikely, but trying doing the save with Ctrl+S. Windows 10 22H1, Calibre 6.7.1 BR

10-29-2022, 12:26 AM	#3
kovidgoyal creator of calibre Posts: 45,636 Karma: 28549046 Join Date: Oct 2006 Location: Mumbai, India Device: Various	I cant reproduce either, if you can come up with a set of steps to repro I will take a look.

10-30-2022, 12:21 AM	#6
kovidgoyal creator of calibre Posts: 45,636 Karma: 28549046 Join Date: Oct 2006 Location: Mumbai, India Device: Various	https://github.com/kovidgoyal/calibr...5ae118982db8af

10-30-2022, 03:17 PM	#7
DrChiper Bookish Posts: 1,049 Karma: 2006208 Join Date: Jun 2011 Device: PC, t1, t2, t3, Clara BW, Clara HD, Libra 2, Libra Color, Nxtpaper 11	Great

11-07-2022, 06:00 AM	#9
kovidgoyal creator of calibre Posts: 45,636 Karma: 28549046 Join Date: Oct 2006 Location: Mumbai, India Device: Various	That should take care of it https://github.com/kovidgoyal/calibr...f96e6eab1f37b3

11-07-2022, 07:24 AM	#10
DrChiper Bookish Posts: 1,049 Karma: 2006208 Join Date: Jun 2011 Device: PC, t1, t2, t3, Clara BW, Clara HD, Libra 2, Libra Color, Nxtpaper 11	Great