[GUI Plugin] Goodreads Sync

[Rellwood]

Ok, I know I have posted here a lot, but this came up today and it's preventing me from refreshing the plugin. Just updated yesterday. I also have 5.28 (64) still works.

calibre, version 5.38.0
ERROR: Unhandled exception: <b>UnboundLocalError</b>:local variable 'msg' referenced before assignment

calibre 5.38 embedded-python: True is64bit: False
Windows-10-10.0.19041 Windows ('32bit', 'WindowsPE')
32bit process running on 64bit windows
('Windows', '10', '10.0.19041')
Python 3.8.5
Windows: ('10', '10.0.19041', '', 'Multiprocessor Free')
Interface language: None
Successfully initialized third party plugins: DeDRM (7, 2, 1) && Amazon.com Multiple Countries (1, 0, 0) && Barnes & Noble (1, 2, 16) && Calibre Power Search Plugin (2, 1, 2) && CalibreSpy (1, 0, 84) && Clean Metadata (0, 0, 6) && Comments Cleaner (1, 6, 1) && Consolidate All Library Metadata (2, 0, 40) && Count Pages (1, 11, 2) && DOC Input (1, 0, 1) && Diaps Editing Toolbag (0, 3, 7) && English Noun Frequency (1, 0, 13) && EpubCheck (0, 2, 4) && EpubMerge (2, 12, 0) && EpubSplit (3, 2, 0) && Extract ISBN (1, 5, 0) && F_rating (3, 2, 0) && FanFicFare (4, 10, 0) && Fantastic Fiction (1, 5, 1) && Fantastic Fiction Adults (1, 2, 0) && Favourites Menu (1, 1, 0) && Find Duplicates (1, 9, 4) && Generate Cover (2, 1, 0) && GetFileName (0, 1, 1) && Goodreads (1, 5, 3) && Goodreads More Tags (1, 2, 1) && Goodreads Sync (1, 15, 1) && Goodreads_Rating (3, 1, 0) && Import List (1, 8, 2) && Job Spy (1, 0, 190) && Kindle Collections (1, 7, 29) && Kobo Books (1, 8, 3) && LibraryThing Match (0, 2, 0) && Mass Search-Replace (1, 4, 2) && Modify ePub (1, 7, 0) && Overdrive Link (2, 50, 0) && Quality Check (1, 12, 0) && Reading List (1, 8, 0) && Reformat plugin (2, 4, 0) && Search The Internet (1, 8, 1) && Smashwords Metadata (1, 0, 2) && User Category (1, 5, 5) && View Manager (1, 7, 0) && Wikidata (2, 0, 0) && ePub Extended Metadata (0, 6, 0) && ePub Extended Metadata {Reader} (0, 6, 0) && ePub Extended Metadata {Writer} (0, 6, 0) && Overdrive Link* (2, 50, 0)
Traceback (most recent call last):
File "calibre_plugins.goodreads_sync.config", line 1151, in refresh_shelves_list
File "calibre_plugins.goodreads_sync.core", line 290, in get_shelf_list
File "calibre_plugins.goodreads_sync.core", line 178, in _request_get
File "calibre_plugins.goodreads_sync.httplib2.__init__" , line 1689, in request
File "calibre_plugins.goodreads_sync.httplib2.__init__" , line 1429, in _request
File "calibre_plugins.goodreads_sync.httplib2.__init__" , line 1349, in _conn_request
File "calibre_plugins.goodreads_sync.httplib2.__init__" , line 1138, in connect
UnboundLocalError: local variable 'msg' referenced before assignment

[davidfor]

That's a weird error as I cannot see how that code gets to that line without "msg" being set. I'm not sure what to suggest other than to use the working 64bit version of calibre.

[something random]

I don't know if this behaviour can be changed.
I have got the stage where I am now re-reading a number of books.
I have created a new calibre library and have copied the books I've re-read to it and have changed the 'date read' column.

When I added a re-read book through the Goodreads Sync plugin, I expected it to create a duplicate entry of the book or to add the new date to the existing record on Goodreads; but what it did was change the original date read to the re-read date which is not ideal.

[Terisa de morgan]

Originally Posted by koleary2000

I don't know if this behaviour can be changed.
I have got the stage where I am now re-reading a number of books.
I have created a new calibre library and have copied the books I've re-read to it and have changed the 'date read' column.

When I added a re-read book through the Goodreads Sync plugin, I expected it to create a duplicate entry of the book or to add the new date to the existing record on Goodreads; but what it did was change the original date read to the re-read date which is not ideal.

That's not a plugin fault but goodreads api fault. For avoiding that, before adding the end date, I'm adding an intermediate status (I usually set a 4% reading, but it's the same). Doing this, it creates the duplicate entry where the new end date will be set.

[davidfor]

Originally Posted by koleary2000

I don't know if this behaviour can be changed.
I have got the stage where I am now re-reading a number of books.
I have created a new calibre library and have copied the books I've re-read to it and have changed the 'date read' column.

When I added a re-read book through the Goodreads Sync plugin, I expected it to create a duplicate entry of the book or to add the new date to the existing record on Goodreads; but what it did was change the original date read to the re-read date which is not ideal.

As Terisa has mentioned, this is probably an issue with the API and Goodreads overall. But, I would have said it did this already.

I just tested this with a finished book. I used the "Add to shelf" to add the book to the "currently-reading" shelf. When I checked on GR, the reading progress of the book showed it was reading and had been added to the shelf today. I then used the progress update to change it to 50% finished. Then I use "Add to shelf" to put it on the "read" shelf. GR is showing this plus the dates for when I read it the first time (well, probably second or third time, but GR wasn't around then).

That seems to work. How are you doing it?

[something random]

Originally Posted by davidfor

As Terisa has mentioned, this is probably an issue with the API and Goodreads overall. But, I would have said it did this already.

I just tested this with a finished book. I used the "Add to shelf" to add the book to the "currently-reading" shelf. When I checked on GR, the reading progress of the book showed it was reading and had been added to the shelf today. I then used the progress update to change it to 50% finished. Then I use "Add to shelf" to put it on the "read" shelf. GR is showing this plus the dates for when I read it the first time (well, probably second or third time, but GR wasn't around then).

That seems to work. How are you doing it?

I did some more playing after Terisa's comment and I have it working now. I wasn't using the reading progress step. Thanks for the responses from both you and Terisa.

[Terisa de morgan]

Glad it has worked.

[Rellwood]

Originally Posted by koleary2000

I don't know if this behaviour can be changed.
I have got the stage where I am now re-reading a number of books.
I have created a new calibre library and have copied the books I've re-read to it and have changed the 'date read' column.

When I added a re-read book through the Goodreads Sync plugin, I expected it to create a duplicate entry of the book or to add the new date to the existing record on Goodreads; but what it did was change the original date read to the re-read date which is not ideal.

PM Me and I will give you a step by step way of completly updating your library with every read date that GR has.

[Rellwood]

Is there anyway of making the combo box with the actions when the sync is about to happen be longer? I would like to be able to see the rules before actually hitting the sync to make sure they are what I like but the area is very short. I stretch the whole thing but only the book list gets longer, that combo box for the rules stays pretty thin.

[davidfor]

Originally Posted by Rellwood

Is there anyway of making the combo box with the actions when the sync is about to happen be longer? I would like to be able to see the rules before actually hitting the sync to make sure they are what I like but the area is very short. I stretch the whole thing but only the book list gets longer, that combo box for the rules stays pretty thin.

Sorry, I don't know what combo box you are talking about. The only "sync" action is "Sync from shelves". That displays the list of books in the "Sync from Goodreads Shelf" dialog, but I do not see a combo-box on that dialog. And I can't think of any combo boxes outside of the configuration.

[Rellwood]

Originally Posted by davidfor

Sorry, I don't know what combo box you are talking about. The only "sync" action is "Sync from shelves". That displays the list of books in the "Sync from Goodreads Shelf" dialog, but I do not see a combo-box on that dialog. And I can't think of any combo boxes outside of the configuration.

Ok, then I am using the wrong term.

What I am talking about is this.

I want to stretch that area so I don't have to scroll. Some books have a lot of rules. Is there a place in the plugin that I can edit this? I can unzip it and edit using Notepad++ and rezip it and install.

Please and thank you!

[Rellwood]

Also, I think I know what that error is from. Goodreads just started using Captchas. It seems that whenever I try to edit a book on the site they want to add that Captcha. However, for the most part I don't have a problem using the plugin until I try to do too many changes at once. I can edit 50 books fine, but then I go to edit another 35 right after and then I get the error. This happens when I try to update an entire shelf.

Goodreads doesn't allow editing bookshelves/dates in the "list view" on the site, once you try and make a change and set it the edit bookreview box opens up and you have to re-enter the changes and then do the CAPTCHA (complete with boxes to match). I have also found that the CAPTCHA sometimes gets "stuck" and an error prevents it from completing. I have set my pop-up blockers to ignore Goodreads.

This is a very recent change that I have noticed in the past hour. Books being updated from your Kindle don't have a problem

Also, syncing hasn't been a problem.

[davidfor]

Originally Posted by Rellwood

Ok, then I am using the wrong term.

What I am talking about is this.

I want to stretch that area so I don't have to scroll. Some books have a lot of rules. Is there a place in the plugin that I can edit this? I can unzip it and edit using Notepad++ and rezip it and install.

The text box resizes itself to fill as much space as it can in that section of the dialog. And the section will be resized as you resize the dialog. And you can resize the section to take up more of the dialog. There isn't an obvious line, but if you move the cursor over the area above it, it will change to a resize cursor. Just make the area bigger and you will see more text.

As to changing it, the code is in the plugin. If you want to change the sizes of different fields you need to edit that, find the appropriate spot and change it. I'd have to hunt through it to find it.

[davidfor]

Originally Posted by Rellwood

Also, I think I know what that error is from. Goodreads just started using Captchas. It seems that whenever I try to edit a book on the site they want to add that Captcha. However, for the most part I don't have a problem using the plugin until I try to do too many changes at once. I can edit 50 books fine, but then I go to edit another 35 right after and then I get the error. This happens when I try to update an entire shelf.

Goodreads doesn't allow editing bookshelves/dates in the "list view" on the site, once you try and make a change and set it the edit bookreview box opens up and you have to re-enter the changes and then do the CAPTCHA (complete with boxes to match). I have also found that the CAPTCHA sometimes gets "stuck" and an error prevents it from completing. I have set my pop-up blockers to ignore Goodreads.

This is a very recent change that I have noticed in the past hour. Books being updated from your Kindle don't have a problem

Also, syncing hasn't been a problem.

Sorry, but that doesn't sound like it has anything directly related to the plugin. The plugin uses the API. It doesn't use web-scraping, so it shouldn't be affected by Captchas. The only thing that could be happening is that it might affect GR's choice of when to apply the Captchas. GR might be using all access from your IP address when making that decision. In which case, the only thing I can suggest is to stop using the plugin or stop editing on GR.

If GR are using to many Captchas, or they aren't working properly, you need to complain to them and ask them to fix it.

[Rellwood]

Thanks! I never ran into CAPTCHAS before on the site. However, as of now the plugin still works ok, I just run into the problem with the error every now and then. Perhaps I have too many rules for the shelves or too many shelves, Good Reads times out if there is too much time to do something.

I created a shelf years ago called "needs cleaning" and impulsivly loaded every book onto it. I can't remember how I did it since there are so many books, must have been an imported .csv. Anyhow it has some 1800 books today on it since everytime I edit a book I remove it from the shelf. Unfortunately, I cannot delete the shelf because Good Reads times out before it can remove it from all those books. Perhaps I may overload the plugin with rules. I have accumulated a LOT of tags for shelves basically pointing to the same shelf and I use the add/sync rules to weed out those tags with individual remove from or add to rules. Also I have date columns to add to each time. I suspect that the plugin might falter if I have too many rules on a shelf and there are too many books on that shelf.

Is it also possible that the order of the rules for sync on a shelf can cause a problem? Since you can't move the rules within the box or organize them in any way other than the order in which they were created, it is possible that I could have duplicate rules. I know that with some shelves there are so many remove from shelf or add to shelf rules that have been updated over time that there is a LONG list for a shelf. Is there a way of updating the plugin so that there could be some way or sorting or allowing the sort to be moved in a rule box? Maybe alphabetically or with those side arrows that allow the row to move up or down? It would help in identifying redundant rules when they are spaced so far that it's hard to compare.