Columns won't keep size in 5.39 - Page 2

chaley · 03-19-2022, 09:36 AM

@kovid: the problem happens because gui2.library.views.restrict_column_width() is called before the main window is resized. At startup the (undisplayed) main window appears to be 100px wide so the calculation of the maximum space available for a column is incorrect. The sizes don't become correct until all the various events are processed, which is at the end of initialization.

I have a fix but I worry that it is not optimal or even correct. I changed restrict_column_width() to do nothing until all of the events to repaint the screen are processed (the same as quickview initialization). This required added an "initialization_complete" boolean to ui.py that restrict_column_width() checks. I can push a PR with these changes if you want to see them.

Edit: restrict_column_width() appeared with pin views.

Edit 2: my guess is that Qt changed how and when some resize and repaint events are processed.

EDIT: see post 19 below

theducks · 03-19-2022, 11:45 AM

??? Is this only happening if you resize a column in a session?
5.39 win10 x64

because the existing size ( set from 5.38) is being maintained

chaley · 03-19-2022, 12:33 PM

Quote:

Originally Posted by theducks

??? Is this only happening if you resize a column in a session?
5.39 win10 x64

because the existing size ( set from 5.38) is being maintained

It is resized, made smaller, if the existing size is larger than somewhere around 260 pixels. The view manager plugin fixes the sizing.

chaley · 03-19-2022, 01:46 PM

@kovid: Never mind post 16. It is caused by my change to library.views.apply_state(). I am testing a fix that maintains the improved performance.

EDIT: PR pushed.

alumoi · 03-19-2022, 02:42 PM

So it's either back to 5.38 or jump to beta?
5.39 on Windows 10 only remembers column size on one library and forgets it for my other 3.
No, the libraries are not on a network drive, only on second HDD.
No, I don't use view manager.

chaley · 03-19-2022, 02:55 PM

Quote:

Originally Posted by alumoi

So it's either back to 5.38 or jump to beta?
5.39 on Windows 10 only remembers column size on one library and forgets it for my other 3.
No, the libraries are not on a network drive, only on second HDD.
No, I don't use view manager.

It is back to 5.38. The latest beta contains the regression. [It doesn't, but that is irrelevant now that 5.39.1 is released. I accidentally tested running from source.]

The regression causes columns above a certain size to be reduced when calibre starts. They aren't reduced when you use switch library.

JSWolf · 03-19-2022, 03:23 PM

Quote:

Originally Posted by chaley

It is back to 5.38. The latest beta contains the regression.

The regression causes columns above a certain size to be reduced when calibre starts. They aren't reduced when you use switch library.

Is there going to be a 5.39.1 with the fix?

Brett Merkey · 03-19-2022, 03:37 PM

I will gladly stick with 5.39 anyway. Not having the Saved Search window blow up on me every time I fidget with it surely compensates for modifying that Title column in the book list back to normal.

chaley · 03-19-2022, 03:47 PM

Quote:

Originally Posted by Brett Merkey

I will gladly stick with 5.39 anyway. Not having the Saved Search window blow up on me every time I fidget with it surely compensates for modifying that Title column in the book list back to normal.

The view manager plugin works around the problem by applying column sizes after calibre initializes. If you set up a default 'apply on start up' view then the sizes in that view will win.

Or wait ...

This plus the title case problem might be enough for Kovid to decide to do a 5.39.1 point release.

EDIT: @JSWolf: there will be a point release if Kovid thinks it is worth it.

JSWolf · 03-19-2022, 06:53 PM

Quote:

Originally Posted by chaley

The view manager plugin works around the problem by applying column sizes after calibre initializes. If you set up a default 'apply on start up' view then the sizes in that view will win.

Or wait ...

This plus the title case problem might be enough for Kovid to decide to do a 5.39.1 point release.

EDIT: @JSWolf: there will be a point release if Kovid thinks it is worth it.

What is the title case problem?

chaley · 03-19-2022, 07:07 PM

Quote:

Originally Posted by JSWolf

What is the title case problem?

See the 7th post in the calibre forum..

JSWolf · 03-20-2022, 06:29 AM

5.39.1 has been released.

alumoi · 03-20-2022, 06:49 AM

And it's working :P

jbacelar · 03-20-2022, 08:19 AM

Yes

JSWolf · 03-20-2022, 12:59 PM

Thanks for the fixes.

03-19-2022, 09:36 AM	#16
chaley Grand Sorcerer Posts: 12,525 Karma: 8065948 Join Date: Jan 2010 Location: Notts, England Device: Kobo Libra 2	@kovid: the problem happens because gui2.library.views.restrict_column_width() is called before the main window is resized. At startup the (undisplayed) main window appears to be 100px wide so the calculation of the maximum space available for a column is incorrect. The sizes don't become correct until all the various events are processed, which is at the end of initialization. I have a fix but I worry that it is not optimal or even correct. I changed restrict_column_width() to do nothing until all of the events to repaint the screen are processed (the same as quickview initialization). This required added an "initialization_complete" boolean to ui.py that restrict_column_width() checks. I can push a PR with these changes if you want to see them. Edit: restrict_column_width() appeared with pin views. Edit 2: my guess is that Qt changed how and when some resize and repaint events are processed. EDIT: see post 19 below Last edited by chaley; 03-19-2022 at 02:33 PM.

03-19-2022, 01:46 PM	#19
chaley Grand Sorcerer Posts: 12,525 Karma: 8065948 Join Date: Jan 2010 Location: Notts, England Device: Kobo Libra 2	@kovid: Never mind post 16. It is caused by my change to library.views.apply_state(). I am testing a fix that maintains the improved performance. EDIT: PR pushed. Last edited by chaley; 03-19-2022 at 02:34 PM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Forgot how to create size columns	Rellwood	Library Management	2	08-06-2021 09:21 PM
columns won't resize	Rellwood	Calibre	4	01-11-2021 11:04 PM
Why won't iBooks allow highlighting and font size changes for one particular ePUB?	wealthychef	Apple Devices	11	07-26-2017 03:27 PM
Font size won't change	Jorge Junior	Sigil	9	09-23-2012 06:19 PM
PDF Won't Change text size	TGNY	PDF	1	10-24-2009 02:20 PM

03-19-2022, 11:45 AM	#17
theducks Well trained by Cats Posts: 31,267 Karma: 61916422 Join Date: Aug 2009 Location: The Central Coast of California Device: Kobo Libra2,Kobo Aura2v1, K4NT(Fixed: New Bat.), Galaxy Tab A	??? Is this only happening if you resize a column in a session? 5.39 win10 x64 because the existing size ( set from 5.38) is being maintained

03-19-2022, 02:42 PM	#20
alumoi Enthusiast Posts: 29 Karma: 10 Join Date: Jan 2012 Device: kindle	So it's either back to 5.38 or jump to beta? 5.39 on Windows 10 only remembers column size on one library and forgets it for my other 3. No, the libraries are not on a network drive, only on second HDD. No, I don't use view manager.

03-19-2022, 03:37 PM	#23
Brett Merkey Not Quite Dead Posts: 195 Karma: 654170 Join Date: Jul 2015 Device: Paperwhite 4; Galaxy Tab	I will gladly stick with 5.39 anyway. Not having the Saved Search window blow up on me every time I fidget with it surely compensates for modifying that Title column in the book list back to normal.

03-20-2022, 06:29 AM	#27
JSWolf Resident Curmudgeon Posts: 80,784 Karma: 150249619 Join Date: Nov 2006 Location: Roslindale, Massachusetts Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3	5.39.1 has been released.

03-20-2022, 06:49 AM	#28
alumoi Enthusiast Posts: 29 Karma: 10 Join Date: Jan 2012 Device: kindle	And it's working :P

03-20-2022, 08:19 AM	#29
jbacelar Interested in the matter Posts: 421 Karma: 426094 Join Date: Dec 2011 Location: Spain, south coast Device: Pocketbook InkPad 3	Yes

03-20-2022, 12:59 PM	#30
JSWolf Resident Curmudgeon Posts: 80,784 Karma: 150249619 Join Date: Nov 2006 Location: Roslindale, Massachusetts Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3	Thanks for the fixes.