Sigil-1.9.1 Release

[KevinH]

Hmm ... after studying this some more, the current Code View tab seems to lose focus initially.

Not sure why ... there were no code changes related to this and qt has not changed. I will see if there are any workarounds in the code. The Current Tab should always get focus unless it is intentionally moved out. Not sure what is might be causing that.

So giving focus to the current tab before doing any searches seems to prevent this problem.

Originally Posted by PapaKilo

-Windows 10
-Sigil 1.9.1
-Search & Replace Docked at bottom of main window.

These conditions for all cases:

#1
Type something in Find, click find button.
Item is found but it is NOT highlighted in main window.
Click find button again.
Item is found but it is NOT highlighted in main window.
Click in main window.
Click find button again.
Item is found but it IS highlighted in main window.


#2
Open Saved Searches window click on a saved search.
Click find button in Saved Searches
Item is found but it is NOT highlighted in main window.

#3
Open Saved Searches window click on a saved search.
Click find button in Saved Searches
Item is found but it is NOT highlighted in main window.
Click on Replace button in docked Find & Replace dialog.
Item is Highlighted in main window, but is NOT replaced.

#4
Click on Spellcheck.
Double-click on misspelled item.
Item is found but it is NOT highlighted in main window.

All of these things functioned in previous versions.

Paul

[DiapDealer]

I've not run into any disappearing Book Browser icons, or a partially obscured Well Formed check (which is the normal Validation Dock Widget) on Windows or Linux in my testing. At least not yet.

[DiapDealer]

I am a little concerned that the CI-created Windows installer is good deal bigger than the official release (92.5 vs 82.5mb). There are some subtle differences between how things are built automatically with GitHub Actions, and how I build them myself on my own machine for releases. 10mb more of ultra-compressed stuff is not negligible.

EDIT: same size on the disk after unpacked and installed, though, so probably nothing. Maybe just different versions of InnoSetup used to create the installer.

[PapaKilo]

Originally Posted by KevinH

You need to have focus in the CV window before running search. All F&R will do is keep the current state.

So click in the CV window first (at least once) to establish it has focus then run your search.

Did that help?

How can you have the CV window in focus when you are typing in the Find & Replace window????????

[KevinH]

Originally Posted by PapaKilo

How can you have the CV window in focus when you are typing in the Find & Replace window????????

After typing what you want in the find field, instead of clicking enter or hitting the Find button click in the main CodeView window once, then hit Find. When you do that the focus band around the Find field will go away. The damn FR find field is stealing focus with the exact same code that before never did that. I am guess it is just the order that events are being processed that changed. And the current code in Search all the way back to Sigil 1.0 makes no sense here at all. It must have been an early bug that someone worked around.

All of that said, I agree this is very bad idea to let F&R Find field to be grabbing focus at all. Given you can click in it to give it focus at any time.

So I have again changed search focus code to try to prevent this and to forcibly give focus back to the MainWindow and remove it from the F&R Find field since you are obviously finished with the Find field (for the time being anyway) once you hit "enter" or Find.

So I will be posting another test build for you to try here when it completes it CI builds in hopefully the next half hour or so.

Please give that a try and let me know if that helps. It seems to bring things back to the old behaviour during my testing but everybody uses Search & Replace in their own way so testing it exhaustingly is next to impossible.

Once we get a stable Sigil-1.9.2 out there I will not be touching F&R again for a long long time. It is so finicky.

[KevinH]

Hi All,

Yes, there is still another new test build available with all changes and fixes to date.
This one includes changes for some Focus issues that have come to light.

It can be downloaded from my repo here:

https://github.com/kevinhendricks/Bu...OnMac/releases

- Sigil-master-c690f8b-build_num-376-Mac.tar.xz 76 MB

- Sigil-master-c690f8b-build_num-376-Win-Setup.exe

Again thanks to everyone who tests and helps make Sigil better.

These builds do not include any fixes the Well-Formed Check dialog coming up partially hidden when the Sigil->Tools->Well-Formed Check EPUB tool is run and the missing icons as I can not recreate either of those (yet!).

[icallaci]

Just a quick note to say that I was seeing the lost focus of the CV window in a couple of previous releases, but I can't remember when I first noticed it. I didn't mention it because I thought I might have been doing something myself to cause it and I didn't want that issue to complicate the non-matching matches issue.

[PapaKilo]

Originally Posted by KevinH

After typing what you want in the find field, instead of clicking enter or hitting the Find button click in the main CodeView window once, then hit Find. When you do that the focus band around the Find field will go away. The damn FR find field is stealing focus with the exact same code that before never did that. I am guess it is just the order that events are being processed that changed. And the current code in Search all the way back to Sigil 1.0 makes no sense here at all. It must have been an early bug that someone worked around.

Well so now I have to type in the Find, click in the CV then click the find button??

Well in that case how do I double click on a misspelled word and then click in the CV window before it finds the misspelled word?

This behavior has only been since 1.7.0 and later. Obviously something broke with the other changes you have made.

Paul

[KevinH]

Yes Paul, please read my posts above. That was a **temporary** workaround. There is a test build that I posted you can try that attempts to fix things properly. So give that a try and let me know if it fixes the issues you are reporting.

Originally Posted by PapaKilo

Well so now I have to type in the Find, click in the CV then click the find button??

Well in that case how do I double click on a misspelled word and then click in the CV window before it finds the misspelled word?

This behavior has only been since 1.7.0 and later. Obviously something broke with the other changes you have made.

Paul

[icallaci]

I had a chance to test the latest release of Sigil (c690f8b-build_num-376), and it seems to be behaving beautifully. I was doing fairly simple Find and Replace searches, nothing complicated (purposely so that if I ran across a problem I would be able to duplicate it for you). So far, so good. If I happen to run across something in a more complicated scenario, I will try to document it, but right now it is working exactly as I would expect (including the code view window not losing focus). Thank you!

[KevinH]

Wonderful!

If you get a free moment please run the SpellCheck dialog tool and make sure it still works as expected. I had forgotten that it makes heavy use of search and replace and have not tested it much.
Unfortunately, I only have access to my iPad this evening so no new test builds (if needed) nor my own testing until tomorrow morning at the earliest.

Thanks!

Kevin

Originally Posted by icallaci

I had a chance to test the latest release of Sigil (c690f8b-build_num-376), and it seems to be behaving beautifully. I was doing fairly simple Find and Replace searches, nothing complicated (purposely so that if I ran across a problem I would be able to duplicate it for you). So far, so good. If I happen to run across something in a more complicated scenario, I will try to document it, but right now it is working exactly as I would expect (including the code view window not losing focus). Thank you!

[PapaKilo]

Originally Posted by KevinH

Yes Paul, please read my posts above. That was a **temporary** workaround. There is a test build that I posted you can try that attempts to fix things properly. So give that a try and let me know if it fixes the issues you are reporting.

I would be happy to test the changes, but I don't know where to download test builds.

[icallaci]

I will give SpellCheck a try and let you know. I have just noticed a possible issue with the CV focus problem. If I enter something in the Find box and click "Count All" or "Find," everything works as it is supposed to. As soon as I click on the dropdown menu to change the direction of the search, the CV window loses focus and doesn't get it back unless I click in it.

[icallaci]

Running SpellCheck causes the current CV window to lose focus. The cursor moves to the correct spot, but the word is not highlighted until you deliberately click on the main Sigil title bar. Actually, I don't think it is SpellCheck itself that is causing the lost focus, but rather the act of clicking on any of the dropdown menus in the title bar. If you doubleclick on a word in the SpellCheck window, then click on the Sigil title bar so that the word is highlighted, then you doubleclick on another word in the SpellCheck window, the CV window loses focus again, so you end up repeating the sequence over and over. In other words, SpellCheck causes the CV window to lose focus every single time you doubleclick on a word in the SpellCheck window. I hope this helps.

[KevinH]

Hmm ... but when you then finally click Find, does it work (put focus back in CV to properly highlight or not). If not, I can try force it to give all focus back to CV when Find is run no matter where the Focus is.

I will try that first thing tomorrow.

Thanks!

Originally Posted by icallaci

I will give SpellCheck a try and let you know. I have just noticed a possible issue with the CV focus problem. If you enter something in the Find box and click "Count All" or "Find," everything works as it is supposed to. As soon as I click on the dropdown menu to change the direction of the search, the CV window loses focus and doesn't get it back unless I click in it.