Register Guidelines E-Books Search Today's Posts Mark Forums Read

Go Back   MobileRead Forums > E-Book Software > Calibre > Plugins

Notices

Reply
 
Thread Tools Search this Thread
Old 10-16-2021, 12:37 PM   #76
jbernardo
Junior Member
jbernardo began at the beginning.
 
Posts: 7
Karma: 10
Join Date: Oct 2021
Device: Android
Release v0-13-1 is out. Turns out I still had a few bugs in handling the author fields, as well as had forgotten to update the version in the plugin.
I also took a first shot at reducing the calls to the Comicvine API, but without much luck.

PS: sometimes calibre gives a constraint error with too short authors name. I am checking on that and will release a fix asap. In the meantime, remove authors from the authors field starting with the shortest name until it stops complaining.
jbernardo is offline   Reply With Quote
Old 10-16-2021, 01:03 PM   #77
jbernardo
Junior Member
jbernardo began at the beginning.
 
Posts: 7
Karma: 10
Join Date: Oct 2021
Device: Android
Quote:
Originally Posted by jbernardo View Post
PS: sometimes calibre gives a constraint error with too short authors name. I am checking on that and will release a fix asap. In the meantime, remove authors from the authors field starting with the shortest name until it stops complaining.
Please ignore this, my db was corrupted.
jbernardo is offline   Reply With Quote
Old 10-16-2021, 01:17 PM   #78
PeterT
Grand Sorcerer
PeterT ought to be getting tired of karma fortunes by now.PeterT ought to be getting tired of karma fortunes by now.PeterT ought to be getting tired of karma fortunes by now.PeterT ought to be getting tired of karma fortunes by now.PeterT ought to be getting tired of karma fortunes by now.PeterT ought to be getting tired of karma fortunes by now.PeterT ought to be getting tired of karma fortunes by now.PeterT ought to be getting tired of karma fortunes by now.PeterT ought to be getting tired of karma fortunes by now.PeterT ought to be getting tired of karma fortunes by now.PeterT ought to be getting tired of karma fortunes by now.
 
PeterT's Avatar
 
Posts: 11,518
Karma: 66677073
Join Date: Nov 2007
Location: Toronto
Device: Nexus 7, Clara, Touch, Tolino EPOS
Please consider attaching the plugin's zip file to your message as opposed to pointing to GitHub

Sent from my Pixel 4a using Tapatalk
PeterT is offline   Reply With Quote
Old 10-17-2021, 03:44 AM   #79
jbernardo
Junior Member
jbernardo began at the beginning.
 
Posts: 7
Karma: 10
Join Date: Oct 2021
Device: Android
Quote:
Originally Posted by PeterT View Post
Please consider attaching the plugin's zip file to your message as opposed to pointing to GitHub

Sent from my Pixel 4a using Tapatalk
Sure, if that is the preferred policy.

Here is the zip for v0-13-1. It is working well for me - but suggestions and bug reports are welcome.
Next release announcement I'll include the zip.
Attached Files
File Type: zip Comicvine.zip (16.7 KB, 29 views)
jbernardo is offline   Reply With Quote
Old 10-17-2021, 04:38 AM   #80
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 40,026
Karma: 17765146
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
since your fork is no longer python 2 compatibile you might want to add minimum_calibre_version = (5, 0, 0)

to the Comicvine plugin class.
kovidgoyal is offline   Reply With Quote
Old 10-17-2021, 07:28 AM   #81
jbernardo
Junior Member
jbernardo began at the beginning.
 
Posts: 7
Karma: 10
Join Date: Oct 2021
Device: Android
Quote:
Originally Posted by kovidgoyal View Post
since your fork is no longer python 2 compatibile you might want to add minimum_calibre_version = (5, 0, 0)

to the Comicvine plugin class.
Thanks, I'll do it. I am still learning...
I'd like to add this plugin to the plugins list later, so I need to read a bit more here on the forums to see how. Will I need a new thread or is it possible to "take over" this one?
jbernardo is offline   Reply With Quote
Old 10-17-2021, 07:41 AM   #82
jbernardo
Junior Member
jbernardo began at the beginning.
 
Posts: 7
Karma: 10
Join Date: Oct 2021
Device: Android
Version v0.13.2 released
Changes:
Spoiler:
Added minimum_calibre_version.
Now returns volume comments if the issue comments are empty.
Updated the included pycomicvine library.


Zip attached, and also available in github
Attached Files
File Type: zip Comicvine.zip (17.4 KB, 50 views)
jbernardo is offline   Reply With Quote
Old 10-22-2021, 02:13 AM   #83
MikeyTsi
Enthusiast
MikeyTsi began at the beginning.
 
Posts: 38
Karma: 10
Join Date: Feb 2014
Device: Nook Color
I'm still using the original plugin, I'm still running v4.x of Calibre.

To your notes, if you specify the comicvine-author field, it should largely ignore title search (since it has the volume information) and looks for a number it can match to a issue. If you specify comicvine it usually ignores all fields since it has a exact issue to match off of. At least that's been my experience. I usually flag volume for ones where I don't get hits since most of them I'll already have an issue that has the volume field applied and can copy/paste faster.

Quote:
Originally Posted by jbernardo View Post
Are you using some other fork of the plugin? It would be interesting to see how others have been updating it. I managed to reach the original author, Russel Heilling, by email, and he agreed with my forking of his code to update it.
I've done a new release just now, fixing search on authors as well as main cover download. Adding an author lets the plugin cut down on the number of issues returned significantly, and speeds up the search and increases accuracy of the returned results. I still don't get any decent results from comicvine if I miss some significant word from the title, but that also happens on the site (eg. searching for "Heavy Metal" instead of "Heavy Metal Magazine").
The new release, v0-13-0, is here.
MikeyTsi is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
[Metadata Source Plugin] Goodreads kiwidude Plugins 581 11-17-2021 06:14 AM
[Metadata Source Plugin] Skoob rodrigoccurvo Plugins 11 06-13-2019 07:44 PM
[Metadata Source Plugin] LubimyCzytac [PL] jbienko1 Plugins 33 01-23-2017 07:15 AM
[Metadata Source Plugin] BIBLIOETECA biblioeteca Plugins 12 10-28-2015 01:39 PM
[Metadata Source Plugin] Amazon.it nandocuci Plugins 2 05-18-2011 03:36 AM


All times are GMT -4. The time now is 04:58 AM.


MobileRead.com is a privately owned, operated and funded community.